Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Web - Members page search bar does not get focused #27497

Merged
merged 22 commits into from
Oct 2, 2023
Merged

fix: Web - Members page search bar does not get focused #27497

Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0b2fbb3
fix: Web - Members page search bar does not get focused
dukenv0307 Sep 15, 2023
d5f44f3
Merge branch 'main' into fix/26955
dukenv0307 Sep 23, 2023
4ef8ea1
merge main
dukenv0307 Sep 26, 2023
c3f05b2
merge main
dukenv0307 Sep 26, 2023
7e9376c
Merge branch 'fix/26955' of https://github.com/dukenv0307/App into fi…
dukenv0307 Sep 26, 2023
c4869c1
fix lint
dukenv0307 Sep 26, 2023
6b8f1e7
refocus on select all
dukenv0307 Sep 26, 2023
4d655cd
Merge branch 'main' into fix/26955
dukenv0307 Sep 27, 2023
9b06dab
refocus after removing user
dukenv0307 Sep 27, 2023
57876ad
fix refocus after removing user
dukenv0307 Sep 27, 2023
c7943a4
refocus whenever the modal is closed
dukenv0307 Sep 27, 2023
4091c6d
merge main
dukenv0307 Sep 27, 2023
28f0016
Merge branch 'main' into fix/26955
dukenv0307 Sep 27, 2023
3653195
add prop type to test jest
dukenv0307 Sep 27, 2023
08a5314
Merge branch 'main' into fix/26955
dukenv0307 Sep 29, 2023
344f5cd
revert to test jest
dukenv0307 Sep 29, 2023
308cc3a
refocus when confirm modal is closed
dukenv0307 Sep 29, 2023
ce1424c
fix jest
dukenv0307 Sep 29, 2023
a9f0545
fix/26955
dukenv0307 Sep 29, 2023
4f9a761
don't refocus on select the row in mobile web
dukenv0307 Sep 29, 2023
e56b36a
merge main
dukenv0307 Oct 2, 2023
c5c8206
fix lint
dukenv0307 Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/SelectionList/BaseSelectionList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ function BaseSelectionList({
};

const selectRow = (item, index) => {
textInputRef.current.focus();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we guarantee that textInputRef.current will always be available in this component?

// In single-selection lists we don't care about updating the focused index, because the list is closed after selecting an item
if (canSelectMultiple) {
if (sections.length === 1) {
Expand Down
Loading