Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove dragover listner when popover hides #27649

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fix remove dragover listner when popover hides #27649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15ee26f
fixes the issue #27375
ishpaul777 Sep 18, 2023
4215731
fix linters early return
ishpaul777 Sep 18, 2023
e837797
fix hidePopoverOnDragOver for early return
ishpaul777 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/pages/home/sidebar/SidebarScreen/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,28 @@ function SidebarScreen(props) {
}, []),
);

/**
* Method to hide popover when dragover.
*/
const hidePopoverOnDragOver = useCallback(() => {
if (!popoverModal.current) {
return;
}
popoverModal.current.hideCreateMenu();
}, []);

/**
* Method create event listener
*/
const createDragoverListener = () => {
document.addEventListener('dragover', () => popoverModal.current.hideCreateMenu());
document.addEventListener('dragover', hidePopoverOnDragOver);
};

/**
* Method remove event listener.
*/
const removeDragoverListener = () => {
document.removeEventListener('dragover', () => popoverModal.current.hideCreateMenu());
document.removeEventListener('dragover', hidePopoverOnDragOver);
};

return (
Expand Down
Loading