[No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792

VickyStash · 2023-09-19T15:10:54Z

Details

Fixed Issues

$ #24880
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.mov

Mobile Web - Chrome

android.google.browser.mov

Mobile Web - Safari

ios.safari.mov

Desktop

Desktop.mov

iOS

ios.mov

Android

android.mp4

rezkiy37 · 2023-09-19T15:35:45Z

src/libs/ActiveClientManager/index.ts

 */
-function isReady() {
+function isReady(): Promise<void> {


It is one line function and TS sets type implicitly.

Suggested change

function isReady(): Promise<void> {

function isReady() {

rezkiy37

LGTM, left a comment.

rezkiy37 · 2023-09-19T15:37:30Z

src/libs/ActiveClientManager/index.ts

 */
-function isClientTheLeader() {
-    return _.last(activeClients) === clientID;
+function isClientTheLeader(): boolean {


This case is up to you, however TS sets here automatically as well.

Suggested change

function isClientTheLeader(): boolean {

function isClientTheLeader() {

@rezkiy37 We should leave return types explicit for most cases, unless the function is like one-line and the return type is void.

fabioh8010 · 2023-09-19T16:33:05Z

src/Expensify.js

@@ -6,7 +6,7 @@ import {AppState, Linking} from 'react-native';
 import Onyx, {withOnyx} from 'react-native-onyx';
 import * as Report from './libs/actions/Report';
 import BootSplash from './libs/BootSplash';
-import * as ActiveClientManager from './libs/ActiveClientManager';
+import ActiveClientManager from './libs/ActiveClientManager';


I would prefer to leave the imports the old way and keep the PR more focused to just convert the files to TS.

fabioh8010 · 2023-09-19T16:34:35Z

src/libs/ActiveClientManager/index.ts

 */
-function isClientTheLeader() {
-    return _.last(activeClients) === clientID;
+function isClientTheLeader(): boolean {


@rezkiy37 We should leave return types explicit for most cases, unless the function is like one-line and the return type is void.

fabioh8010 · 2023-09-19T16:35:49Z

src/libs/ActiveClientManager/types.ts

@@ -0,0 +1,7 @@
+type ActiveClientManagerModule = {


Expanding more on my first comment about not changing the exports, you can create separate types for each function and use it in the files.

type Init = () => void; type IsClientTheLeader = () => boolean; ...

melvin-bot · 2023-09-20T08:18:43Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-09-20T10:50:09Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24880 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MariaHCD

LGTM

MariaHCD · 2023-09-21T08:58:11Z

@0xmiroslav are you able to handle the reviewer checklist?

0xmiros · 2023-09-21T08:59:59Z

C+ doesn't take responsible for checklist on TS migration PRs for now.
Internal discussion: https://expensify.slack.com/archives/C03SSAQ7P/p1693322886736099

blazejkustra

LGTM, SWM still need to do the checklist.

Skalakid · 2023-09-21T14:20:19Z

Reviewing...

Skalakid · 2023-09-21T14:23:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

Skalakid · 2023-09-21T15:20:53Z

@VickyStash I was testing your PR on web and I can't request money. It freezes my browser or starts looping and crashing. Can you check it on your side, please? Maybe it's not connected to this PR, try merging with the latest main

bug.mov

VickyStash · 2023-09-21T15:55:03Z

@Skalakid I was able to reproduce the issue, but after I merged the main it seems to be resolved, so it's not related to this PR

MariaHCD · 2023-10-05T15:15:58Z

Whoops, this PR fell off my radar. Just re-ran the checks. But otherwise, I assume we are good to go?

VickyStash · 2023-10-05T17:31:02Z

@MariaHCD I've merged the main, and checks have passed, looks okay

OSBotify · 2023-10-06T05:39:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-06T08:23:12Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:31:46Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:40:39Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:16:33Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] migrate ActiveClientManager module to TypeScript

d612d49

rezkiy37 reviewed Sep 19, 2023

View reviewed changes

fabioh8010 reviewed Sep 19, 2023

View reviewed changes

Add ActiveClientManager functions types

ab134ae

fabioh8010 approved these changes Sep 19, 2023

View reviewed changes

VickyStash marked this pull request as ready for review September 20, 2023 08:18

VickyStash requested a review from a team as a code owner September 20, 2023 08:18

melvin-bot bot requested review from 0xmiros and removed request for a team September 20, 2023 08:18

0xmiros approved these changes Sep 20, 2023

View reviewed changes

melvin-bot bot requested a review from MariaHCD September 20, 2023 10:50

MariaHCD approved these changes Sep 21, 2023

View reviewed changes

blazejkustra approved these changes Sep 21, 2023

View reviewed changes

Skalakid approved these changes Sep 22, 2023

View reviewed changes

Merge branch 'main' into ts-migration/activeClientManager-lib

418ebf3

MariaHCD merged commit 779a1e5 into Expensify:main Oct 6, 2023
22 checks passed

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

melvin-bot bot mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-16] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #24880

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792

[No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792

VickyStash commented Sep 19, 2023 •

edited

Loading

rezkiy37 Sep 19, 2023

rezkiy37 left a comment

rezkiy37 Sep 19, 2023

fabioh8010 Sep 19, 2023

fabioh8010 Sep 19, 2023

fabioh8010 Sep 19, 2023

fabioh8010 Sep 19, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

MariaHCD left a comment

MariaHCD commented Sep 21, 2023

0xmiros commented Sep 21, 2023 •

edited

Loading

blazejkustra left a comment

Skalakid commented Sep 21, 2023

Skalakid commented Sep 21, 2023 •

edited

Loading

Skalakid commented Sep 21, 2023 •

edited

Loading

VickyStash commented Sep 21, 2023

MariaHCD commented Oct 5, 2023

VickyStash commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

	function isClientTheLeader(): boolean {
	function isClientTheLeader() {

[No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792

[No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792

Conversation

VickyStash commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 Sep 19, 2023

Choose a reason for hiding this comment

rezkiy37 left a comment

Choose a reason for hiding this comment

rezkiy37 Sep 19, 2023

Choose a reason for hiding this comment

fabioh8010 Sep 19, 2023

Choose a reason for hiding this comment

fabioh8010 Sep 19, 2023

Choose a reason for hiding this comment

fabioh8010 Sep 19, 2023

Choose a reason for hiding this comment

fabioh8010 Sep 19, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

MariaHCD left a comment

Choose a reason for hiding this comment

MariaHCD commented Sep 21, 2023

0xmiros commented Sep 21, 2023 • edited Loading

blazejkustra left a comment

Choose a reason for hiding this comment

Skalakid commented Sep 21, 2023

Skalakid commented Sep 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Skalakid commented Sep 21, 2023 • edited Loading

VickyStash commented Sep 21, 2023

MariaHCD commented Oct 5, 2023

VickyStash commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

VickyStash commented Sep 19, 2023 •

edited

Loading

0xmiros commented Sep 21, 2023 •

edited

Loading

Skalakid commented Sep 21, 2023 •

edited

Loading

Skalakid commented Sep 21, 2023 •

edited

Loading