Edit the route of new task page #27909

dukenv0307 · 2023-09-21T03:58:18Z

Details

Change to route of new task page to display not found page with invalid new task page route

Fixed Issues

$ #27363
PROPOSAL: #27363 (comment)

Tests

Go to FAB > Assign task
Enter title, description and go to the next step
Click on Share somewhere option
Copy the URL
Paste and edit the URL to an invalid URL of the task page (https://staging.new.expensify.com/new/task/share-destinationinvalidtext)
Click on the URL and verify that the not found page appears

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to FAB > Assign task
Enter title, description and go to the next step
Click on Share somewhere option
Copy the URL
Paste and edit the URL to an invalid URL of the task page (https://staging.new.expensify.com/new/task/share-destinationinvalidtext)
Click on the URL and verify that the not found page appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.21-09-2023.10.39.51.webm

Mobile Web - Chrome

Record_2023-09-21-10-42-13.mp4

Mobile Web - Safari

Screen.Recording.2023-09-21.at.10.45.02.mov

Desktop

Screen.Recording.2023-09-21.at.11.03.13.mov

iOS

Screen.Recording.2023-09-21.at.10.59.45.mov

Android

27363.webm

melvin-bot · 2023-09-21T12:50:07Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-09-21T20:52:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-21.at.23.11.10.mov

Mobile Web - Chrome

screen-20230921-230330.mp4

Mobile Web - Safari

Screen.Recording.2023-09-21.at.23.04.04.mov

Desktop

Screen.Recording.2023-09-21.at.23.10.52.mov

iOS

Screen.Recording.2023-09-21.at.23.22.55.mov

Android

screen-20230921-232140.mp4

eVoloshchak · 2023-09-21T21:28:39Z

@dukenv0307, please change the tests to following:

Go to FAB > Assign task
Enter title, description and go to the next step
Click on Share somewhere option
Copy the URL
Paste and edit the URL to an invalid URL of the task page (https://staging.new.expensify.com/new/task/share-destinationinvalidtext)
Click on the URL and verify that the not found page appear

dukenv0307 · 2023-09-22T02:42:14Z

Updated.

dukenv0307 · 2023-09-26T07:57:25Z

@aldo-expensify Please help to review the PR when you have a chance.

aldo-expensify · 2023-09-26T08:14:29Z

src/ROUTES.ts

+    NEW_TASK:                                   'new/task',
+    NEW_TASK_ASSIGNEE:                          'new/task/assignee',
+    NEW_TASK_SHARE_DESTINATION:                 'new/task/share-destination',
+    NEW_TASK_DETAILS:                           'new/task/details',
+    NEW_TASK_TITLE:                             'new/task/title',
+    NEW_TASK_DESCRIPTION:                       'new/task/description',


Please revert to the previous alignment? This makes things harder to maintain

@aldo-expensify I just updated.

aldo-expensify

Looks good, but please revert that column alignment in the ROUTES.ts file

OSBotify · 2023-09-28T19:19:21Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:23:18Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:51:55Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:52:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

edit the route of new task page

322201c

dukenv0307 marked this pull request as ready for review September 21, 2023 12:50

dukenv0307 requested a review from a team as a code owner September 21, 2023 12:50

melvin-bot bot requested review from eVoloshchak and removed request for a team September 21, 2023 12:50

eVoloshchak approved these changes Sep 21, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify September 21, 2023 21:27

dukenv0307 added 2 commits September 25, 2023 14:29

merge main

ec9bab2

merge main

c82cd5a

aldo-expensify reviewed Sep 26, 2023

View reviewed changes

aldo-expensify requested changes Sep 26, 2023

View reviewed changes

merge main

e619c60

aldo-expensify previously approved these changes Sep 26, 2023

View reviewed changes

fix jest test

60c2029

dukenv0307 dismissed aldo-expensify’s stale review via 60c2029 September 26, 2023 08:44

fix lint

184edfc

aldo-expensify approved these changes Sep 26, 2023

View reviewed changes

aldo-expensify merged commit 85a9c5f into Expensify:main Sep 26, 2023
11 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-09] [$500] Assign task - App allows to add anything ahead of confirm task URL and maintains the same URL throughout the process #27363

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit the route of new task page #27909

Edit the route of new task page #27909

dukenv0307 commented Sep 21, 2023 •

edited

Loading

melvin-bot bot commented Sep 21, 2023

eVoloshchak commented Sep 21, 2023 •

edited

Loading

eVoloshchak commented Sep 21, 2023

dukenv0307 commented Sep 22, 2023

dukenv0307 commented Sep 26, 2023

aldo-expensify Sep 26, 2023

dukenv0307 Sep 26, 2023

aldo-expensify left a comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Edit the route of new task page #27909

Edit the route of new task page #27909

Conversation

dukenv0307 commented Sep 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 21, 2023

eVoloshchak commented Sep 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak commented Sep 21, 2023

dukenv0307 commented Sep 22, 2023

dukenv0307 commented Sep 26, 2023

aldo-expensify Sep 26, 2023

Choose a reason for hiding this comment

dukenv0307 Sep 26, 2023

Choose a reason for hiding this comment

aldo-expensify left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

dukenv0307 commented Sep 21, 2023 •

edited

Loading

eVoloshchak commented Sep 21, 2023 •

edited

Loading