Set openByDefault prop only for small screen width #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix works best when it's applied on top of this change #2799 |
TomatoToaster
approved these changes
May 12, 2021
Thanks for the quick review @TomatoToaster , I think it's fine to just merge this one as it doesn't depend on #2799 |
36 tasks
|
🚀 Deployed to staging in version: 1.0.42-3🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
tugbadogan
deleted the
tugbadogan-fix-non-accessible-chats-in-portrait-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Jag96
Details
When we set openByDefault on persistent drawer, it stays open when the orientation is changed back to portrait even though the current route is set to a chat. This is causing an issue in react-navigation and drawer is not being closed when another chat is selected.
Fixed Issues
Fixes #2447
Tests
Verified that chats are accessible when the orientation is switched between landscape and portrait. And chat view is not closed when the app is sent to background.
QA Steps
Tested On
Screenshots
Mobile Web
Screen.Recording.2021-05-12.at.01.16.24.mov
Desktop
Screen.Recording.2021-05-12.at.01.19.50.480p.mov
iOS (iPhone)
Screen.Recording.2021-05-11.at.19.29.18.480p.mov
iOS (iPad)
Screen.Recording.2021-05-12.at.01.11.39.480p.mov
Android
Screen.Recording.2021-05-12.at.01.55.49.480p.2.mov