Bump onyx #28299

ospfranco · 2023-09-27T06:01:23Z

Details

Bumps onyx to take care of the 2fa page not synchronizing across tabs, which was fixed with Propagate merge events across tabs react-native-onyx#369. Check attached video to see the fix in action. This needs to be QAd
Using a map for pending promises. A performance optimization.
Use a fast path when asking for a single key. Also a performance optimization.

Fixed Issues

$ #26190
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-09-27.at.08.03.06.mp4

Mobile Web - Chrome

Screen_Recording_20230928_104640_Brave.mp4

Mobile Web - Safari

RPReplay_Final1695890446.MP4

Desktop

iOS

No applicable to the mobile app

Android

No applicable to the mobile app

melvin-bot · 2023-09-27T06:01:29Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-09-28T06:15:49Z

@ospfranco This PR has merge conflicts? Could you resolve those?

# Conflicts: # package-lock.json # package.json

ospfranco · 2023-09-28T06:54:45Z

Bumped onyx to the latest version

abdulrahuman5196 · 2023-09-28T07:55:53Z

Reviewing now

abdulrahuman5196 · 2023-09-28T08:06:15Z

There has been 5 PR changes in onyx getting into via this upgrade.

3 from @Szymon20000

Expensify/react-native-onyx#365

Expensify/react-native-onyx#363

Expensify/react-native-onyx#364

1 PR from @chrispader

Expensify/react-native-onyx#339

1 PR from @ospfranco

Expensify/react-native-onyx#369

This PR was targeted to bump onyx to fix this issue - #26190.
If possible could the authors(@chrispader @Szymon20000 ) confirm its fine to bring their changes meanwhile.

chrispader · 2023-09-28T08:08:48Z

1 PR from @chrispader

Expensify/react-native-onyx#339

If possible could the authors(@chrispader @Szymon20000 ) confirm its fine to bring their changes meanwhile.

Yes, you can ship the changes from my PR 👍🏼

abdulrahuman5196 · 2023-09-28T08:09:33Z

@ospfranco

Comments on authors checklist

Kindly add tests for this PR.
Even though the targeted issue is only present in web, the fix is present at a generic places. So it should be required to test on all platforms(atleast normal cases working) and attach testing videos. Kindly add testing videos for other platforms as well.

Szymon20000 · 2023-09-28T08:11:57Z

My changes are also ready to land on main :)

abdulrahuman5196 · 2023-09-28T08:25:05Z

package-lock.json

@@ -90,7 +90,7 @@
        "react-native-linear-gradient": "^2.8.1",
        "react-native-localize": "^2.2.6",
        "react-native-modal": "^13.0.0",
-        "react-native-onyx": "1.0.89",
+        "react-native-onyx": "1.0.93",


@ospfranco version number here is wrong. Could you rectify this?

ospfranco · 2023-09-28T08:58:16Z

Here are the videos for iOS and Android. I don't think the flow is applicable to desktop.

Screen_Recording_20230928_104640_Brave.mp4

RPReplay_Final1695890446.MP4

abdulrahuman5196 · 2023-09-28T08:59:54Z

@ospfranco thank you. kindly add the same in the author's checklist.

I don't think we can test for desktop, but you can still test for mobile safari and chrome?

But for desktop also we can just check if normal login is working fine

ospfranco · 2023-09-28T09:08:58Z

The video I posted is iOS safari and chrome on Android. Or what do you mean?

Didn't touch the login code, this is only synchronization between browser tabs. So that is working fine.

abdulrahuman5196 · 2023-09-28T09:10:50Z

@ospfranco Sorry My bad. Mistook the videos. Should be fine then.

abdulrahuman5196 · 2023-09-28T09:13:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-28.at.2.14.27.PM.mp4

Screen.Recording.2023-09-28.at.2.15.12.PM.mp4

Mobile Web - Chrome

az_recorder_20230928_150032.mp4

Mobile Web - Safari

Screen.Recording.2023-09-28.at.2.18.03.PM.mp4

Desktop

Screen.Recording.2023-09-28.at.2.41.17.PM.mp4

iOS

Screen.Recording.2023-09-28.at.2.35.31.PM.mp4

Android

Screen.Recording.2023-09-28.at.2.53.50.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @luacmartins / @mountiny

🎀 👀 🎀
C+ Reviewed

OSBotify · 2023-09-28T09:49:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:16:10Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:20:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:48:40Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:49:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Bump onyx

940d8b0

ospfranco requested a review from a team as a code owner September 27, 2023 06:01

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team September 27, 2023 06:01

Merge branch 'main' into osp/bump-onyx

78ff885

# Conflicts: # package-lock.json # package.json

ospfranco added 2 commits September 28, 2023 09:19

Bump onyx

4ae0f5e

Merge branch 'main' into osp/bump-onyx

49ba579

ospfranco mentioned this pull request Sep 28, 2023

[HOLD for payment 2023-10-09] [$500] Login - Abracadabra/2FA page displays but user can't login/continue until page is reloaded #26190

Closed

6 tasks

abdulrahuman5196 suggested changes Sep 28, 2023

View reviewed changes

Update package.lock

b9976a1

abdulrahuman5196 approved these changes Sep 28, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins September 28, 2023 09:35

luacmartins approved these changes Sep 28, 2023

View reviewed changes

luacmartins merged commit 8f92b76 into Expensify:main Sep 28, 2023
14 checks passed

ospfranco deleted the osp/bump-onyx branch September 28, 2023 09:40

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

pradeepmdk mentioned this pull request Sep 29, 2023

[$500] Asking sign-in again from public room after refresh #27198

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump onyx #28299

Bump onyx #28299

ospfranco commented Sep 27, 2023 •

edited

Loading

melvin-bot bot commented Sep 27, 2023

abdulrahuman5196 commented Sep 28, 2023

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

chrispader commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

Szymon20000 commented Sep 28, 2023

abdulrahuman5196 Sep 28, 2023 •

edited

Loading

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023 •

edited

Loading

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Bump onyx #28299

Bump onyx #28299

Conversation

ospfranco commented Sep 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 27, 2023

abdulrahuman5196 commented Sep 28, 2023

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

chrispader commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

Szymon20000 commented Sep 28, 2023

abdulrahuman5196 Sep 28, 2023 • edited Loading

Choose a reason for hiding this comment

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023 • edited Loading

ospfranco commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

ospfranco commented Sep 27, 2023 •

edited

Loading

abdulrahuman5196 Sep 28, 2023 •

edited

Loading

abdulrahuman5196 commented Sep 28, 2023 •

edited

Loading

abdulrahuman5196 commented Sep 28, 2023 •

edited

Loading