Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Per-Diem.md #28513

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Update Per-Diem.md #28513

merged 8 commits into from
Oct 5, 2023

Conversation

strepanier03
Copy link
Contributor

@strepanier03 strepanier03 commented Sep 29, 2023

cc: @rushatgabhane

Adding copy for Workspace Expense Settings doc.

$ https://github.com/Expensify/Expensify/issues/311436

QA Testing Steps:

  1. Go to help.expensify.com
  2. Navigate to Expensify Classic > Policy and Domain settings > Per Diems
  3. Verify that the article has content and there are no formatting errors

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

Adding copy for Per Diem help doc
@strepanier03 strepanier03 requested a review from a team as a code owner September 29, 2023 16:43
@strepanier03 strepanier03 self-assigned this Sep 29, 2023
@melvin-bot melvin-bot bot removed the request for review from a team September 29, 2023 16:43
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@strepanier03
Copy link
Contributor Author

I know I'll need to update the description, doing that now.

Updating description.
strepanier03 and others added 2 commits September 29, 2023 10:39
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
strepanier03 and others added 4 commits October 2, 2023 17:40
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
…-Diem.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@melvin-bot melvin-bot bot requested a review from thienlnam October 3, 2023 00:49
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28672.

@thienlnam
Copy link
Contributor

Ah @strepanier03, could you paste the below in a comment here to sign the CLA?

I have read the CLA Document and I hereby sign the CLA

@strepanier03
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@thienlnam thienlnam merged commit 86dfb04 into main Oct 5, 2023
15 checks passed
@thienlnam thienlnam deleted the strepanier03-patch-3 branch October 5, 2023 07:27
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1200.619 ms → 1296.117 ms (+95.499 ms, +8.0%) 🔴
App start runJsBundle 822.522 ms → 894.833 ms (+72.312 ms, +8.8%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1200.619 ms
Stdev: 39.094 ms (3.3%)
Runs: 1107.5569740002975 1112.6551740001887 1127.6424620002508 1130.6864459998906 1137.1012350004166 1138.454559000209 1140.2489489996806 1147.8711569998413 1150.1962360003963 1151.316200000234 1152.5894130002707 1153.417306999676 1158.5271579995751 1160.5532160000876 1161.3420289997011 1162.5604370003566 1162.7410369999707 1164.7880410002545 1166.554223000072 1166.7877519996837 1166.9975690003484 1169.3425209997222 1172.1115480000153 1175.748286000453 1176.2000179998577 1176.704175000079 1176.7313540000468 1176.7978910002857 1178.2451689997688 1180.0433839997277 1180.7885579997674 1183.8701320001855 1184.2334249997512 1186.703288000077 1186.9301770003513 1189.9256109995767 1194.405760999769 1194.4210050003603 1194.4590619998053 1197.5238819997758 1198.2957549998537 1199.122805999592 1199.3926740000024 1201.6193289998919 1202.304831000045 1202.5604870002717 1202.7850129995495 1202.8331319997087 1205.6228210004047 1206.9594660000876 1206.9696770003065 1207.2181749995798 1212.086338000372 1212.311455000192 1212.3480789996684 1213.2221959996969 1214.2371540004387 1214.4589299997315 1217.9597060000524 1217.9696169998497 1218.5231689997017 1218.9278109995648 1219.3653450002894 1219.6573729999363 1219.8760599996895 1219.9858079999685 1222.3335149995983 1226.832861999981 1227.6007319996133 1229.9103809995577 1230.1567350002006 1231.2345690000802 1232.7329709995538 1236.3332580002025 1236.683152999729 1236.6890150001273 1237.2415190003812 1238.5787559999153 1242.189384999685 1242.7036939999089 1242.7047100001946 1246.6234670002013 1255.1663269996643 1257.2082420000806 1260.1552370004356 1260.9390620002523 1267.1513769999146 1272.8429800001904 1274.0466820001602 1292.910500000231 1292.9634339995682

Current
Mean: 1296.117 ms
Stdev: 48.860 ms (3.8%)
Runs: 1181.6671470003203 1193.6465290002525 1214.3617270002142 1216.8252189997584 1218.3555880002677 1221.084920000285 1222.8195409998298 1229.9880050001666 1230.3144579995424 1233.1483869999647 1233.2674179999158 1235.8164200000465 1241.4848009999841 1242.7459979997948 1242.8147200001404 1243.0065059997141 1243.4007550003007 1245.3753599999472 1246.704777999781 1252.7252129996195 1254.8624280001968 1256.8860750002787 1258.58574999962 1260.5748300002888 1261.6494199996814 1263.3950589997694 1265.0380859998986 1272.9739699997008 1273.5804869998246 1274.3151960000396 1274.4533259999007 1275.9627189999446 1277.4365819999948 1278.6832459997386 1278.999405999668 1279.3984319996089 1279.822000999935 1283.6362460004166 1284.744436999783 1285.261216999963 1291.6064579999074 1296.1548539996147 1298.3456659996882 1298.6520680002868 1299.0973100000992 1299.45196400024 1299.6073000002652 1300.67071999982 1300.9459300003946 1301.8419749997556 1304.5799059998244 1308.1845840001479 1308.9358670003712 1309.263759999536 1310.3236410003155 1310.8690959997475 1311.0941700004041 1317.9185840003192 1318.1557449996471 1322.67419099994 1323.8697979999706 1325.7954970002174 1326.2399300001562 1326.5691529996693 1326.9003170002252 1327.8526649996638 1328.1334210000932 1329.0772399995476 1330.3045800002292 1330.8184930002317 1331.8573660003021 1335.1969499997795 1335.7006719997153 1337.9374080002308 1339.981785999611 1341.928656999953 1342.3436129996553 1342.3709530001506 1342.6523350002244 1348.7260910002515 1350.0374779999256 1351.6345960004255 1356.0015550004318 1356.9184940000996 1361.6546809999272 1364.342915999703 1378.6116019999608 1380.6409320002422 1397.5318959997967 1410.9493129998446 1425.916853999719
App start runJsBundle Baseline
Mean: 822.522 ms
Stdev: 35.057 ms (4.3%)
Runs: 741 744 755 759 763 767 768 771 774 777 778 779 786 788 789 789 791 791 792 795 796 797 798 799 801 801 801 803 804 804 806 807 808 810 811 811 813 814 814 815 816 816 816 816 816 820 823 824 825 825 828 828 829 830 831 833 833 835 837 839 840 840 840 841 842 844 846 848 849 850 852 854 856 857 859 860 861 863 863 864 865 866 866 866 868 869 871 872 874 887 900 909

Current
Mean: 894.833 ms
Stdev: 33.648 ms (3.8%)
Runs: 811 837 840 842 843 843 844 847 849 849 853 856 857 858 858 859 864 865 867 867 867 868 869 870 872 872 872 874 874 875 878 880 882 883 883 884 888 889 889 891 892 892 892 894 894 895 895 896 897 900 900 900 901 903 904 905 906 907 907 908 910 911 913 914 914 920 921 921 922 924 924 925 925 926 928 930 931 932 934 934 939 941 941 942 943 946 951 964 972 980

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 618.767 ms → 624.153 ms (+5.385 ms, +0.9%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +6.1%)
App start nativeLaunch 21.648 ms → 21.143 ms (-0.505 ms, -2.3%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 618.767 ms
Stdev: 21.814 ms (3.5%)
Runs: 587.5891519999132 587.7652590004727 588.290811999701 589.41955600027 589.547038000077 590.8016769997776 592.5793459992856 595.1176359998062 595.6794440001249 596.73852599971 596.7740480005741 596.8278409997001 597.0673430003226 598.5428879996762 598.9534919997677 599.4078780002892 599.6328130001202 599.7836920004338 600.0241299998015 601.0209970008582 601.1059979991987 602.6232099998742 603.5939530003816 603.8186029996723 604.443847999908 604.6241460004821 604.6759439995512 605.2282309997827 605.2505700001493 605.5048829996958 605.5738129997626 605.6931559992954 606.3917239997536 606.5883790003136 606.6655679997057 607.1710209995508 607.6164149995893 607.9464929997921 607.9512129994109 608.5642499998212 608.8095699995756 609.4277759995311 610.1558429999277 611.2082930002362 611.6469320002943 612.0476069999859 612.1913649998605 613.8559980001301 614.5124519998208 614.5319419996813 614.8495279997587 616.0119230002165 616.6122640008107 617.1530759995803 620.373007000424 621.0671790000051 621.45544399973 621.6907560005784 622.0993659999222 622.2599289994687 622.5863859998062 623.6536060003564 623.7904869997874 625.5957440007478 625.8072110004723 627.3013100000098 630.9742839997634 632.1828610002995 632.7764079999179 633.7976890001446 635.7816570000723 635.8498949995264 636.0338139999658 637.0928549999371 637.5463469997048 638.9637449998409 640.6077890004963 640.7178959995508 640.9833990000188 642.3942870004103 649.1982019999996 649.5043140007183 650.8433029996231 652.6761069996282 658.3893640004098 660.5698250001296 660.9161780001596 662.7586260000244 667.6816819999367 669.6177169997245 674.8818769995123 680.5666510006413

Current
Mean: 624.153 ms
Stdev: 17.909 ms (2.9%)
Runs: 595.9526370000094 597.2337250001729 597.3386230003089 597.6988930003718 599.935792000033 603.316203000024 603.660237999633 604.1688649998978 604.9968259995803 605.0729979993775 605.119384999387 605.5136730000377 605.7531740004197 606.1708580004051 606.3278409997001 606.4479170003906 606.8391929995269 607.1460779998451 607.5867520002648 608.3081869995221 608.481608000584 608.9640299994498 609.0498870005831 611.8850500006229 612.5726330000907 612.6392829995602 612.7296959999949 613.0109459999949 613.4984950004146 613.7668460002169 613.8822839995846 614.2522390000522 614.512085000053 615.0310060000047 615.4621580000967 615.594076000154 616.025065000169 616.2733559999615 616.2870689993724 616.9518230007961 619.8769939998165 620.6955570001155 620.9298919998109 621.0071609998122 621.2479250002652 621.4565840000287 621.4584150006995 621.5183109994978 621.7686360003427 621.8958339998499 622.443847999908 622.7151290001348 622.7399089997634 623.2502039996907 624.1380219999701 624.1688639996573 624.1847740001976 626.0475260000676 628.8762620007619 629.0840659998357 629.5210370002314 630.622192999348 632.397135999985 632.503866000101 635.7749839993194 636.1556799998507 636.3732909997925 638.4233809998259 638.7585859997198 639.8724779998884 640.0604649996385 641.3680429998785 642.144328000024 644.340168999508 646.537313000299 647.2736810008064 649.8839929997921 650.437458999455 650.793171999976 653.5281990002841 654.0112300002947 654.5834959996864 655.6244310000911 656.0976980002597 656.519043000415 658.941244000569 663.6855469997972 663.863241000101 664.5423579998314
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.7%)
Runs: 0.012736000120639801 0.012980000115931034 0.012980000115931034 0.013061000034213066 0.01342800073325634 0.01355000026524067 0.013590999878942966 0.013631000183522701 0.013631000183522701 0.01375299971550703 0.013753999955952168 0.013794000260531902 0.013833999633789062 0.01387499924749136 0.013996999710798264 0.014038000255823135 0.014077999629080296 0.014079000800848007 0.014119000174105167 0.014120000414550304 0.014120000414550304 0.014159999787807465 0.014200999401509762 0.014200999401509762 0.014201000332832336 0.014241000637412071 0.014241999946534634 0.014241999946534634 0.014322999864816666 0.0143630001693964 0.0143630001693964 0.014403999783098698 0.014403999783098698 0.014405000023543835 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014526000246405602 0.014607000164687634 0.014607000164687634 0.014649000018835068 0.014688999392092228 0.0147299999371171 0.014730000868439674 0.014771000482141972 0.014810999855399132 0.014810999855399132 0.014851999469101429 0.014851999469101429 0.014933000318706036 0.015013999305665493 0.015013999305665493 0.015095999464392662 0.015096000395715237 0.015135999768972397 0.015219000168144703 0.015299000777304173 0.015300000086426735 0.015339999459683895 0.015339999459683895 0.01537999976426363 0.015420999377965927 0.015422000549733639 0.015461999922990799 0.015461999922990799 0.01550300046801567 0.015544000081717968 0.015544000081717968 0.015625 0.01570700015872717 0.01574699953198433 0.015747000463306904 0.015747000463306904 0.015868999995291233 0.015909000299870968 0.015910000540316105 0.015910000540316105 0.01607299968600273 0.016193999908864498 0.016235999763011932 0.016276000067591667 0.016358000226318836 0.01660200022161007 0.016723000444471836 0.016846000216901302 0.01696799974888563 0.017293999902904034 0.017822000198066235

Current
Mean: 0.016 ms
Stdev: 0.001 ms (5.9%)
Runs: 0.01375299971550703 0.013793999329209328 0.0138349998742342 0.014283000491559505 0.01444500032812357 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014648000709712505 0.014770000241696835 0.014770000241696835 0.014851000159978867 0.014932999387383461 0.014973999932408333 0.014974000863730907 0.015054999850690365 0.015056000091135502 0.015095999464392662 0.015137000009417534 0.015176999382674694 0.015176999382674694 0.015177000313997269 0.0152580002322793 0.0152580002322793 0.015258999541401863 0.01529999915510416 0.01529999915510416 0.015339999459683895 0.01534000039100647 0.01534000039100647 0.015420999377965927 0.015420999377965927 0.015422000549733639 0.015461999922990799 0.01550300046801567 0.01550300046801567 0.015542999841272831 0.015583999454975128 0.015583999454975128 0.015584000386297703 0.015666000545024872 0.015666000545024872 0.015705999918282032 0.01574699953198433 0.015747000463306904 0.015828999690711498 0.015829000622034073 0.015868999995291233 0.015910000540316105 0.015951000154018402 0.015990999527275562 0.015991000458598137 0.016071999445557594 0.01607200037688017 0.01607299968600273 0.016112999990582466 0.016112999990582466 0.016114000231027603 0.016153999604284763 0.016193999908864498 0.016195000149309635 0.016234999522566795 0.016234999522566795 0.01623500045388937 0.016235999763011932 0.016276000067591667 0.016276000067591667 0.016316000372171402 0.016397999599575996 0.0165200000628829 0.016560999676585197 0.016561000607907772 0.0167239997535944 0.01680499967187643 0.016885999590158463 0.016927000135183334 0.01696799974888563 0.017130999825894833 0.017170999199151993 0.017171000130474567 0.017172000370919704 0.017211999744176865 0.0174150001257658 0.017455999739468098 0.017903000116348267 0.017985000275075436 0.018066000193357468
App start nativeLaunch Baseline
Mean: 21.648 ms
Stdev: 3.071 ms (14.2%)
Runs: 17 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 25 25 26 26 27 27 27 27 27 28 28 29 29 30 30

Current
Mean: 21.143 ms
Stdev: 2.188 ms (10.4%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 25 25 26 26 26 27 27 27

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants