Fix map preview not extended to full view #28922

kosmydel · 2023-10-05T14:31:13Z

Details

Fixed Issues

$ #28911
$ #26307 (comment)
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Click Request Money
Go to the distance tab
Check the map appearance (verify border-radius, paddings, border-width, etc.)
Select two random stops
Press Next, select a workspace
Check the map appearance (verify as above)
Do the same in the offline mode (so the Pending map view is displayed).

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

OLD:

Mobile Web - Chrome

OLD:

![Screenshot 2023-10-10 at 11 50 46](https://github.com/Expensify/App/assets/104823336/42f7335d-0a19-42f4-b032-165bb687c533) ![Screenshot 2023-10-10 at 11 51 16](https://github.com/Expensify/App/assets/104823336/1bfe9fa4-63d2-4ffb-aa05-ff1c6e726631) ![Screenshot 2023-10-10 at 11 51 20](https://github.com/Expensify/App/assets/104823336/e3b985cc-36e2-4dd7-8845-5e53ad4aeb23)

Mobile Web - Safari

![Screenshot 2023-10-10 at 11 50 41](https://github.com/Expensify/App/assets/104823336/3f7eb85b-455f-4d50-b3d3-11e4736fa1bd)

OLD:

Desktop

OLD:

iOS

OLD:

Android

OLD:

melvin-bot · 2023-10-05T14:45:34Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-10-05T15:37:03Z

@jjcoffee I'll be reviewing this as this stemmed from the PR I reviewed

shawnborton · 2023-10-05T16:38:33Z

That looks good to me. I thought we also decided not to disable the submit button for the form submission. Do we know if that is being handled anywhere? cc @JmillsExpensify @trjExpensify @tgolen

shawnborton · 2023-10-05T16:39:07Z

@kosmydel can you also share what this looks like when we have say 5-6 waypoints?

situchan · 2023-10-05T16:42:12Z

That looks good to me. I thought we also decided not to disable the submit button for the form submission. Do we know if that is being handled anywhere? cc @JmillsExpensify @trjExpensify @tgolen

yes - #27045

kosmydel · 2023-10-05T22:01:33Z

@kosmydel can you also share what this looks like when we have say 5-6 waypoints?

Sure @shawnborton, here are some screens (I will add them to the description as well):

Web

iOS

mWeb - iOS

shawnborton · 2023-10-05T23:13:42Z

Nice, those look good. Can you show me what it looks like when you scroll down, too?

kosmydel · 2023-10-09T09:45:22Z

I've added the cleanup change mentioned here to this PR.

Nice, those look good. Can you show me what it looks like when you scroll down, too?

Sure @shawnborton!

Web

web.mov

iOS

ios.mp4

mWeb - iOS

mWeb-ios.mp4

mWeb - Android

mweb-android.mov

Android

android.mov

kosmydel · 2023-10-09T09:47:02Z

src/components/DistanceRequest/index.js

-    mapboxAccessToken: {
-        key: ONYXKEYS.MAPBOX_ACCESS_TOKEN,
-    },


This is a cleanup change, discussed here.

shawnborton · 2023-10-09T12:31:11Z

Nice, that looks good to me! The only minor thing here is that at some point, the map area became skinnier than we wanted. cc @neil-marcellini as I know you have noticed this too. Basically it should look like this, which should match the width we are using for the camera area of the Scan page:

kosmydel · 2023-10-09T13:03:20Z

@shawnborton I changed padding from 16px to 8px. If you want me to change the padding to some different value please let me know.

Here is how it looks right now:

Web

iOS

mWeb - iOS

shawnborton · 2023-10-09T13:06:13Z

Nice! Can you confirm that's exactly what we have on the Scan page, as well as the same border radius we're using there? Thanks!

kosmydel · 2023-10-09T13:30:36Z

Nice! Can you confirm that's exactly what we have on the Scan page, as well as the same border radius we're using there? Thanks!

I will check it tomorrow, as I'm finishing my work for today.

kosmydel · 2023-10-12T08:05:39Z

I've refactored it. Here is a video presenting both the map and its pending view:

Video

full.mov

tgolen

Great, thanks for refactoring those styles a little.

tgolen · 2023-10-13T16:20:35Z

There are some conflicts on here now. @situchan this is waiting on your final review.

situchan · 2023-10-13T16:21:22Z

I will checklist once conflict resolved

kosmydel · 2023-10-16T08:36:50Z

Conflicts resolved, and quickly tested it

cc @situchan

EDIT:

I found an issue: When selecting the first stop to the Distance Request the other empty stop is removed. Not sure if this is intentional. It is not occurring in the production.

Video

Screen.Recording.2023-10-16.at.10.55.38.mov

Reported it here.

pecanoro · 2023-10-19T00:41:19Z

@situchan can you do a review as soon as possible? It's a high priority issue and it has been waiting for 3 days.

situchan · 2023-10-19T05:15:14Z

reviewing now

situchan · 2023-10-19T08:13:54Z

I found an issue: When selecting the first stop to the Distance Request the other empty stop is removed. Not sure if this is intentional. It is not occurring in the production.

Video
Screen.Recording.2023-10-16.at.10.55.38.mov
Reported it here.

This was fixed in #29811. Not reproducible anymore

situchan · 2023-10-19T08:42:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

Pulled main into this branch locally and tests well (some known bugs are gone).

blazejkustra

LGTM, code looks good to me!

OSBotify · 2023-10-19T12:46:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:39:06Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:51:18Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kosmydel added 2 commits October 5, 2023 16:30

fix

1144ad4

fix native

d8f451f

kosmydel marked this pull request as ready for review October 5, 2023 14:45

kosmydel requested a review from a team as a code owner October 5, 2023 14:45

melvin-bot bot requested review from jjcoffee and removed request for a team October 5, 2023 14:45

mountiny requested a review from shawnborton October 5, 2023 14:48

mountiny assigned kosmydel Oct 5, 2023

kosmydel added 2 commits October 6, 2023 08:08

cleanup

e311f75

Merge branch 'expensify-main' into fix-scrollview-container

1847edf

situchan mentioned this pull request Oct 8, 2023

[$500] [Distance] - Map does not zoom out to show the entire route when the map window is reduced #26724

Closed

6 tasks

kosmydel added 2 commits October 9, 2023 10:34

Merge branch 'main' into fix-scrollview-container

1fdbc39

Merge branch 'main' into fix-scrollview-container

def8e91

kosmydel marked this pull request as draft October 9, 2023 09:21

fix scrolling on the native

980b5ed

kosmydel marked this pull request as ready for review October 9, 2023 09:45

kosmydel commented Oct 9, 2023

View reviewed changes

change padding

25d4823

kosmydel added 2 commits October 12, 2023 09:15

Merge branch 'main' into fix-scrollview-container

10339a2

refactor styling

a1aaf84

kosmydel requested a review from tgolen October 12, 2023 08:06

tgolen previously approved these changes Oct 12, 2023

View reviewed changes

Merge branch 'main' into fix-scrollview-container

26db9ca

kosmydel dismissed tgolen’s stale review via 26db9ca October 16, 2023 08:35

kosmydel added 2 commits October 16, 2023 10:37

fix merge

81ca6ce

fix merge

00ba5e5

neil-marcellini requested a review from pecanoro October 18, 2023 21:08

situchan approved these changes Oct 19, 2023

View reviewed changes

blazejkustra approved these changes Oct 19, 2023

View reviewed changes

tgolen approved these changes Oct 19, 2023

View reviewed changes

tgolen merged commit 69ad7bd into Expensify:main Oct 19, 2023
13 checks passed

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

melvin-bot bot mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-30] Distance IOU - Map preview is not extended to full view on RHP #28911

Closed

6 tasks

idanbe4 mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 be4solutions/App#10

Open

MelvinBot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42357

Closed

50 tasks

melvin-bot bot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix map preview not extended to full view #28922

Fix map preview not extended to full view #28922

kosmydel commented Oct 5, 2023 •

edited

Loading

melvin-bot bot commented Oct 5, 2023

situchan commented Oct 5, 2023

shawnborton commented Oct 5, 2023

shawnborton commented Oct 5, 2023

situchan commented Oct 5, 2023

kosmydel commented Oct 5, 2023

shawnborton commented Oct 5, 2023

kosmydel commented Oct 9, 2023

kosmydel Oct 9, 2023

tgolen Oct 9, 2023

shawnborton commented Oct 9, 2023

kosmydel commented Oct 9, 2023 •

edited

Loading

shawnborton commented Oct 9, 2023

kosmydel commented Oct 9, 2023

kosmydel commented Oct 12, 2023

tgolen left a comment

tgolen commented Oct 13, 2023

situchan commented Oct 13, 2023

kosmydel commented Oct 16, 2023 •

edited

Loading

pecanoro commented Oct 19, 2023

situchan commented Oct 19, 2023

situchan commented Oct 19, 2023

situchan commented Oct 19, 2023

situchan left a comment

blazejkustra left a comment

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

Fix map preview not extended to full view #28922

Fix map preview not extended to full view #28922

Conversation

kosmydel commented Oct 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 5, 2023

situchan commented Oct 5, 2023

shawnborton commented Oct 5, 2023

shawnborton commented Oct 5, 2023

situchan commented Oct 5, 2023

kosmydel commented Oct 5, 2023

shawnborton commented Oct 5, 2023

kosmydel commented Oct 9, 2023

kosmydel Oct 9, 2023

Choose a reason for hiding this comment

tgolen Oct 9, 2023

Choose a reason for hiding this comment

shawnborton commented Oct 9, 2023

kosmydel commented Oct 9, 2023 • edited Loading

shawnborton commented Oct 9, 2023

kosmydel commented Oct 9, 2023

kosmydel commented Oct 12, 2023

tgolen left a comment

Choose a reason for hiding this comment

tgolen commented Oct 13, 2023

situchan commented Oct 13, 2023

kosmydel commented Oct 16, 2023 • edited Loading

pecanoro commented Oct 19, 2023

situchan commented Oct 19, 2023

situchan commented Oct 19, 2023

situchan commented Oct 19, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

kosmydel commented Oct 5, 2023 •

edited

Loading

kosmydel commented Oct 9, 2023 •

edited

Loading

kosmydel commented Oct 16, 2023 •

edited

Loading