Add `DateTimeFormat` polyfill #29113

tienifr · 2023-10-09T18:12:09Z

Details

Add DateTimeFormat polyfills to support backward timezones and display them as modern, canonicalized timezone names.

Fixed Issues

Tests

How to change local timezone

MacOS

Chrome (or Chormium-based browsers) on MacOS Sonoma is failing to retrieve timezone. Reported issue here: https://support.google.com/chrome/thread/231926653/timezone-return-undefined. So if you're using Mac Sonoma, please use Safari for testing; or use other Mac OS versions.

Open Date & Time settings
Turn off Set time zone automatically using your current location
Under Closest city, choose the desired timezone

iOS

MacOS's timezone settings also applies to simulator. For physical device:

Open Settings >> General >> Date & Time
Turn off Set automatically
Under Timezone, choose the desired timezone

Android

Open Settings >> System >> Date & Time
Under Time zone, turn off Set automatically
Under Time zone, choose the desired region/timezone

Test steps

Automatic timezone detection requires app restart/refresh to take effects.

All platforms

Close app
Change local timezone to Kolkata - India
Open app
Go to Settings >> Profile >> Timezone
Turn on Automatically determine your location.
Verify the automatic timezone is Asia/Kolkata
Repeat step 1 to 6 with Hanoi - Vietnam city and verify Asia/Ho_Chi_Minh timezone
May test with other cities-timezones pairs here

More for iOS

Set account A's timezone to Asia/Ho_Chi_Minh on Web
Open app on iOS, already login with A, OR with any account that has chat with A before
Open any existing chat joined by A
Verify that app does not crash

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

timezone-ios-compressed.mov

timezone-ios2-compressed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This reverts commit 9197143.

melvin-bot · 2023-10-12T10:04:28Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-10-12T10:08:26Z

@situchan Chrome (or Chormium-based browsers) on MacOS Sonoma is failing to retrieve timezone. Reported issue here: https://support.google.com/chrome/thread/231926653/timezone-return-undefined. So if you're using Mac Sonoma, please use Safari for testing; or use other Mac OS versions.

src/libs/IntlPolyfill/polyfillDateTimeFormat.ts

situchan · 2023-10-13T03:29:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-ios.mov

Mobile Web - Chrome

desktop.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

web-ios.mov

Android

android.mov

situchan

LGTM

@pecanoro all yours

OSBotify · 2023-10-13T12:09:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:10:58Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pecanoro · 2023-10-14T01:54:41Z

Leaving a comment here for the QA team: we reverted this PR here to avoid a regression with Sonoma.

OSBotify · 2023-10-16T21:11:26Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:47:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:50:42Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:15:27Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2023-10-19T17:14:24Z

@tienifr This PR was reverted. Have you found solution to fix Sonoma issue?

tienifr added 9 commits October 6, 2023 18:00

add DateTimeFormat polyfills

32c88f2

fix: 29060

9197143

set default timezone

c454384

Revert "fix: 29060"

2dd92d3

This reverts commit 9197143.

Merge branch 'main' of https://github.com/tienifr/App

2c7c9a9

Merge branch 'main' of https://github.com/tienifr/App into fix/27927

5459e8e

pretteir

07d4e0a

Merge branch 'main' of https://github.com/tienifr/App into fix/27927

6214207

Merge branch 'main' of https://github.com/tienifr/App into fix/27927

18a0a9c

tienifr marked this pull request as ready for review October 12, 2023 10:04

tienifr requested a review from a team as a code owner October 12, 2023 10:04

melvin-bot bot requested review from situchan and removed request for a team October 12, 2023 10:04

This was referenced Oct 12, 2023

[HOLD for payment 2024-01-18] [$250] Dev: IOS - App crashes when opening a transaction report #27392

Closed

[Hold for #27392] [$500] mWeb-Profile-Asia/Calcutta is displayed as Asia/Kolkata & selected timezone not shown with tick mark #27927

Closed

Merge branch 'main' of https://github.com/tienifr/App into fix/27927

cdcf5af

situchan reviewed Oct 12, 2023

View reviewed changes

src/libs/IntlPolyfill/polyfillDateTimeFormat.ts Outdated Show resolved Hide resolved

situchan approved these changes Oct 13, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro October 13, 2023 03:31

modified comment

a38d264

pecanoro approved these changes Oct 13, 2023

View reviewed changes

pecanoro merged commit d564b77 into Expensify:main Oct 13, 2023
16 checks passed

situchan mentioned this pull request Oct 13, 2023

[CP Staging] [No QA] Revert "Add DateTimeFormat polyfill" #29576

Merged

58 tasks

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

tienifr mentioned this pull request Dec 11, 2023

Add DateTimeFormat polyfills with timezone abbreviations #31074

Merged

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `DateTimeFormat` polyfill #29113

Add `DateTimeFormat` polyfill #29113

tienifr commented Oct 9, 2023 •

edited

Loading

melvin-bot bot commented Oct 12, 2023

tienifr commented Oct 12, 2023 •

edited

Loading

situchan commented Oct 13, 2023

situchan left a comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

pecanoro commented Oct 14, 2023 •

edited

Loading

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

situchan commented Oct 19, 2023

Add DateTimeFormat polyfill #29113

Add DateTimeFormat polyfill #29113

Conversation

tienifr commented Oct 9, 2023 • edited Loading

Details

Fixed Issues

Tests

How to change local timezone

MacOS

iOS

Android

Test steps

All platforms

More for iOS

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

tienifr commented Oct 12, 2023 • edited Loading

situchan commented Oct 13, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

pecanoro commented Oct 14, 2023 • edited Loading

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

situchan commented Oct 19, 2023

Add `DateTimeFormat` polyfill #29113

Add `DateTimeFormat` polyfill #29113

tienifr commented Oct 9, 2023 •

edited

Loading

tienifr commented Oct 12, 2023 •

edited

Loading

pecanoro commented Oct 14, 2023 •

edited

Loading