feat: enable next button #29125

BhuvaneshPatil · 2023-10-09T20:36:14Z

Details

Currently we don't have next button for distance request enabled by default, this PR will enable the distance request and display the error in case there is an error.

Fixed Issues

$ #27045
PROPOSAL: #27045 (comment)

Tests

Test 1

Empty waypoints
Click next
Verify an error appears asking you to enter waypoints

Test 2

Start waypoint A
empty waypoint
Finish waypoint B
Click next
Verify that you are navigated without errors

Test 3

start waypoint A
finish waypoint A
Click next
Verify an error appears about duplicate waypoints

Test 4

start waypoint A
stop waypoint A
finish waypoint B
Click next
Verify that you are navigated without errors

Test 5

start waypoint A
stop waypoint B
stop waypoint B
finish waypoint A
Click next
Verify that you are navigated without error

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-10.at.5.50.36.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-10-11.at.5.08.19.PM.mov

iOS: Native

IOS.Native.mov

iOS: mWeb Safari

IOS.Safari.mov

MacOS: Chrome / Safari

MacOS.Chrome.mov

MacOS: Desktop

Screen.Recording.2023-10-10.at.10.33.31.PM.mov

melvin-bot · 2023-10-09T20:36:20Z

@shawnborton @allroundexperts One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BhuvaneshPatil · 2023-10-09T20:36:31Z

Will upload videos soon

src/components/DistanceRequest/index.js

shawnborton · 2023-10-10T14:53:25Z

Looking good, thanks!

BhuvaneshPatil · 2023-10-10T17:05:15Z

^^ @allroundexperts

allroundexperts · 2023-10-11T06:15:58Z

@BhuvaneshPatil Can you please make sure that your checklist is complete? I see the checks failing.

BhuvaneshPatil · 2023-10-11T06:19:14Z

@allroundexperts
For android chrome, I was not able to see the map that's why I haven't uploaded video.
Can you continue the review till then.

BhuvaneshPatil · 2023-10-11T11:41:37Z

All checkbox completed

src/components/DistanceRequest/index.js

allroundexperts · 2023-10-12T05:20:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-12.at.9.58.12.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-12.at.10.12.19.AM.mov

Mobile Web - Safari

Screen.Recording.2023-10-12.at.10.02.29.AM.mov

Desktop

Screen.Recording.2023-10-12.at.10.09.50.AM.mov

iOS

Screen.Recording.2023-10-12.at.10.07.17.AM.mov

Android

Screen.Recording.2023-10-12.at.10.14.14.AM.mov

allroundexperts

Looks good!

shawnborton · 2023-10-12T13:01:28Z

Yup, lgtm too

src/components/DistanceRequest/index.js

src/languages/en.ts

src/components/DistanceRequest/index.js

tgolen

Looks good, just this one last thing.

src/components/DistanceRequest/index.js

BhuvaneshPatil · 2023-10-12T19:31:39Z

thanks @tgolen ❤️

BhuvaneshPatil · 2023-10-12T19:55:30Z

Why this check is so slow?

BhuvaneshPatil · 2023-10-12T20:18:45Z

@tgolen When can we merge this PR?

tgolen · 2023-10-12T20:51:45Z

I was just waiting for the tests to pass. Not sure why it was taking the lint test so long.

OSBotify · 2023-10-12T20:57:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:11:52Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:12:32Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:48:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:51:48Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:16:33Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

allroundexperts · 2024-01-07T20:11:37Z

src/components/DistanceRequest/index.js

@@ -151,6 +182,15 @@ function DistanceRequest({transactionID, report, transaction, route, isEditingRe
        [transactionID, waypoints, waypointsList],
    );

+    const submitWaypoints = useCallback(() => {
+        // If there is any error or loading state, don't let user go to next page.
+        if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {


This condition should have taken into account if the user was offline or not. This later caused #32397

alitoshmatov · 2024-04-01T19:16:39Z

src/components/DistanceRequest/index.js

@@ -130,6 +145,22 @@ function DistanceRequest({transactionID, report, transaction, route, isEditingRe
        Navigation.navigate(isEditingRequest ? ROUTES.MONEY_REQUEST_EDIT_WAYPOINT.getRoute(report.reportID, transactionID, index) : ROUTES.MONEY_REQUEST_WAYPOINT.getRoute('request', index));
    };

+    const getError = () => {


Duplicate waypoint is not showing error when rearranged, ref: #35910

feat: enable next button

d007df4

BhuvaneshPatil requested a review from a team as a code owner October 9, 2023 20:36

melvin-bot bot requested review from allroundexperts and shawnborton and removed request for a team October 9, 2023 20:36

BhuvaneshPatil commented Oct 9, 2023

View reviewed changes

src/components/DistanceRequest/index.js Show resolved Hide resolved

BhuvaneshPatil commented Oct 9, 2023

View reviewed changes

src/components/DistanceRequest/index.js Show resolved Hide resolved

BhuvaneshPatil commented Oct 9, 2023

View reviewed changes

src/components/DistanceRequest/index.js Show resolved Hide resolved

situchan mentioned this pull request Oct 10, 2023

[Issue Payment] [$500] Update error flow for prevent splitting bill with workspace and additional participants #27508

Closed

change spanish message

5f1d05d

allroundexperts reviewed Oct 12, 2023

View reviewed changes

src/components/DistanceRequest/index.js Outdated Show resolved Hide resolved

allroundexperts approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from tgolen October 12, 2023 05:21

tgolen requested changes Oct 12, 2023

View reviewed changes

BhuvaneshPatil added 3 commits October 12, 2023 21:24

neat: change state name and capitalize comments

7d831a9

neat: change error message for duplicate error

df831b0

neat: refactor to function, refactor if condition

82da624

BhuvaneshPatil requested review from tgolen and allroundexperts October 12, 2023 19:01

tgolen requested changes Oct 12, 2023

View reviewed changes

src/components/DistanceRequest/index.js Outdated Show resolved Hide resolved

neat: rename method from onPress to submitWaypoints

835ecf7

BhuvaneshPatil requested a review from tgolen October 12, 2023 19:15

tgolen approved these changes Oct 12, 2023

View reviewed changes

tgolen merged commit a2f483d into Expensify:main Oct 12, 2023

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot bot mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-23] [$500] [distance] Don't disable the Next button. Show error message #27045

Closed

tgolen mentioned this pull request Oct 17, 2023

[$500] Distance - Inconsistency in error message when more than two same adddress is added #29803

Closed

6 tasks

allroundexperts reviewed Jan 7, 2024

View reviewed changes

allroundexperts mentioned this pull request Jan 7, 2024

[HOLD for payment 2024-01-03] [$500] Distance - Save button is unresponsive when adding, saving, then removing new point offline #32397

Closed

6 tasks

alitoshmatov reviewed Apr 1, 2024

View reviewed changes

alitoshmatov mentioned this pull request Apr 1, 2024

[$500] Distance - Duplicate waypoint error message is not dimissed after closing distance editor #34999

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable next button #29125

feat: enable next button #29125

BhuvaneshPatil commented Oct 9, 2023 •

edited

Loading

melvin-bot bot commented Oct 9, 2023

BhuvaneshPatil commented Oct 9, 2023

shawnborton commented Oct 10, 2023

BhuvaneshPatil commented Oct 10, 2023

allroundexperts commented Oct 11, 2023

BhuvaneshPatil commented Oct 11, 2023

BhuvaneshPatil commented Oct 11, 2023

allroundexperts commented Oct 12, 2023

allroundexperts left a comment

shawnborton commented Oct 12, 2023

tgolen left a comment

BhuvaneshPatil commented Oct 12, 2023

BhuvaneshPatil commented Oct 12, 2023

BhuvaneshPatil commented Oct 12, 2023

tgolen commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

allroundexperts Jan 7, 2024

alitoshmatov Apr 1, 2024

feat: enable next button #29125

feat: enable next button #29125

Conversation

BhuvaneshPatil commented Oct 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Test 1

Test 2

Test 3

Test 4

Test 5

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2023

BhuvaneshPatil commented Oct 9, 2023

shawnborton commented Oct 10, 2023

BhuvaneshPatil commented Oct 10, 2023

allroundexperts commented Oct 11, 2023

BhuvaneshPatil commented Oct 11, 2023

BhuvaneshPatil commented Oct 11, 2023

allroundexperts commented Oct 12, 2023

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

shawnborton commented Oct 12, 2023

tgolen left a comment

Choose a reason for hiding this comment

BhuvaneshPatil commented Oct 12, 2023

BhuvaneshPatil commented Oct 12, 2023

BhuvaneshPatil commented Oct 12, 2023

tgolen commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

allroundexperts Jan 7, 2024

Choose a reason for hiding this comment

alitoshmatov Apr 1, 2024

Choose a reason for hiding this comment

BhuvaneshPatil commented Oct 9, 2023 •

edited

Loading