Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add jsDoc to billable #29327

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Feat: add jsDoc to billable #29327

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79498de
add jsDoc
waterim Oct 11, 2023
881dd0d
add defaultPrps
waterim Oct 11, 2023
bcd7fd3
adjustments
waterim Oct 12, 2023
e24c8ed
default props
waterim Oct 12, 2023
15ff9d7
adjustment
waterim Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/MoneyRequestConfirmationList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ const propTypes = {
/** IOU Tag */
iouTag: PropTypes.string,

/** IOU isBillable */
iouIsBillable: PropTypes.bool,

/** IOU Callback toggle billable state */
waterim marked this conversation as resolved.
Show resolved Hide resolved
onToggleBillable: PropTypes.func,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these are optional props, defaultProps is also required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be as Category and Tags

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't get your comment. can you explain why default values are not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, thought about different thing, added defaultProps


/** Selected participants from MoneyRequestModal with login / accountID */
selectedParticipants: PropTypes.arrayOf(optionPropTypes).isRequired,

Expand Down
Loading