[Wave 8- ECard Transactions] Update ReportPreview styling (ReportActionItemImages)

[grgia]

Details

Updates the ReportActionItemImages styling to match our figma here - https://www.figma.com/file/dmhA9UknFuGCj0BzJaMhSb/Scan-Receipts-Doc?type=design&node-id=2938%3A28442&mode=design&t=KRIUWShhAnxYa4p0-1
Slack discussion here - https://expensify.slack.com/archives/C027726KHT4/p1697064176216799

Screen.Recording.2023-10-12.at.4.02.41.PM.mov

Fixed Issues

$ #29291

Tests

• Verify that no errors appear in the JS console
• Tested in Storybook via npm run storybook and writing test cases

Offline tests

QA Steps

• Verify that no errors appear in the JS console
• Go to a Chat, create a few reports with 1, 2, 3, and 4+ requests with receipts. Verify that the Report Preview (parent chat), IOU Preview (report chat) and transaction thread previews are created without error.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	8147255
Status:	✅  Deploy successful!
Preview URL:	https://ff5d47e4.helpdot.pages.dev
Branch Preview URL:	https://georgia-cardtransactions-rep-xaah.helpdot.pages.dev

View logs

[grgia]

cc @shawnborton

[melvin-bot]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[allroundexperts]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-13.at.3.30.33.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-13.at.3.32.39.AM.mov

Mobile Web - Safari

Screen.Recording.2023-10-13.at.3.31.53.AM.mov

Desktop

Screen.Recording.2023-10-13.at.8.44.29.AM.mov

iOS

Screen.Recording.2023-10-13.at.3.31.17.AM.mov

Android

Screen.Recording.2023-10-13.at.3.33.16.AM.mov

[allroundexperts]

@grgia iOS seems broken.

[allroundexperts]

Same for android:

[grgia]

Well that's certainly funky @allroundexperts. I'll update tomorrow morning

[grgia]

jk @allroundexperts fixed now. I had an incorrect import

[allroundexperts]

Looks good!

[melvin-bot]

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Beamanator]

Looks good to me! @grgia do we want @shawnborton or someone else on the design team to review before we merge?

[grgia]

@Beamanator I had the design reviewed in the linked slack convo! Going to merge this one

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1268.964 ms → 1347.746 ms (+78.782 ms, +6.2%) 🔴
App start runJsBundle	877.367 ms → 934.418 ms (+57.051 ms, +6.5%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1268.964 ms Stdev: 43.018 ms (3.4%) Runs: 1164.1358130001463 1180.8774069999345 1189.3793830000795 1191.3221410000697 1198.3771179998294 1200.7734249997884 1213.0449970001355 1215.2455640002154 1215.4370439997874 1216.2139519997872 1216.8414790001698 1222.4089440000243 1228.989312000107 1229.0265970001929 1229.6570740002207 1236.499489999842 1237.0239630001597 1237.4169310000725 1238.5440150001086 1240.150568000041 1242.5939850001596 1247.564708000049 1247.9055240000598 1248.2303160000592 1249.1592159997672 1250.7699710000306 1252.497086000163 1252.6807079999708 1253.2114670001902 1253.2913179998286 1253.3062119996175 1253.5519909998402 1254.4135619997978 1254.4613859998062 1254.8337730001658 1257.860419999808 1257.8887109998614 1258.1905040000565 1259.998815999832 1260.7758149998263 1261.04079800006 1262.6614439999685 1263.532347000204 1265.0322300000116 1266.9416220001876 1268.5327220000327 1268.6593380002305 1271.7367369998246 1272.0969299999997 1273.8794470001012 1275.110417000018 1278.407842000015 1279.8651640000753 1280.0751769999042 1284.6272619999945 1287.067226999905 1288.1012860001065 1289.4689110000618 1290.527623000089 1290.5601570000872 1290.6248120004311 1292.0042260000482 1293.1544679999352 1293.382166000083 1298.7736010001972 1300.1739909998141 1303.2990310001187 1304.2575009996071 1304.4644269999117 1307.9399279998615 1309.2854869998991 1313.8492640000768 1323.9730850001797 1324.361940999981 1324.3715619998984 1326.3476900001988 1328.568777000066 1330.3933640001342 1336.1031390000135 1338.9145760000683 1356.0950429998338 1366.2442319998518 1369.8104889998212 1374.0810929997824 Current Mean: 1347.746 ms Stdev: 61.282 ms (4.5%) Runs: 1199.6834500003606 1209.699866999872 1219.9051729999483 1229.2980509996414 1235.3507570000365 1237.3950180001557 1240.989849999547 1245.0930070001632 1250.3441770002246 1269.456048999913 1282.140030999668 1282.8933180002496 1283.5465879999101 1285.508824000135 1285.6876140004024 1286.4159340001643 1287.6323680002242 1287.9681930001825 1290.227919000201 1290.8264619996771 1294.6092539997771 1296.3651329996064 1298.9123780000955 1307.884174999781 1308.229735000059 1310.0655330000445 1311.8340560002252 1317.6387029998004 1317.997949999757 1320.9920889995992 1321.5996679998934 1324.6920729996637 1329.1902879998088 1329.8316580001265 1331.3438649997115 1332.9263610001653 1336.2111409995705 1338.0776819996536 1338.8181419996545 1338.8436650000513 1339.1854720003903 1342.9624340003356 1347.9253620002419 1355.6060840003192 1358.5128319999203 1358.9744490003213 1363.490491000004 1363.828111000359 1364.0908669997007 1364.243812000379 1364.5126879997551 1365.8670199997723 1366.9110409999266 1366.97646600008 1368.7014889996499 1368.7247999999672 1370.3813899997622 1371.95505400002 1373.247291999869 1373.706480000168 1373.755537999794 1378.0812050001696 1379.9248219998553 1381.7510789996013 1382.4015859998763 1388.3994589997455 1389.7479910003021 1390.0563909998164 1390.1421910002828 1391.5062579996884 1393.4538179999217 1394.9211929999292 1395.307791000232 1396.602469000034 1398.622460000217 1399.3633449999616 1399.6402340000495 1401.0664959996939 1412.105353999883 1412.7013980001211 1415.2882890002802 1420.386924999766 1421.7247010003775 1431.1449060002342 1431.4704860001802 1439.7762160003185 1442.5314779998735 1444.4822730002925 1446.8581839995459 1458.5720819998533 1467.0178760001436 1467.8605540003628
App start runJsBundle	Baseline Mean: 877.367 ms Stdev: 50.014 ms (5.7%) Runs: 764 770 770 790 792 792 807 809 811 816 817 821 822 827 829 831 838 839 840 843 844 846 847 853 854 855 855 856 857 858 858 861 863 864 864 866 866 866 867 868 869 870 870 872 876 877 877 878 880 880 880 882 882 883 884 885 885 885 885 890 892 896 897 903 909 910 910 912 912 914 915 917 920 921 922 924 930 932 933 935 936 942 947 953 954 971 976 994 998 1002 Current Mean: 934.418 ms Stdev: 43.816 ms (4.7%) Runs: 823 825 837 853 855 871 875 878 879 879 879 882 885 887 890 891 893 893 894 896 896 901 904 905 910 910 913 914 916 918 923 923 924 924 924 926 926 927 934 934 934 936 936 936 938 940 940 941 942 943 943 945 945 945 947 949 950 951 951 951 956 957 957 959 960 960 963 964 964 964 964 965 966 966 967 971 971 971 971 972 973 980 989 995 996 1000 1002 1013 1034 1041 1041

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	623.507 ms → 646.550 ms (+23.043 ms, +3.7%)
App start nativeLaunch	21.511 ms → 24.189 ms (+2.678 ms, +12.4%)
App start regularAppStart	0.015 ms → 0.016 ms (+0.001 ms, +9.3%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 623.507 ms Stdev: 16.734 ms (2.7%) Runs: 591.0172939999029 591.2441819999367 591.5523690003902 599.5248209992424 605.8862310005352 606.5934649994597 607.0076909996569 607.1642249999568 607.3260089997202 607.9093829998747 607.9277760004625 608.0210779998451 608.6065670000389 608.9190269997343 609.3707679994404 609.8515630001202 609.8983970005065 610.343465000391 610.4204509994015 610.5216479999945 610.5511480001733 611.7666420005262 614.534668000415 615.2912600003183 615.3271489990875 615.3743489999324 615.5063889995217 615.5379639994353 615.6127929994836 615.8242600001395 616.0170080000535 616.0554609997198 616.1988530000672 616.2903649993241 616.4702559998259 616.562336999923 617.6885989997536 618.425741000101 618.8219409994781 619.3106690002605 619.3863530000672 619.9390869997442 620.5050049992278 620.9245609994978 621.5889489995316 623.5494790002704 623.5829269997776 623.9639489995316 624.2539470000193 624.4565019998699 624.5479739997536 624.7965089995414 625.4292409997433 626.1092940000817 626.2923990003765 626.9333910001442 627.1560880001634 627.2614749995992 627.9628899991512 628.6233320003375 628.953492000699 629.6332189999521 631.421590000391 631.966878999956 632.3600260000676 633.1099450001493 633.1938880002126 633.2081300001591 635.3696699999273 635.5921629993245 640.9247240005061 641.0806889999658 641.5277509996668 642.4995929999277 643.4570730002597 643.6453459998593 644.5171720003709 645.2413330003619 654.8744299998507 659.646525000222 664.5963949998841 665.9615889992565 671.8934329999611 676.3829340003431 Current Mean: 646.550 ms Stdev: 34.047 ms (5.3%) Runs: 590.5499269999564 597.37084900029 598.2384850000963 601.5482589993626 604.8174649998546 605.6914060004056 607.5170499999076 607.8483079997823 609.1591389998794 609.3207610007375 609.9136149995029 614.2087819995359 614.3562009995803 614.7437340002507 615.5398760000244 615.8436690000817 615.8484699996188 616.4085290003568 616.900675999932 617.0544440001249 617.8674320001155 619.7369799995795 620.7240810003132 621.1399739999324 621.4830320002511 623.2049970002845 623.5926919998601 624.1308189993724 624.6943359998986 624.8478600000963 625.1446130005643 625.3113200003281 626.8249110002071 627.1890870006755 628.7975670006126 628.8360599996522 630.2639160007238 631.2891030004248 631.5080569991842 632.9271649997681 634.8460289994255 635.130941000767 635.2170409997925 637.5192870004103 639.4414470000193 639.85437099915 642.3802089998499 643.4278979999945 645.8388679996133 647.9805910000578 648.0426839999855 648.1532800002024 648.3421630002558 648.3988439999521 650.8138840002939 651.0179850002751 651.2491049999371 651.3933110004291 652.5251469993964 653.2033700002357 655.2639159997925 655.713012999855 656.1913250004873 657.0909839998931 659.0476890001446 661.019612999633 664.5297450004146 665.802775000222 666.1731369998306 667.3048499999568 668.558796999976 672.4673669999465 673.5732019999996 682.1801360007375 683.0019539995119 689.5311279995367 690.9385170005262 691.4808759996668 696.7226559994742 697.9673669999465 700.1947829993442 700.4711509998888 701.8875730000436 702.7349040005356 705.6221110001206 707.8696290003136 714.8798420000821 723.0995279997587 733.2723400006071 747.7234710007906
App start nativeLaunch	Baseline Mean: 21.511 ms Stdev: 2.868 ms (13.3%) Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 24 24 24 24 24 24 24 25 26 27 27 27 27 28 28 30 30 30 Current Mean: 24.189 ms Stdev: 3.392 ms (14.0%) Runs: 19 19 19 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 26 26 27 27 27 27 27 27 28 28 28 28 28 28 29 29 29 30 31 31 32 32 32 32 33
App start regularAppStart	Baseline Mean: 0.015 ms Stdev: 0.001 ms (7.2%) Runs: 0.012858000118285418 0.012980000115931034 0.013061999808996916 0.013143000192940235 0.01318400027230382 0.013265000190585852 0.013386999722570181 0.013509000185877085 0.013549999799579382 0.01355000026524067 0.01358999963849783 0.013590000104159117 0.013671000022441149 0.013672000262886286 0.013712999410927296 0.013753000181168318 0.013794000260531902 0.01383400009945035 0.013875000178813934 0.013875999953597784 0.013915999792516232 0.013956000097095966 0.013996999710798264 0.014120000414550304 0.014159999787807465 0.014159999787807465 0.014160000253468752 0.014161000028252602 0.014241000171750784 0.014241000171750784 0.014241000171750784 0.014282000251114368 0.014283000025898218 0.014362999703735113 0.01436399994418025 0.014403999783098698 0.014404000248759985 0.014404000248759985 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014525999780744314 0.014527000021189451 0.014566999860107899 0.014607000164687634 0.01464799977838993 0.014688999857753515 0.014851999934762716 0.0148930000141263 0.014934000093489885 0.014973999932408333 0.015015000011771917 0.015054999850690365 0.015055999625474215 0.015056000091135502 0.01509599993005395 0.015096000395715237 0.015096000395715237 0.015176999848335981 0.015176999848335981 0.015217999927699566 0.015339999925345182 0.015339999925345182 0.015340999700129032 0.01534100016579032 0.015381000004708767 0.015503000002354383 0.015584000386297703 0.015625 0.015664999838918447 0.015665000304579735 0.015666000079363585 0.01582799991592765 0.015868999995291233 0.015868999995291233 0.015910000074654818 0.01599099999293685 0.016112999990582466 0.01615400006994605 0.016194999683648348 0.01623600022867322 0.016276000067591667 0.01631700014695525 0.0166830001398921 0.016724000219255686 0.01696799974888563 0.017009000293910503 0.017089999746531248 0.017374999821186066 0.017456000205129385 Current Mean: 0.016 ms Stdev: 0.001 ms (7.8%) Runs: 0.013306000269949436 0.013630999252200127 0.013875000178813934 0.013956999406218529 0.014038000255823135 0.014240999706089497 0.014322999864816666 0.014403999783098698 0.014485999941825867 0.014566999860107899 0.014688999392092228 0.014728999696671963 0.014850999228656292 0.014932999387383461 0.014933000318706036 0.015056000091135502 0.015096000395715237 0.015096000395715237 0.015096000395715237 0.015135999768972397 0.015137000009417534 0.015258999541401863 0.015298999845981598 0.015300000086426735 0.015300000086426735 0.015421000309288502 0.015502999536693096 0.015502999536693096 0.015583999454975128 0.015625 0.015665999613702297 0.015665999613702297 0.015705999918282032 0.01574699953198433 0.015786999836564064 0.0157880000770092 0.015828999690711498 0.016032000072300434 0.016032000072300434 0.01611399929970503 0.016153999604284763 0.016154000535607338 0.016193999908864498 0.016234999522566795 0.01623500045388937 0.016236000694334507 0.016397999599575996 0.016397999599575996 0.016397999599575996 0.016479999758303165 0.016479999758303165 0.016561000607907772 0.016600999981164932 0.01660200022161007 0.01664199959486723 0.01664199959486723 0.016642000526189804 0.016642000526189804 0.016642000526189804 0.016681999899446964 0.0166830001398921 0.0167239997535944 0.0167239997535944 0.016764000058174133 0.01680499967187643 0.01680499967187643 0.016805000603199005 0.016885999590158463 0.016886000521481037 0.016927000135183334 0.01696799974888563 0.017171000130474567 0.017211999744176865 0.017211999744176865 0.017253000289201736 0.01729300059378147 0.01733400020748377 0.017700000666081905 0.0177819998934865 0.0177819998934865 0.017822000198066235 0.0179449999704957 0.017985000275075436 0.018025999888777733 0.018269999884068966 0.01843199972063303 0.018636000342667103 0.018757999874651432 0.019164999946951866 0.019245999865233898

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[situchan]

I think this regression came from this PR

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅