[No QA] Use deploy blocker title instead of bad markdown in Slack comment #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafecolton
reviewed
May 18, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
10 tasks
|
Why not ping |
|
We could potentially do that ... part of the discussion here was that deploy-blockers should be internal, so that we know they'll be treated with a high degree of urgency. Even if a contributor can quickly see a solution to the deploy blocker, we often won't want to triage, create and upwork job, wait for their proposal, etc... Thoughts? |
|
Seems OK for now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafecolton Will you please review this?
Details
When a new E.cash deploy blocker is created, post the issue title in the
#deployerslack room.Fixed Issues
n/a – slack convo here
Testing plan
DeployBlockerCash#deployerincludes the issue title as a hyperlink back to the issue you created in the previous step.