-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal QA] Skip rendering content for pay action on non-send money flow #30079
Conversation
Deploying with Cloudflare Pages
|
Reviewer Checklist
Screenshots/VideosWebIOU payer: Screen.Recording.2023-10-20.at.7.52.09.PM.movIOU payee: Screen.Recording.2023-10-20.at.7.51.50.PM.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Testing expense request shortly |
@techievivek I am not able to create workspace on your account. Can you please check what's happening?
|
Oops sorry, I am rebuilding the C++ server(aka Auth). I will update you once it's ready, thanks. |
@situchan You should be good now. |
Not able to test workspace chat yet. Asked @techievivek to add bank to test workspace Screen.Recording.2023-10-20.at.9.33.54.PM.mov |
@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
// For the `pay` IOU action on non-send money flow we don't want to show anything | ||
// as the preview action is already shown by the create IOU action above | ||
if (props.action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && originalMessage && originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !isSendingMoney) { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing here in Slack, but I thought we agreed that this would not eb rendered if the isWaitingOnBankAccount
property is true (so we only show the enable wallet flow). side note, it still shows paid $10
in the LHN as the pay report action is here so we would need to add the same logic to LHN.
So this should still be rendered when isWaitingOnBankAccount
is false hence when we actually sent the payment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing here in Slack, but I thought we agreed that this would not eb rendered if the isWaitingOnBankAccount property is true
Oops, I missed the fact that we show a system message for pay IOU action, I thought we haven't still not figure out the use case for pay IOU action so I have hide that completely. I will get this fix ASAP. Thanks for pointing it out.
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.89-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.89-6 🚀
|
Details
For money request flow we create two IOU actions on the iou report. One is of type
create
and the other of typepay
. So let's see how these actions are rendered on the frontend if the payee is on silver wallet(aka we add theisWaitingOnBankAccount
status to the iou report).ReportActionItem
component as a result else block gets executed for this and we render another system message asking user to add theirbank account
as that is the default message if the report hasisWaitingOnBankAccount
property set.So we now have two system message so I have updated the code to prevent rendering any content if the IOU action type is pay and it is not a send money flow.
Fixed Issues
$ #30075
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test steps.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop