Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create currency modal with react-native-permissions and geolocation #3015

Closed
wants to merge 52 commits into from

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented May 19, 2021

cc @Julesssss @trjExpensify @iwiznia @rameshhpathak

Details

This PR is a copy of #2194 with some added changes to fix the broken build on iOS. I was unable to push to that branch since it's not in this repo, so creating a separate PR for it here. Since @rameshpathak is unable to test on iOS and this has become a priority, this PR has the changes required to make the build work again.

The main issue was that the Build Phases for the xcode project were out of order and there was an additional build phase, causing the multiple commands produce error.

Main Currency Modal
image image

Fixed Issues

Fixes #1970

Tests

  1. Go to /iou/split on web. Verify that the currency is based on your location.
  2. Click on the currency, a list with all currencies should show.
  3. Search for a currency, or scroll down to your desired currency
  4. Click on the currency to select and click on the Confirm button the confirm selection
  5. Verify that the selected currency shows now in the amount page
  6. Refresh the page, and verify that the same currency shows in the amount page

QA Steps

Same as tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screenshot 2021-04-12 at 12 49 55

Screenshot 2021-04-12 at 12 50 24

@Jag96 Jag96 requested a review from Julesssss May 19, 2021 19:00
@Jag96 Jag96 self-assigned this May 19, 2021
@Jag96 Jag96 requested a review from a team as a code owner May 19, 2021 19:00
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team May 19, 2021 19:00
@Jag96 Jag96 removed the request for review from pecanoro May 19, 2021 19:00
@Jag96
Copy link
Contributor Author

Jag96 commented May 19, 2021

Commits have been added to #2194, closing

@Jag96 Jag96 closed this May 19, 2021
@Julesssss
Copy link
Contributor

Nice one @Jag96 🙏

@roryabraham roryabraham deleted the ramesh-currency-modal branch June 8, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pay on Thursday 27th May] [IOU] Create Currency Modal, with geolocation and Location permissions
3 participants