Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical centering button text without padding #30192

Merged
merged 4 commits into from
Oct 25, 2023
Merged

fix: vertical centering button text without padding #30192

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08b6850
fix: vertical centering button text without padding
sangar-1028 Oct 23, 2023
9146146
Merge branch 'main' into fix/issue-26985
sangar-1028 Oct 24, 2023
afde388
Merge branch 'main' into fix/issue-26985
sangar-1028 Oct 25, 2023
3271eb0
fix: remove vertical padding from buttonCTA
sangar-1028 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/styles/styles.ts
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove padding from buttonCTA rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I missed that. Removed the vertical padding from buttonCTA

Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,9 @@ const styles = (theme: ThemeDefault) =>
borderRadius: variables.buttonBorderRadius,
minHeight: variables.componentSizeLarge,
justifyContent: 'center',
alignItems: 'center',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this change caused this issue

...spacing.ph3,
...spacing.pv0,
},

buttonContainer: {
Expand All @@ -507,28 +509,22 @@ const styles = (theme: ThemeDefault) =>
buttonSmall: {
borderRadius: variables.buttonBorderRadius,
minHeight: variables.componentSizeSmall,
paddingTop: 4,
paddingHorizontal: 14,
paddingBottom: 4,
backgroundColor: theme.buttonDefaultBG,
},

buttonMedium: {
borderRadius: variables.buttonBorderRadius,
minHeight: variables.componentSizeNormal,
paddingTop: 12,
paddingRight: 16,
paddingBottom: 12,
paddingLeft: 16,
backgroundColor: theme.buttonDefaultBG,
},

buttonLarge: {
borderRadius: variables.buttonBorderRadius,
minHeight: variables.componentSizeLarge,
paddingTop: 8,
paddingRight: 10,
paddingBottom: 8,
paddingLeft: 10,
backgroundColor: theme.buttonDefaultBG,
},
Expand Down Expand Up @@ -609,7 +605,6 @@ const styles = (theme: ThemeDefault) =>
},

buttonCTA: {
paddingVertical: 6,
...spacing.mh4,
},

Expand Down