description/comment to string #30526

Jenemark · 2023-10-27T16:20:10Z

Details

Made the description utils cast to string everytime it's used, done to avoid number issues when updating the description field.

Fixed Issues

$ #29369
PROPOSAL: #29369 (comment)

Tests

Tested the steps used to reproduce the bug on the issues.
Go to https://staging.new.expensify.com/ in Chrome or Android App
Click the Green '+' Icon in the LHN
Choose "Request Money"
Enter an Amount
Tap Next
Choose a Recipient
Tap "Request"
Tap on the IOU transaction to open IOU detail page
Enter a description with numbers only (ex 444) and save it
Tap the amount and change it
Tap the Description again
Checked log value to ensure they value is actually casted to a string
Console.log and terminal checks in general.
Tested multiple different values to ensure field can not crash the app after changes to the request money. As described in the App

Do above test with different values and chars.

Verify that no errors appear in the JS console

Offline tests

Go to https://staging.new.expensify.com/ in Chrome or Android App
Go to preferences and force offline or turn off your connection
Click the Green '+' Icon in the LHN
Choose "Request Money"
Enter an Amount
Tap Next
Choose a Recipient
Tap "Request"
Tap on the IOU transaction to open IOU detail page
Enter a description with numbers only (ex 444) and save it
Tap the amount and change it
Tap the Description again

QA Steps

Go to https://staging.new.expensify.com/ in Chrome or Android App
Click the Green '+' Icon in the LHN
Choose "Request Money"
Enter an Amount
Tap Next
Choose a Recipient
Tap "Request"
Tap on the IOU transaction to open IOU detail page
Enter a description with numbers only (ex 444) and save it
Tap the amount and change it
Tap the Description again
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Skaermoptagelse.2023-10-27.kl.18.57.48.mov

Android: mWeb Chrome

Skaermoptagelse.2023-10-28.kl.10.04.01.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-27.at.17.53.34.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-27.at.16.39.07.mov

MacOS: Chrome / Safari

Skaermoptagelse.2023-10-27.kl.16.29.40.mov

MacOS: Desktop

Skaermoptagelse.2023-10-27.kl.17.39.01.mov

melvin-bot · 2023-10-27T16:20:16Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-10-27T16:20:25Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Jenemark · 2023-10-27T16:22:24Z

I have read the CLA Document and I hereby sign the CLA

burczu · 2023-10-30T12:10:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-30.at.14.28.20.mov

Android: mWeb Chrome

Screen.Recording.2023-10-30.at.14.58.27.mov

iOS: Native

Screen.Recording.2023-10-30.at.14.25.41.mov

iOS: mWeb Safari

Screen.Recording.2023-10-30.at.14.26.42.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-30.at.14.19.23.mov

MacOS: Desktop

Screen.Recording.2023-10-30.at.14.22.37.mov

burczu · 2023-10-30T13:40:44Z

@Jenemark I can't test on Android Chrome - can't save description. I guess it's unrelated to your PR but could you sync with the latest main? Maybe it's fixed there already and I'll test again.

Jenemark · 2023-10-30T13:43:05Z

@burczu I had this issue aswell, it seemed to be a version issue on Android Chrome.
I tested it on Chrome 103.0.5060.71, Android 13

i'll sync with main

burczu

@Jenemark Thank you. You was right - it's working on newer version of Chrome.

LGTM

puneetlath

One small comment (about the comment).

src/libs/TransactionUtils.ts

puneetlath · 2023-10-30T16:41:04Z

@Jenemark commits need to be signed.

Here's some advice on how to sign existing commits: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits/1123928#1123928

… from the backend

Jenemark · 2023-10-30T18:14:50Z

@puneetlath
@burczu
I am really sorry about the mess here. I updated the PR back to original state with a verified comment.

Had to undo the first commits since they were mistakenly made from my work email. Everything should be OK now.
Again I'm sorry about the issues this has caused...

puneetlath · 2023-10-30T18:19:49Z

No problem. Sorry one other thing for the PR checklist. It looks like the test doesn't like that you used [√] instead of [x]

Jenemark · 2023-10-30T18:23:57Z

Should be fine now

puneetlath · 2023-10-30T18:25:49Z

Thanks!

OSBotify · 2023-10-30T18:30:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:00:16Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:52:16Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:15:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:40:23Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:10:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Jenemark requested a review from a team as a code owner October 27, 2023 16:20

melvin-bot bot requested review from burczu and removed request for a team October 27, 2023 16:20

burczu approved these changes Oct 30, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath October 30, 2023 14:00

puneetlath requested changes Oct 30, 2023

View reviewed changes

src/libs/TransactionUtils.ts Outdated Show resolved Hide resolved

puneetlath previously approved these changes Oct 30, 2023

View reviewed changes

Jenemark dismissed puneetlath’s stale review via f56c37d October 30, 2023 18:01

Jenemark force-pushed the fix/cast-description-to-string branch from 449578f to f56c37d Compare October 30, 2023 18:01

Jenemark closed this Oct 30, 2023

Jenemark force-pushed the fix/cast-description-to-string branch from 7b0e039 to b321b0a Compare October 30, 2023 18:11

Updated value to tostring to ensure proper casting from number values…

1ea6e6d

… from the backend

Jenemark reopened this Oct 30, 2023

puneetlath approved these changes Oct 30, 2023

View reviewed changes

puneetlath merged commit 592317f into Expensify:main Oct 30, 2023
14 of 15 checks passed

wlegolas mentioned this pull request Oct 31, 2023

[$500] IOU - Crash when editing the description of an IOU that was initially created with a description #28464

Closed

6 tasks

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

melvin-bot bot mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount #29369

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

description/comment to string #30526

description/comment to string #30526

Jenemark commented Oct 27, 2023 •

edited

Loading

melvin-bot bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023 •

edited

Loading

Jenemark commented Oct 27, 2023

burczu commented Oct 30, 2023 •

edited

Loading

burczu commented Oct 30, 2023

Jenemark commented Oct 30, 2023 •

edited

Loading

burczu left a comment

puneetlath left a comment

puneetlath commented Oct 30, 2023

Jenemark commented Oct 30, 2023

puneetlath commented Oct 30, 2023 •

edited

Loading

Jenemark commented Oct 30, 2023

puneetlath commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

description/comment to string #30526

description/comment to string #30526

Conversation

Jenemark commented Oct 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023 • edited Loading

Jenemark commented Oct 27, 2023

burczu commented Oct 30, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu commented Oct 30, 2023

Jenemark commented Oct 30, 2023 • edited Loading

burczu left a comment

Choose a reason for hiding this comment

puneetlath left a comment

Choose a reason for hiding this comment

puneetlath commented Oct 30, 2023

Jenemark commented Oct 30, 2023

puneetlath commented Oct 30, 2023 • edited Loading

Jenemark commented Oct 30, 2023

puneetlath commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

Jenemark commented Oct 27, 2023 •

edited

Loading

github-actions bot commented Oct 27, 2023 •

edited

Loading

burczu commented Oct 30, 2023 •

edited

Loading

Jenemark commented Oct 30, 2023 •

edited

Loading

puneetlath commented Oct 30, 2023 •

edited

Loading