Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] input of '[' and other special characters fixed #30559

Merged
merged 10 commits into from
Oct 30, 2023
Merged

[CP Staging] input of '[' and other special characters fixed #30559

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7bbc841
input of '[' and other special characters fixed
HardikChoudhary24 Oct 29, 2023
c145333
lint error fixed
HardikChoudhary24 Oct 29, 2023
c4cc971
suggested changes applied
HardikChoudhary24 Oct 29, 2023
fbc466b
Merge remote-tracking branch 'upstream/main' into fix/input-error
HardikChoudhary24 Oct 30, 2023
7054c51
test for convertToLTRForComposer added
HardikChoudhary24 Oct 30, 2023
a2c2025
test case added
HardikChoudhary24 Oct 30, 2023
c449904
lint fixed
HardikChoudhary24 Oct 30, 2023
9bd0b5f
lint fixed
HardikChoudhary24 Oct 30, 2023
f6eede0
OS check removed
HardikChoudhary24 Oct 30, 2023
d28b633
lint fixed
HardikChoudhary24 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/libs/convertToLTRForComposer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ function hasRTLCharacters(text: string): boolean {

// Converts a given text to ensure it starts with the LTR (Left-to-Right) marker.
const convertToLTRForComposer: ConvertToLTRForComposer = (text) => {
// Ensure that the text starts with RTL characters if not we return the same text to avoid concatination with special character at the start which leads to unexpected behaviour for Emoji/Mention suggestions.
// Ensure that the text starts with RTL characters if not we return the same text to avoid concatination with special
// character at the start which leads to unexpected behaviour for Emoji/Mention suggestions.
if (!hasRTLCharacters(text)) {
// If text is empty string return empty string to avoid an empty draft due to special character.
if (text === '' || CONST.UNICODE.LTR.match(text)) {
return '';
}
return text;
return text.replace(CONST.UNICODE.LTR, '');
}

// Check if the text contains only spaces. If it does, we do not concatenate it with CONST.UNICODE.LTR,
Expand Down
Loading