Fix offline error message on E.cash login page #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
nickmurray47 and
johnmlee101
and removed request for
a team
roryabraham
approved these changes
May 21, 2021
There was a problem hiding this comment.
This LGTM, but I was unable to test on Android for what is almost certainly an unrelated issue
nickmurray47
approved these changes
May 21, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds a friendly error message (same one we use in e.com) to the cash login page instead of nothing.
Fixed Issues
Fixes https://expensify.slack.com/archives/C01GTK53T8Q/p1621619471135900
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android