Fix created view is flickered when marking as unread #30815

dukenv0307 · 2023-11-03T06:32:41Z

Details

Fix created view is flickered when marking as unread

Fixed Issues

$ #30218
PROPOSAL: #30218 (comment)

Tests

Create a request money
Go to the IOU report
Mark as unread the money request preview
Verify that the created view only scrolls down

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a request money
Go to the IOU report
Mark as unread the money request preview
Verify that the created view only scrolls down

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-03.at.13.19.43.mov

Android: mWeb Chrome

Screen.Recording.2023-11-03.at.13.11.22.mov

iOS: Native

Screen.Recording.2023-11-03.at.13.17.56.mov

iOS: mWeb Safari

Screen.Recording.2023-11-03.at.13.12.55.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-03.at.13.05.30.mov

MacOS: Desktop

Screen.Recording.2023-11-03.at.13.21.31.mov

melvin-bot · 2023-11-03T06:33:09Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-11-06T06:10:07Z

src/pages/home/report/ReportActionItem.js

        const parentReportAction = ReportActionsUtils.getParentReportAction(props.report);
        if (ReportActionsUtils.isTransactionThread(parentReportAction)) {
-            content = (
+            return (


I'm not sure if I understand correctly the reason for returning everywhere?

In the past, we didn't return to add the margin-bottom to wrap view of created action. Now we bring the margin to SpacingView so we can earlier return here.

allroundexperts · 2023-11-06T06:45:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-06.at.11.28.15.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-06.at.11.18.15.AM.mov

iOS: Native

Screen.Recording.2023-11-06.at.11.25.39.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-06.at.11.27.22.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-06.at.11.14.06.AM.mov

MacOS: Desktop

Screen.Recording.2023-11-06.at.11.24.51.AM.mov

allroundexperts

Works well!

dukenv0307 · 2023-11-09T03:39:49Z

@youssef-lr Please help to review the PR when you have a chance.

youssef-lr · 2023-11-09T15:22:37Z

I'm not able to reproduce the original issue anymore in staging, there's just an extra margin that appears above the total. I'm curious, why is the created view move at all when marking the message as unread?

dukenv0307 · 2023-11-10T03:57:32Z

@youssef-lr Still reproduced in production. Seem like some recent changes make animated view not work and then all created view move at all because SpacerView still has margin-vertical 8px.

youssef-lr · 2023-11-10T19:24:30Z

I just tested this branch, I don't see why we should add any margin when we mark the message unread, it leaves a noticeable space. Can we fix it please?

Screen.Recording.2023-11-10.at.20.23.41.mov

dukenv0307 · 2023-11-13T03:43:35Z

@youssef-lr When we mark as unread for the first message, the divider line will be hidden so we add a margin to keep the space between the created view and the unread line. But the problem here is after updating the newest main, when we mark as unread, the margin vertical of spacer view still is 8px.

dukenv0307 · 2023-11-13T04:43:17Z

@youssef-lr Seem like marginVertical doesn't work, updated to marginTop and marginBottom.

dukenv0307 · 2023-11-15T07:54:39Z

@youssef-lr Please help to test this PR again when you have a chance.

dukenv0307 · 2023-11-20T03:51:26Z

@youssef-lr Any thoughts on my comment above?

youssef-lr · 2023-12-04T15:57:02Z

On it today

youssef-lr · 2023-12-04T21:12:50Z

Hmm now I'm seeing the margin decrease when we mark the message as unread

Screen.Recording.2023-12-04.at.22.11.10.mov

dukenv0307 · 2023-12-04T22:03:42Z

@youssef-lr Yes, it's expected since the unread marker doesn't have space with the user avatar. We only keep the space between the created view and the unread marker.

youssef-lr

LGTM

OSBotify · 2023-12-06T17:44:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-06T22:17:22Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T23:11:32Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T01:08:39Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix created view is flickered when marking as unread

338e31f

dukenv0307 marked this pull request as ready for review November 3, 2023 06:33

dukenv0307 requested a review from a team as a code owner November 3, 2023 06:33

melvin-bot bot requested review from allroundexperts and removed request for a team November 3, 2023 06:33

allroundexperts reviewed Nov 6, 2023

View reviewed changes

allroundexperts approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr November 6, 2023 06:47

erquhart mentioned this pull request Nov 8, 2023

[C+ Checklist Needs Completion] [$500] When clicking on "Mark as unread" the background image scrolls up and down unexpectedly #30218

Closed

6 tasks

merge main

4048407

dukenv0307 added 2 commits November 9, 2023 15:31

fix test

78e95df

fix lint

46d5f7e

fix animated

6a33c61

dukenv0307 added 3 commits November 27, 2023 15:59

Merge branch 'main' into fix/30218

651e503

Merge branch 'main' into fix/30218

b7f9f5e

Merge branch 'main' into fix/30218

636639f

youssef-lr approved these changes Dec 5, 2023

View reviewed changes

youssef-lr merged commit 6f1839e into Expensify:main Dec 6, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 6, 2023

Deploy Checklist: New Expensify 2023-12-06 #32589

Closed

74 tasks

Pujan92 mentioned this pull request Jan 4, 2024

[C+ Checklist Needs Completion] [$500] Android - Task - Background image in task report appears cropped after cancelling the task #33922

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix created view is flickered when marking as unread #30815

Fix created view is flickered when marking as unread #30815

dukenv0307 commented Nov 3, 2023 •

edited

Loading

melvin-bot bot commented Nov 3, 2023

allroundexperts Nov 6, 2023

dukenv0307 Nov 6, 2023

allroundexperts commented Nov 6, 2023

allroundexperts left a comment

dukenv0307 commented Nov 9, 2023

youssef-lr commented Nov 9, 2023

dukenv0307 commented Nov 10, 2023 •

edited

Loading

youssef-lr commented Nov 10, 2023

dukenv0307 commented Nov 13, 2023 •

edited

Loading

dukenv0307 commented Nov 13, 2023

dukenv0307 commented Nov 15, 2023

dukenv0307 commented Nov 20, 2023

youssef-lr commented Dec 4, 2023

youssef-lr commented Dec 4, 2023

dukenv0307 commented Dec 4, 2023 •

edited

Loading

youssef-lr left a comment

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

Fix created view is flickered when marking as unread #30815

Fix created view is flickered when marking as unread #30815

Conversation

dukenv0307 commented Nov 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 3, 2023

allroundexperts Nov 6, 2023

Choose a reason for hiding this comment

dukenv0307 Nov 6, 2023

Choose a reason for hiding this comment

allroundexperts commented Nov 6, 2023

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

dukenv0307 commented Nov 9, 2023

youssef-lr commented Nov 9, 2023

dukenv0307 commented Nov 10, 2023 • edited Loading

youssef-lr commented Nov 10, 2023

dukenv0307 commented Nov 13, 2023 • edited Loading

dukenv0307 commented Nov 13, 2023

dukenv0307 commented Nov 15, 2023

dukenv0307 commented Nov 20, 2023

youssef-lr commented Dec 4, 2023

youssef-lr commented Dec 4, 2023

dukenv0307 commented Dec 4, 2023 • edited Loading

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

dukenv0307 commented Nov 3, 2023 •

edited

Loading

dukenv0307 commented Nov 10, 2023 •

edited

Loading

dukenv0307 commented Nov 13, 2023 •

edited

Loading

dukenv0307 commented Dec 4, 2023 •

edited

Loading