Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video player #30829

Merged
merged 186 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
186 commits
Select commit Hold shift + click to select a range
87b7f76
Add expo-modules to application.
mczernek Sep 29, 2023
c279f81
Update package-lock.json after adding expo-modules.
mczernek Sep 29, 2023
63405fa
Bump kotlin to 1.8.20 to make it compatible with expo-modules.
mczernek Sep 29, 2023
2d00d23
Prettier on metro.config.js
mczernek Oct 2, 2023
a951a31
Add patch for plaid-sdk
mczernek Oct 3, 2023
80a1702
Merge branch 'main' into expo-modules
Skalakid Oct 4, 2023
11ac0d0
Add Video Player
Skalakid Aug 21, 2023
6c49f76
clear code
Skalakid Oct 5, 2023
389bdd7
fix send attachment modal
Skalakid Oct 6, 2023
7ac9cb4
Merge branch 'main' into video-player
Skalakid Oct 6, 2023
de64ca5
add icons
Skalakid Oct 6, 2023
b330c89
add volume slider
Skalakid Oct 6, 2023
784d62e
upgrade volume action button
Skalakid Oct 9, 2023
74e16b6
add basic popover menu
Skalakid Oct 10, 2023
02c5c49
prepare frontend for backend changes
Skalakid Oct 12, 2023
e8bb2be
Merge branch 'main' into video-player
Skalakid Oct 12, 2023
c98202d
Merge branch 'main' into video-player
Skalakid Oct 16, 2023
a84d96a
fix popover position
Skalakid Oct 16, 2023
8a1af63
Merge branch 'main' into video-player
Skalakid Oct 18, 2023
a059c2d
add basic changes for shared element logic
Skalakid Oct 19, 2023
5069db6
fix bugs after logic change
Skalakid Oct 19, 2023
1612192
add structure changes
Skalakid Oct 20, 2023
eb08069
reduced rerenders while changing volume
Skalakid Oct 20, 2023
a38e349
fix volume slider
Skalakid Oct 20, 2023
23bb760
fix progress bar
Skalakid Oct 23, 2023
33dc719
fix popover displaying
Skalakid Oct 23, 2023
cefdc24
Merge branch 'main' into video-player
Skalakid Oct 25, 2023
699366d
improved popover menu
Skalakid Oct 26, 2023
798f6b8
move popover logic to context
Skalakid Oct 26, 2023
e857108
clear structure
Skalakid Oct 26, 2023
1bad6b4
add route navigation to attachment modal for videos
Skalakid Oct 27, 2023
abdd7a3
refactor VideoPlayer component
Skalakid Oct 27, 2023
fb67aee
Merge branch 'main' into video-player
Skalakid Oct 30, 2023
fd86f6b
fix sharing players state and stroing it bor paused videos
Skalakid Oct 30, 2023
692acb6
fix fullscreen button for in-chat players
Skalakid Oct 30, 2023
87e63a2
remove logs
Skalakid Oct 30, 2023
fad120e
fix styles
Skalakid Nov 2, 2023
993c213
fix colors
Skalakid Nov 3, 2023
25b88c1
Merge branch 'main' into video-player
Skalakid Nov 3, 2023
e144f71
fix extractAttachmentsFromReport
Skalakid Nov 3, 2023
7087f1d
fix GH worklet errors
Skalakid Nov 3, 2023
0d09748
change thumbnail resizing strategy for all attachments
Skalakid Nov 3, 2023
21689f8
align thumbnail styles with figma
Skalakid Nov 3, 2023
5b03cc3
Merge branch 'main' into video-player
Skalakid Nov 17, 2023
c869a03
Merge branch 'main' into video-player
Skalakid Nov 20, 2023
33d4b26
add first part of review changes
Skalakid Nov 20, 2023
30eafed
add english translations
Skalakid Nov 20, 2023
75e5c1a
add spanish translations
Skalakid Nov 20, 2023
26a209f
add second part of review changes
Skalakid Nov 20, 2023
99084ed
add zIndex variable
Skalakid Nov 20, 2023
b027846
fix changing volume
Skalakid Nov 21, 2023
87bb56c
fix native errors
Skalakid Nov 21, 2023
ebc40fa
add instant mute button in volume slider
Skalakid Nov 21, 2023
c2f80be
fix volume slider hiding when dragging and increase dragging area size
Skalakid Nov 21, 2023
7a6243a
fix switching beetwen unloaded videos in attachment modal
Skalakid Nov 21, 2023
c9ee8d0
add review changes
Skalakid Nov 22, 2023
25c841e
change font size variable inside video player
Skalakid Nov 22, 2023
5c39b2b
fix ts errors
Skalakid Nov 22, 2023
b33357c
Merge branch 'main' into video-player
Skalakid Nov 22, 2023
c7787dc
patch assets-registry
Skalakid Nov 22, 2023
1001a99
redesign video player controls
Skalakid Nov 23, 2023
aa526be
add minimal width and height of the player
Skalakid Nov 23, 2023
387489f
add tooltips to video controls
Skalakid Nov 23, 2023
5444822
fix unnecessary rerenders inside video controls component
Skalakid Nov 23, 2023
6cf8958
fix showing arrows inside attachment carousel when video is playing
Skalakid Nov 23, 2023
90074bd
removed not used PlaybackContext props
Skalakid Nov 27, 2023
8837207
add playback speed logic changes
Skalakid Nov 27, 2023
4ca7dbe
change structure
Skalakid Nov 27, 2023
8bf30fc
move Progressbar to another folder
Skalakid Nov 27, 2023
c198199
fix changing volume in other video player when different one is playing
Skalakid Nov 27, 2023
fbe09d9
add thumb to volume slider
Skalakid Nov 27, 2023
543d65b
add explanation to the fix in VolumeContext
Skalakid Nov 28, 2023
f277674
Merge branch 'main' into video-player
Skalakid Dec 4, 2023
d32fc85
Merge branch 'main' into video-player
Skalakid Dec 14, 2023
498c552
Merge branch 'main' into video-player
Skalakid Dec 27, 2023
4cbe610
Fix video displaying in preview before uploading
Skalakid Dec 28, 2023
f9ce182
Fix shared video player in attachment modal
Skalakid Dec 28, 2023
3bb8355
Remove js MenuItem component
Skalakid Dec 28, 2023
6feacea
Change native devices behavior
Skalakid Dec 28, 2023
0fd86d5
Fix progress bars on native devices
Skalakid Dec 28, 2023
f51aaf2
Fix volume updating on native devices
Skalakid Dec 29, 2023
4995ea5
Change progress bar animation
Skalakid Dec 29, 2023
f7d47c1
Change native video controls style
Skalakid Dec 29, 2023
a9124d1
Change video popover menu logic
Skalakid Jan 2, 2024
7e81b74
Fix menu options functionalities
Skalakid Jan 2, 2024
efeb446
Fix PopoverMenu items updating
Skalakid Jan 2, 2024
a035800
Add popover positioning
Skalakid Jan 3, 2024
27942f1
Merge branch 'main' into video-player
Skalakid Jan 3, 2024
3983d10
Fix web popover visibility bug after merging main
Skalakid Jan 3, 2024
e04f9b5
Merge branch 'main' into video-player
Skalakid Jan 4, 2024
9df04ed
Add button hover styles
Skalakid Jan 4, 2024
259c734
Change light theme colors
Skalakid Jan 5, 2024
bd6eeb9
Fix volume slider
Skalakid Jan 5, 2024
301464c
Fix new icons on web
Skalakid Jan 5, 2024
83010ee
Add unloading players when changing pages
Skalakid Jan 5, 2024
ad6b707
Change empty video thumbnail styles
Skalakid Jan 5, 2024
5fbcd6e
Fix pausing video player when opening the modal
Skalakid Jan 8, 2024
311e51f
Fix video stop playing back after navigating to another report
kowczarz Jan 9, 2024
e12eb41
Fix
kowczarz Jan 12, 2024
c103bf8
Add video tag name detection
kowczarz Jan 12, 2024
c7b8550
Cleanup comments
kowczarz Jan 18, 2024
a5e4c0a
Fix PopoverMenu select when sub menus exists
kowczarz Jan 19, 2024
db4932b
Temporary workaround
kowczarz Jan 23, 2024
37e6d59
Cleanup attachment carousel
kowczarz Jan 23, 2024
b07c101
Cleanup
kowczarz Jan 23, 2024
13ce118
Cleanup comments
kowczarz Jan 23, 2024
d7bae12
Cleanup eslint issues
kowczarz Jan 23, 2024
2a3de47
Add video renderer
kowczarz Jan 23, 2024
42b56a9
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Jan 23, 2024
3b49c59
Post merge cleanup
kowczarz Jan 23, 2024
8db82ce
Post merge cleanup
kowczarz Jan 23, 2024
fb77237
Apply suggestions from code review
kowczarz Jan 24, 2024
3d1c964
Add missing html parser verification
kowczarz Jan 24, 2024
8bd7354
Rename Tooltip param name
kowczarz Jan 24, 2024
1c159c1
Fix error
kowczarz Jan 24, 2024
f161fd9
Cleanup
kowczarz Jan 24, 2024
b503ed9
Code review changes
kowczarz Jan 24, 2024
cf690fb
Add missing display names
kowczarz Jan 24, 2024
5b464a6
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Jan 24, 2024
2c877a1
Fix lint
kowczarz Jan 24, 2024
27d4d33
Code review changes
kowczarz Jan 25, 2024
6d4ab71
Fix crash on popover close
kowczarz Jan 25, 2024
79867d6
Fix not showing video controls on mobile
kowczarz Jan 25, 2024
3968609
Update expensify-common
kowczarz Jan 25, 2024
b58514c
Update expo-video
kowczarz Jan 26, 2024
7c350e7
Remove unused patch
kowczarz Jan 26, 2024
3b05e41
Fix error `Can't resolve 'crypto'`
kowczarz Jan 26, 2024
2c016fc
Add missing patch update
kowczarz Jan 26, 2024
88ca8c9
Update patch
kowczarz Jan 26, 2024
2a41225
Update comments
kowczarz Jan 29, 2024
e0e666f
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Jan 29, 2024
f1c02d2
Update locks after merge
kowczarz Jan 29, 2024
9cffbd2
Add tap and long press gesture handler to video controls
kowczarz Jan 29, 2024
db084fb
Keep playback status after progress bar interaction
kowczarz Jan 30, 2024
73e70a3
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Jan 31, 2024
c67a7a6
Fix typos
kowczarz Jan 31, 2024
a3da164
Post merge cleanup
kowczarz Jan 31, 2024
0fb774d
Fix version of expensify common
kowczarz Feb 5, 2024
326f49e
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Feb 5, 2024
42a85ca
Fix version wrong paddings in playback speed selection
kowczarz Feb 5, 2024
b3423d1
Update src/languages/es.ts
kowczarz Feb 5, 2024
ca03ecb
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Feb 6, 2024
96e3601
Merge branch 'main' of https://github.com/software-mansion-labs/expen…
kowczarz Feb 6, 2024
147ba16
Fix video crashes on mobiles
kowczarz Feb 7, 2024
3061023
Fix lint
kowczarz Feb 7, 2024
f479d57
Add get duration before fetching video
kowczarz Feb 8, 2024
7a858b7
Fix when switching to fullscreen and then exiting fullscreen mode whi…
kowczarz Feb 8, 2024
699e302
Fix not showing duration while loading
kowczarz Feb 8, 2024
287a59f
Fix not showing spinner while loading video
kowczarz Feb 8, 2024
a628ce9
Remove redundant console.log
kowczarz Feb 8, 2024
a3e8cee
Add toggle video playback on press on the video
kowczarz Feb 8, 2024
e46b3ee
Fix prop types warning
kowczarz Feb 8, 2024
d01cd57
Merge remote-tracking branch 'expensify/main' into video-player
kowczarz Feb 9, 2024
e0dafd3
Fix prop types warning
kowczarz Feb 9, 2024
63e1e8a
Cleanup BaseVideoPlayer.js
kowczarz Feb 9, 2024
02b9723
Fix video preview on Android
Skalakid Feb 12, 2024
42189d1
Merge branch 'main' into video-player
Skalakid Feb 12, 2024
1b04243
Add replaying the video when it finished playing and play button was …
Skalakid Feb 12, 2024
b29af26
Fix progress bar sliding above the limit
Skalakid Feb 12, 2024
0341a07
Fix pausing video on iOS safari when exiting fullscreen mode
Skalakid Feb 13, 2024
58ef191
Add loading indicator in case the video is buffering
Skalakid Feb 13, 2024
199a6bb
Add support for videos that were sent before backend changes
Skalakid Feb 13, 2024
9ba1d04
Change styles of the videos without thumbnail
Skalakid Feb 13, 2024
86a6da7
Remove video preview for videos sent before backend changes
Skalakid Feb 13, 2024
ea2f36a
Add new props
Skalakid Feb 13, 2024
b2f66d5
Fix entering fullscreen on Android Chrome
Skalakid Feb 13, 2024
2e606ce
Merge branch 'main' into video-player
Skalakid Feb 13, 2024
c9a64c5
Fix exiting fullscreen mode using 'X' on iOS mWeb
Skalakid Feb 14, 2024
75ce854
Move iOS fix logic to another function
Skalakid Feb 14, 2024
d3646d8
Fix TS errors
Skalakid Feb 14, 2024
89bba02
Fix prettier error
Skalakid Feb 14, 2024
db4d902
Fix TS error
Skalakid Feb 14, 2024
dd24e25
Merge branch 'main' into video-player
Skalakid Feb 14, 2024
64fa8bb
Fix Podfile.lock
Skalakid Feb 14, 2024
34408a4
Change styling props logic
Skalakid Feb 14, 2024
4d40724
Merge branch 'main' into video-player
Skalakid Feb 14, 2024
7a2ac97
Fix video element sharing on web after merging main
Skalakid Feb 14, 2024
7963dfb
Merge branch 'main' into video-player
Skalakid Feb 14, 2024
207a784
Merge branch 'main' into video-player
Skalakid Feb 15, 2024
8c461da
Merge branch 'main' into video-player
Skalakid Feb 15, 2024
e959d2a
Add review changes
Skalakid Feb 15, 2024
45fc84e
Merge branch 'main' into video-player
Skalakid Feb 15, 2024
277f21a
Merge branch 'main' into video-player
Skalakid Feb 15, 2024
e3b0679
Fix podfile check
Skalakid Feb 15, 2024
e92af99
Merge branch 'main' into video-player
tomekzaw Feb 15, 2024
bb70e3f
Merge branch 'main' into video-player
blazejkustra Feb 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ tsconfig.tsbuildinfo
.yalc
yalc.lock

# Expo
.expo
dist/
web-build/

# Local https certificate/key
config/webpack/*.pem

Expand Down
6 changes: 6 additions & 0 deletions assets/images/fullscreen.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/images/meter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/images/mute.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/images/pause.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/images/play.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions assets/images/volume-high.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/images/volume-low.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions config/webpack/webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ const includeModules = [
'react-native-google-places-autocomplete',
'react-native-qrcode-svg',
'react-native-view-shot',
'@react-native/assets',
'expo-av',
].join('|');

const envToLogoSuffixMap = {
Expand Down Expand Up @@ -241,6 +243,7 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({
],
fallback: {
'process/browser': require.resolve('process/browser'),
crypto: false,
},
},

Expand Down
Loading
Loading