See extra fields per chat #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still some discussion on this one, keeping it a draft. |
|
Going to figure out how/if I can do unit tests for this one. |
added 7 commits
June 3, 2021 17:16
…to amal-chattype-info
…to amal-chattype-info
TomatoToaster
requested review from
yuwenmemon and
a team
and removed request for
yuwenmemon
|
Ooops it looks like I double dipped in puller-bear sorry @AndrewGable. |
stitesExpensify
approved these changes
Jun 8, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks
|
🚀 Deployed to staging in version: 1.0.65-1🚀
|
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stitesExpensify, please review
CC: @yuwenmemon
Details
This sets up information used in default room type chats.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/161776
Tests
Tested that this change lets you load reports and doesn't cause the app to crash, since we don't have any front end changes for this feature yet.
QA Steps
report_go through a few of the options and verify that ownerEmail, policyID, and chatType are there in the object (see screenshot for reference)Tested On
Screenshots
Essentially just checking that the values: ownerEmail, policyID, and chatType are set in localstorages. They'll be used in a later PR.
Web, Mweb, and Desktop