-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DateTimeFormat
polyfills with timezone abbreviations
#31074
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a1021fd
fix for timezone abbreviations
tienifr 4653beb
remove console
tienifr edd9965
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr 3d3b41a
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr aec6871
add timezone polyfills
tienifr 78b0022
fix lint
tienifr 1e6909a
fix lint
tienifr 7300104
fix lint
tienifr 8658f99
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr ba1a2d7
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr f9afabe
retrieve timezone from DateUtils
tienifr 2c52e0c
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr d1feb9e
Merge branch 'main' of https://github.com/tienifr/App into fix/27392
tienifr 5242683
fix lint
tienifr c597f1d
Merge branch 'main' into fix/27392
tienifr b207560
enable eslint
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import type {DateTimeFormatConstructor} from '@formatjs/intl-datetimeformat'; | ||
import DateUtils from '@libs/DateUtils'; | ||
|
||
/* eslint-disable @typescript-eslint/naming-convention */ | ||
const tzLinks: Record<string, string> = { | ||
'Africa/Abidjan': 'Africa/Accra', | ||
CET: 'Europe/Paris', | ||
CST6CDT: 'America/Chicago', | ||
EET: 'Europe/Sofia', | ||
EST: 'America/Cancun', | ||
EST5EDT: 'America/New_York', | ||
'Etc/GMT': 'UTC', | ||
'Etc/UTC': 'UTC', | ||
Factory: 'UTC', | ||
GMT: 'UTC', | ||
HST: 'Pacific/Honolulu', | ||
MET: 'Europe/Paris', | ||
MST: 'America/Phoenix', | ||
MST7MDT: 'America/Denver', | ||
PST8PDT: 'America/Los_Angeles', | ||
WET: 'Europe/Lisbon', | ||
}; | ||
/* eslint-enable @typescript-eslint/naming-convention */ | ||
|
||
export default function () { | ||
// Because JS Engines do not expose default timezone, the polyfill cannot detect local timezone that a browser is in. | ||
// We must manually do this by getting the local timezone before adding polyfill. | ||
let currentTimezone = DateUtils.getCurrentTimezone().selected as string; | ||
if (currentTimezone in tzLinks) { | ||
currentTimezone = tzLinks[currentTimezone]; | ||
} | ||
|
||
require('@formatjs/intl-datetimeformat/polyfill-force'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tienifr Can you address this comment: #34035 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have replied on the other issue #34035 (comment) |
||
require('@formatjs/intl-datetimeformat/locale-data/en'); | ||
require('@formatjs/intl-datetimeformat/locale-data/es'); | ||
require('@formatjs/intl-datetimeformat/add-all-tz'); | ||
|
||
if ('__setDefaultTimeZone' in Intl.DateTimeFormat) { | ||
// eslint-disable-next-line no-underscore-dangle | ||
(Intl.DateTimeFormat as DateTimeFormatConstructor).__setDefaultTimeZone(currentTimezone); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse
DateUtils.getCurrentTimezone()
without connecting Onyx here unless it causes cyclic dependency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!