-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Distance - reset map boundaries on resize #31156
Conversation
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
0679987
to
dc75245
Compare
dc75245
to
dfae9a1
Compare
dfae9a1
to
95c9b7e
Compare
@Santhosh-Sellavel a friendly bump to review this, please. |
Reviewer Checklist
Screenshots/VideosAndroid: Native & iOS: NativeScreen.Recording.2023-11-14.at.9.56.08.PM.movAndroid: mWeb Chrome & iOS: mWeb SafariScreen.Recording.2023-11-14.at.9.54.42.PM.movMacOS: Chrome / Safari & MacOS: DesktopScreen.Recording.2023-11-14.at.9.48.32.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a NAB Otherwise LGTM, tests well!
Co-authored-by: Santhosh Sellavel <85645967+Santhosh-Sellavel@users.noreply.github.com>
Thanks @Santhosh-Sellavel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests good, looks good. Thanks! 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀
|
Details
Distance: reset map boundaries on load and resize.
Fixed Issues
$ #29469
PROPOSAL: #29469 (comment)
Tests
Same as QA.
Offline tests
Same as QA.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-compressed.mp4
Android: mWeb Chrome
chrome-compressed.mp4
iOS: Native
iOS.mp4
iOS: mWeb Safari
safari.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov