-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Session check for TaskHeaderActionButton #31200
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi @abdulrahuman5196, the BE changes were already deployed and this PR is ready for review |
@marcochavezf If possible, could you provide some information on the change we did here? I don't have access to backend PR, so I am kind of in the dark on the changes we made here. |
@abdulrahuman5196 it was an intermediate change related to the type authToken, the problem is that we were not loading the task thread for anonymous accounts and we're throwing an error when the anonymous user clicks on |
Thank you for the information. Will check the PR in my morning. |
Reviewing now |
@marcochavezf I tested on web and seems to work fine. Its is testable at native ios and android? Or this case isn't possible there? |
Ah yes, it's possible to open the public room from the console, I will update the instructions in a bit |
Updated. You can use terminal command npx to open the public room like |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-11-22.at.3.09.45.PM.mp4Android: mWeb ChromeScreen.Recording.2023-11-22.at.2.59.18.PM.mp4iOS: NativeScreen.Recording.2023-11-22.at.3.06.16.PM.mp4iOS: mWeb SafariScreen.Recording.2023-11-22.at.2.46.20.PM.mp4MacOS: Chrome / SafariScreen.Recording.2023-11-21.at.9.23.32.PM.mp4MacOS: DesktopN/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours.
🎀 👀 🎀
C+ Reviewed
NAB: Author's checklist is missing other platform videos. Do add if possible. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2023-11-23.at.07.19.30.movMacOS: Desktop |
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.3-0 🚀
|
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.3-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.3-11 🚀
|
On hold for https://github.com/Expensify/Auth/pull/9180Details
This PR checks if an anonymous user can click on the task button to mark it as completed, which in the given case the user should be redirected to RHP sign-in page.
Fixed Issues
$ #23491
Tests
(dev) On Android open the deep link to the public room from Terminal: npx uri-scheme open new-expensify://r/128736872 --android
(dev) On iOS also open the deep link to the public room from Terminal: npx uri-scheme open new-expensify://r/128736872 --ios
Mark as complete
and verify the sign-in page is shownScreen.Recording.2023-11-10.at.12.54.28.p.m.mov
Offline tests
N/A
QA Steps
Same as
Tests
stepsPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop