Show merchant for split bill #31604

dukenv0307 · 2023-11-21T06:13:29Z

Details

Show merchant for split bill

Fixed Issues

$ #30680
PROPOSAL: #30680 (comment)

Tests

Create a scan split bill with some users
Go to the group chat to see the split bill preview
Verify that the merchant is shown in split bill preview
Go to the IOU report of this split bill
Verify that the merchant is also shown in the IOU preview
Create a manually split bill with some users, add a description for this split bill
Go to the group chat to see the split bill preview
Since merchant is the default, verify that the description is shown in the preview
Go to the IOU report of this split bill
Verify that the description is also shown in the IOU preview
Create a distance request with the description
Verify that in the IOU preview, distance is shown as the merchant field

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Create a scan split bill with some users
Go to the group chat to see the split bill preview
Verify that the merchant is shown in split bill preview
Go to the IOU report of this split bill
Verify that the merchant is also shown in the IOU preview
Create a manually split bill with some users, add a description for this split bill
Go to the group chat to see the split bill preview
Since merchant is the default, verify that the description is shown in the preview
Go to the IOU report of this split bill
Verify that the description is also shown in the IOU preview
Create a distance request with the description
Verify that in the IOU preview, distance is shown as the merchant field

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-21.at.12.51.49.mov

Android: mWeb Chrome

Screen.Recording.2023-11-21.at.12.48.44.mov

iOS: Native

Screen.Recording.2023-11-21.at.12.53.41.mov

iOS: mWeb Safari

Screen.Recording.2023-11-21.at.12.46.52.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-21.at.12.41.18.mov

web-3.mov

MacOS: Desktop

Screen.Recording.2023-11-21.at.12.57.44.mov

melvin-bot · 2023-11-21T08:49:23Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-11-21T18:53:53Z

I'm looking for PRs to review so I'll jump in here

neil-marcellini

Kind of weird logic but I guess it works. Please make sure the tests include signing in as a recipient of the split as in the issue. Also, please expand your test steps to make sure this doesn't break other request types.

dukenv0307 · 2023-11-22T09:41:26Z

Please make sure the tests include signing in as a recipient of the split as in the issue

@neil-marcellini Sure. While testing, I created a scan receipt as in the issue. Just cut off the create step in the screenshots to decrease the size of the video.

Also, please expand your test steps to make sure this doesn't break other request types.

Will update this soon.

dukenv0307 · 2023-11-22T10:07:53Z

@neil-marcellini Just updated the test steps, and added an extra video on Web for the updated steps.

cubuspl42 · 2023-11-27T16:56:09Z

@dukenv0307 Would you merge main and test points 6 to 8 again? I cannot see the expected result, for me nothing is displayed in the place where we expect the description.

dukenv0307 · 2023-11-28T08:12:18Z

@cubuspl42 Still works well for me. Can you share the full screen if you're still reproducible this case?

Screen.Recording.2023-11-28.at.15.10.59.mov

cubuspl42 · 2023-11-28T09:48:54Z

Am I following the steps incorrectly?

missing-description-1-web.mp4

dukenv0307 · 2023-11-28T10:15:54Z

@cubuspl42 Did you pull the newest code in this branch?

dukenv0307 · 2023-11-28T10:16:09Z

Screen.Recording.2023-11-28.at.17.15.11.mov

dukenv0307 · 2023-11-28T10:21:25Z

@cubuspl42 Seems like I committed a commit but forgot to push the code from local. I just pushed some changes please help to test again.

cubuspl42 · 2023-11-28T12:10:34Z

distance is shown as the merchant field

This is misleading in two ways:

It should be "Distance and rate" not just "Distance" and not "as the merchant field" but "instead of the Merchant field"

I would suggest these steps:

Test the "Scan" flow
- Create a scan split bill with some users
- Go to the group chat to see the split bill preview
- Verify that the merchant is shown in split bill preview
- Go to the IOU report of this split bill
- Verify that the merchant is also shown in the IOU preview
Test the "Manual" flow
- Create a manually split bill with some users, add a description for this split bill
- Go to the group chat to see the split bill preview
- Since merchant is the default, verify that the description is shown in the preview
- Go to the IOU report of this split bill
- Verify that the description is also shown in the IOU preview
Test the "Distance" flow
- Create a distance request with the description
- Verify that distance and rate is shown in the IOU preview

cubuspl42 · 2023-11-28T12:12:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

merchant-preview-web.mp4

Mobile Web - Chrome

merchant-preview-android-web-compressed.mp4

Mobile Web - Safari

merchant-preview-ios-web.mp4

Desktop

iOS

merchant-preview-ios.mp4

Android

merchant-preview-android-compressed.mp4

OSBotify · 2023-11-28T19:36:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-30T12:15:18Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.5-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show merchant for split bill

3afa0ce

dukenv0307 marked this pull request as ready for review November 21, 2023 08:49

dukenv0307 requested a review from a team as a code owner November 21, 2023 08:49

melvin-bot bot requested review from cubuspl42 and removed request for a team November 21, 2023 08:49

neil-marcellini self-requested a review November 21, 2023 18:54

neil-marcellini reviewed Nov 21, 2023

View reviewed changes

Merge branch 'main' into fix/30680

b868f11

update to show description

f5db4be

aimane-chnaif mentioned this pull request Nov 22, 2023

Allow setting merchant for split bill #30721

Merged

57 tasks

trjExpensify assigned dukenv0307 Nov 22, 2023

Merge branch 'main' into fix/30680

39913ac

fix lint

290e061

cubuspl42 approved these changes Nov 28, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch November 28, 2023 12:16

neil-marcellini approved these changes Nov 28, 2023

View reviewed changes

nkuoch approved these changes Nov 28, 2023

View reviewed changes

nkuoch merged commit be800e1 into Expensify:main Nov 28, 2023
17 checks passed

github-actions bot mentioned this pull request Nov 29, 2023

Deploy Checklist: New Expensify 2023-11-29 #32175

Closed

55 tasks

ZhenjaHorbach mentioned this pull request Nov 29, 2023

Split bill - Split bill preview briefly shows participant name and date #32183

Closed

6 tasks

pecanoro mentioned this pull request Nov 29, 2023

Revert "Show merchant for split bill" #32191

Merged

56 tasks

melvin-bot bot mentioned this pull request Nov 30, 2023

[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant #30680

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show merchant for split bill #31604

Show merchant for split bill #31604

dukenv0307 commented Nov 21, 2023 •

edited

Loading

melvin-bot bot commented Nov 21, 2023

neil-marcellini commented Nov 21, 2023

neil-marcellini left a comment

dukenv0307 commented Nov 22, 2023

dukenv0307 commented Nov 22, 2023 •

edited

Loading

cubuspl42 commented Nov 27, 2023

dukenv0307 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023 •

edited

Loading

cubuspl42 commented Nov 28, 2023 •

edited

Loading

cubuspl42 commented Nov 28, 2023

OSBotify commented Nov 28, 2023

OSBotify commented Nov 30, 2023

Show merchant for split bill #31604

Show merchant for split bill #31604

Conversation

dukenv0307 commented Nov 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 21, 2023

neil-marcellini commented Nov 21, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

dukenv0307 commented Nov 22, 2023

dukenv0307 commented Nov 22, 2023 • edited Loading

cubuspl42 commented Nov 27, 2023

dukenv0307 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023

dukenv0307 commented Nov 28, 2023 • edited Loading

cubuspl42 commented Nov 28, 2023 • edited Loading

cubuspl42 commented Nov 28, 2023

Reviewer Checklist

Screenshots/Videos

OSBotify commented Nov 28, 2023

OSBotify commented Nov 30, 2023

dukenv0307 commented Nov 21, 2023 •

edited

Loading

dukenv0307 commented Nov 22, 2023 •

edited

Loading

dukenv0307 commented Nov 28, 2023 •

edited

Loading

cubuspl42 commented Nov 28, 2023 •

edited

Loading