Fix displaying LHN instead Expensify uses Plaid to connect account #31614

shahinyan11 · 2023-11-21T11:14:38Z

Details

Android - LHN is displayed instead Expensify uses Plaid to connect your account

Fixed Issues

$ #30617
PROPOSAL: #30617 (comment)

Tests

The steps only for Android: Native and IOS: Native

Go to account settings >> Workspace
Click on the workspace to view its settings
Click on Cards or Reimbursements settings
Select "Connect bank account" >> "Connect online with Plaid
Put app on background
Open app again
Verify that the last screen is visible and not LHN

Verify that no errors appear in the JS console

Offline tests

The "Connect bank account" is not available for offline mode

QA Steps

The steps only for Android: Native and IOS: Native

Go to account settings >> Workspace
Click on the workspace to view its settings
Click on Cards or Reimbursements settings
Select "Connect bank account" >> "Connect online with Plaid
Put app on background
Open app again
Verify that the last screen is visible and not LHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-21.at.14.56.46.mov

Android: mWeb Chrome

2023-11-22.22.30.03.mp4

iOS: Native

Screen.Recording.2023-11-21.at.16.55.20.mov

iOS: mWeb Safari

Screen.Recording.2023-11-22.at.21.24.17.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-21.at.19.18.02.mov

MacOS: Desktop

Screen.Recording.2023-11-21.at.22.11.58.mov

melvin-bot · 2023-11-21T11:14:43Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-11-21T11:14:54Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

s77rt · 2023-11-21T11:23:54Z

Few notes:

Please update the title to be more descriptive on what this PR is changing.
The test steps are not complete, there should a step to verify against the expected behavior
Can you please double check the offline test steps. I don't think Plaid won't work offline
Add the missing of Screenshots/Videos for other platforms

shahinyan11 · 2023-11-21T11:33:11Z

Can you please double check the offline test steps. I don't think Plaid won't work offline

@s77rt The connect bank account functionality is disabled for offline mode ( the button is hidden ) . I just didn’t know whether to check it in this case or not .

And could you help me with this? What did I miss doing

s77rt · 2023-11-21T11:40:09Z

Please fix the offline test steps. As for CLA check #31614 (comment)

shahinyan11 · 2023-11-21T11:42:30Z

I have read the CLA Document and I hereby sign the CLA

shahinyan11 · 2023-11-21T11:50:35Z

Please fix the offline test steps.

What do you mean by saying "fix the offline test steps". Should I remove the checkbox from the checklist or should I do something else ?

s77rt · 2023-11-21T12:09:45Z

You need to write an accurate testing steps. If we are expected not to see the "Connect bank account" button then it does not make sense to have a step that mentions to click on it. Those steps are done by the QA team, if any step fail a new issue will be created which could be a false positive if the steps are not accurate.

shahinyan11 · 2023-11-21T13:09:30Z

@s77rt I made the necessary changes. Can you please check if there is anything left to fix ?

s77rt · 2023-11-21T13:13:07Z

src/components/PlaidLink/index.native.js

 import Log from '@libs/Log';
 import CONST from '@src/CONST';
 import {plaidLinkDefaultProps, plaidLinkPropTypes} from './plaidLinkPropTypes';

 function PlaidLink(props) {
-    useDeepLinkRedirector();


useDeepLinkRedirector was removed from react-native-plaid-link-sdk since it's no longer needed.

Yes. There is not such hook in new version and it is not need. It is mentioned in plaid link official doc

s77rt · 2023-11-21T13:13:57Z

@shahinyan11 Please add missing screenshots/videos

shahinyan11 · 2023-11-21T14:08:25Z

Please add missing screenshots/videos

I added videos for both android and IOS . This case may not happen on other platforms because it related changing application state. Changing to background and then returning to foreground is native app behavior only.
If you do not agree with me, please write more precisely which screenshot or video is missing

s77rt · 2023-11-21T14:20:30Z

Each change should be tested on all the platforms. For the remaining platforms you can show that the Plaid flow is still working. You can do so by using the plaid sandbox info: username: user_good and password: pass_good

To use plaid sandbox make sure you are using the staging server i.e. go to Preference and enable the staging server switch

shahinyan11 · 2023-11-21T14:42:50Z

You can do so by using the plaid sandbox info: username: user_good and password: pass_good

To use plaid sandbox make sure you are using the staging server i.e. go to Preference and enable the staging server switch

I did not understand this well. How is plaid sandbox different from standard plaid with which I've been working with before? And for what I need username and password ?
I apologize if I ask a lot of questions but please keep in mind that I’m new and don’t know a lot

s77rt · 2023-11-21T14:47:01Z

To add bank account using plaid you will have to supply real information. Or you can just use the plaid sandbox and use test credentials to add the bank account.

(the process is the same, to use the sandbox you will just have to enable staging switch in preferences)

shahinyan11 · 2023-11-21T14:50:42Z

To add bank account using plaid you will have to supply real information. Or you can just use the plaid sandbox and use test credentials to add the bank account.

But I didn't authenticate in plaid link account around this issue before. What steps I should do after auth in plaid link account to get the video you want ?

s77rt · 2023-11-21T14:54:12Z

This is needed to be sure that Plaid is still working and can be used to add bank accounts.

Video will be something like that:

Screen.Recording.2023-11-21.at.3.50.51.PM.mov

shahinyan11 · 2023-11-21T14:58:12Z

Now should I change uploaded videos for android and IOS too. Or I can add such video only for other platforms ?

s77rt · 2023-11-21T15:05:18Z

Just add those videos for the missing platforms

s77rt · 2023-11-21T15:15:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2023-11-21T15:15:53Z

@shahinyan11 In the testings steps please add a note that the steps are only for native.

s77rt · 2023-11-21T15:26:38Z

Encode it to a lower resolution

shahinyan11 · 2023-11-21T15:31:44Z

I added video for MacOS: Chrome / Safari and then get this error

Is there another account ?

shahinyan11 · 2023-11-21T16:09:30Z

@s77rt Is there another account ?

shahinyan11 · 2023-11-23T08:00:23Z

Looks like the Snyk service is complaining about Out of sync package.json and package-lock.json detected. Please run "package.json install" and try again. 🤔

is it directed at me ? If yes I did not understand where I should run this "package.json install" . I tried npm install but it didn't change anything .
I suggest to delete package-lock.json and then run npm install if you do not mind

s77rt · 2023-11-23T12:55:03Z

@shahinyan11 You should not delete package-lock.json. Please keep the original one and only commit the changes after npm install

This reverts commit 4785c97. rever updating package-lock.json

shahinyan11 · 2023-11-23T14:16:23Z

@shahinyan11 You should not delete package-lock.json. Please keep the original one and only commit the changes after npm install

But the npm install doesn't change anything and I can not make a new commit

shahinyan11 · 2023-11-23T15:28:28Z

But the npm install doesn't change anything and I can not make a new commit

@s77rt You did not answer to this

s77rt · 2023-11-23T15:35:28Z

@shahinyan11 I see package.json changes are already included but if we are still out of sync then you should merge main into your branch then run npm install

shahinyan11 · 2023-11-23T15:47:51Z

@s77rt my repo is forked. And there is not any changes when I pull main branch. How I pull last updates from original main branch

shahinyan11 · 2023-11-23T16:12:29Z

@shahinyan11 I see package.json changes are already included but if we are still out of sync then you should merge main into your branch then run npm install

@s77rt I did it. But I see in checks that the license/synk is still failed . Is it mean that something still wrong ?

s77rt · 2023-11-23T19:12:07Z

@shahinyan11 I don't know for sure but does not seem related. Robert will check and let you know if anything is needed from your side.

shahinyan11 · 2023-11-27T10:13:32Z

@s77rt @robertjchen Is not there any news ?

melvin-bot · 2023-11-29T06:42:37Z

@robertjchen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

robertjchen · 2023-11-29T06:43:19Z

Known issue with Snyk license check: https://expensify.slack.com/archives/C01GTK53T8Q/p1700498232891239

OSBotify · 2023-11-29T06:47:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-30T12:15:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.5-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix github issue 30617

b7699c7

shahinyan11 requested a review from a team as a code owner November 21, 2023 11:14

melvin-bot bot removed the request for review from a team November 21, 2023 11:14

melvin-bot bot requested a review from s77rt November 21, 2023 11:14

shahinyan11 changed the title ~~Fix github issue 30617~~ Fix displaying LHN instead Expensify uses Plaid to connect account Nov 21, 2023

Update ios pods

46119d6

s77rt reviewed Nov 21, 2023

View reviewed changes

update package-lock.json

4785c97

shahinyan11 dismissed robertjchen’s stale review via 4785c97 November 23, 2023 12:30

Revert "update package-lock.json"

70bc4ff

This reverts commit 4785c97. rever updating package-lock.json

shahinyan11 requested a review from s77rt November 23, 2023 14:41

s77rt approved these changes Nov 23, 2023

View reviewed changes

melvin-bot bot requested a review from robertjchen November 23, 2023 15:16

marg main into current branch

2ce608b

Pull main Branch And Resolve Conflicts

f4edcf9

shahinyan11 requested a review from s77rt November 28, 2023 14:46

Remove Extra File

2e9d467

s77rt approved these changes Nov 28, 2023

View reviewed changes

robertjchen approved these changes Nov 29, 2023

View reviewed changes

robertjchen merged commit 1234b0d into Expensify:main Nov 29, 2023
15 of 18 checks passed

melvin-bot bot added the Emergency label Nov 29, 2023

robertjchen removed the Emergency label Nov 29, 2023

github-actions bot mentioned this pull request Nov 29, 2023

Deploy Checklist: New Expensify 2023-11-29 #32175

Closed

55 tasks

melvin-bot bot mentioned this pull request Nov 30, 2023

[HOLD for payment 2023-12-07] [$500] Android - LHN is displayed instead Expensify uses Plaid to connect your account #30617

Closed

6 tasks

Fix displaying LHN instead Expensify uses Plaid to connect account #31614

Fix displaying LHN instead Expensify uses Plaid to connect account #31614

Conversation

shahinyan11 commented Nov 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 21, 2023

github-actions bot commented Nov 21, 2023 • edited Loading

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023 • edited Loading

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023

s77rt Nov 21, 2023

Choose a reason for hiding this comment

shahinyan11 Nov 21, 2023

Choose a reason for hiding this comment

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023 • edited Loading

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023 • edited Loading

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023

s77rt commented Nov 21, 2023

s77rt commented Nov 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Nov 21, 2023

s77rt commented Nov 21, 2023

shahinyan11 commented Nov 21, 2023 • edited Loading

shahinyan11 commented Nov 21, 2023

shahinyan11 commented Nov 23, 2023 • edited Loading

s77rt commented Nov 23, 2023

shahinyan11 commented Nov 23, 2023 • edited Loading

shahinyan11 commented Nov 23, 2023

s77rt commented Nov 23, 2023

shahinyan11 commented Nov 23, 2023

shahinyan11 commented Nov 23, 2023 • edited Loading

s77rt commented Nov 23, 2023

shahinyan11 commented Nov 27, 2023

melvin-bot bot commented Nov 29, 2023

robertjchen commented Nov 29, 2023

OSBotify commented Nov 29, 2023

OSBotify commented Nov 30, 2023

shahinyan11 commented Nov 21, 2023 •

edited

Loading

github-actions bot commented Nov 21, 2023 •

edited

Loading

shahinyan11 commented Nov 21, 2023 •

edited

Loading

shahinyan11 commented Nov 21, 2023 •

edited

Loading

shahinyan11 commented Nov 21, 2023 •

edited

Loading

s77rt commented Nov 21, 2023 •

edited

Loading

shahinyan11 commented Nov 21, 2023 •

edited

Loading

shahinyan11 commented Nov 23, 2023 •

edited

Loading

shahinyan11 commented Nov 23, 2023 •

edited

Loading

shahinyan11 commented Nov 23, 2023 •

edited

Loading