-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS exception handling for beta review #3166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still trying to understand the consequence of this workaround. I believe that it will allow the workflow to finish, but will it actually deliver the latest version of the app to TF? Or will the previous build (the one that's currently queued for app review) be delivered via TF upon review / approval?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the best we can do for now, but @AndrewGable let's monitor the deploy that happens when this is merged to try and answer the following questions:
- What is highest version that's currently uploaded to TF?
- Which beta version(s) is(are) currently in review? Can there be multiple? I think no...
- Does this workaround allows the workflow to complete without error?
- After the workflow completes, is the new beta version uploaded to TF? Is is queued for review?
I'll let you merge @AndrewGable since you might want to monitor if it creates a TestFlight release. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Details
Adds the exception handling code as mentioned in this GitHub comment: fastlane/fastlane#18408 (comment)
I am not 100% that this exception handling will work on first run, it was hard to confirm that this check
e.message.include? "Another build is in review"
will work, but I am feeling confident it's a good first try.Fixed Issues
Fixes #2748
Tests