Fix createMenuPositionSidebar style #31679

WojtekBoman · 2023-11-22T10:05:58Z

Details

Floating action button size was changed from 40px x 40px to 52px to 52px. This PR fixes the position of the sidebar menu which wasn't adjusted to the new button size. The button size has changed by 12px, so the position of the sidebar menu has increased also by 12px. This update is quite simple, so I've attached screenshots only for the web version.

Fixed Issues

Before:

After:

$ #31632
PROPOSAL:

Tests

Open the app.
Log in.
Click on the floating action button.
Check if the button is not overlapped by the menu.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-22T10:29:15Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2023-11-28T15:38:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

akinwale

LGTM.

melvin-bot · 2023-11-28T16:08:50Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31632 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

jasperhuangg · 2023-11-29T21:39:42Z

src/styles/styles.ts

@@ -1395,7 +1395,7 @@ const styles = (theme: ThemeColors) =>
        createMenuPositionSidebar: (windowHeight: number) =>
            ({
                horizontal: 18,
-                vertical: windowHeight - 75,
+                vertical: windowHeight - 87,


Really don't like these random numbers being thrown around, any chance we can construct this value out of existing constants? Why is it changing from 75 => 87?

It was mentioned in the description of this PR. But you're right it could be written more readably, so I refactored this code and added a comment with some explanations

@jasperhuangg Could you check if the last change in this line is ok?

shawnborton · 2023-12-01T01:16:50Z

src/styles/styles.ts

-                vertical: windowHeight - 75,
+                // Menu should be displayed 10px above the floating action button.
+                // To achieve that sidebar must be moved by: distance from the bottom of the sidebar to the fab (variables.fabBottom) + fab height (variables.componentSizeLarge) + distance above the fab (10px)
+                vertical: windowHeight - (variables.fabBottom + variables.componentSizeLarge + 10),


We try to always use units of 4... so perhaps + 12 makes more sense here

shawnborton · 2023-12-01T01:17:18Z

src/styles/variables.ts

@@ -43,6 +43,7 @@ export default {
    avatarSizeMentionIcon: 16,
    avatarSizeSmallSubscript: 14,
    defaultAvatarPreviewSize: 360,
+    fabBottom: 25,


What does this mean exactly? It's the distance of the FAB to the bottom of the screen? What was it before we made any of these changes?

Yes, it's this distance. I've added this variable only to use it in a calculation of the menu position. Thanks to that it's easier to understand how we set the menu position

Sounds good.

jasperhuangg

Thanks!

jasperhuangg · 2023-12-07T19:00:43Z

All yours @shawnborton

OSBotify · 2023-12-07T19:40:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-08T01:24:05Z

🚀 Deployed to staging by https://github.com/shawnborton in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T02:53:58Z

🚀 Deployed to staging by https://github.com/shawnborton in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T10:41:15Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T15:23:10Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix createMenuPositionSidebar style

13d9b14

WojtekBoman marked this pull request as ready for review November 22, 2023 10:29

WojtekBoman requested a review from a team as a code owner November 22, 2023 10:29

melvin-bot bot requested review from akinwale and removed request for a team November 22, 2023 10:29

WojtekBoman mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-12-18] [$500] Web - FAB Menu - FAB menu is overlapping with FAB icon #31632

Closed

6 tasks

akinwale approved these changes Nov 28, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg November 28, 2023 16:08

jasperhuangg approved these changes Nov 29, 2023

View reviewed changes

jasperhuangg requested changes Nov 29, 2023

View reviewed changes

Refactor createMenuPositionSidebar

83478a0

shawnborton reviewed Dec 1, 2023

View reviewed changes

Increase the gap between fab and menu

15e50b4

jasperhuangg approved these changes Dec 7, 2023

View reviewed changes

shawnborton approved these changes Dec 7, 2023

View reviewed changes

shawnborton merged commit fc4a46f into Expensify:main Dec 7, 2023
18 checks passed

github-actions bot mentioned this pull request Dec 8, 2023

Deploy Checklist: New Expensify 2023-12-08 #32704

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix createMenuPositionSidebar style #31679

Fix createMenuPositionSidebar style #31679

WojtekBoman commented Nov 22, 2023 •

edited

Loading

melvin-bot bot commented Nov 22, 2023

akinwale commented Nov 28, 2023 •

edited

Loading

akinwale left a comment

melvin-bot bot commented Nov 28, 2023

jasperhuangg Nov 29, 2023

WojtekBoman Nov 30, 2023

WojtekBoman Dec 5, 2023

shawnborton Dec 1, 2023

shawnborton Dec 1, 2023

WojtekBoman Dec 1, 2023

shawnborton Dec 1, 2023

jasperhuangg left a comment

jasperhuangg commented Dec 7, 2023

OSBotify commented Dec 7, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 11, 2023

Fix createMenuPositionSidebar style #31679

Fix createMenuPositionSidebar style #31679

Conversation

WojtekBoman commented Nov 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 22, 2023

akinwale commented Nov 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 28, 2023

jasperhuangg Nov 29, 2023

Choose a reason for hiding this comment

WojtekBoman Nov 30, 2023

Choose a reason for hiding this comment

WojtekBoman Dec 5, 2023

Choose a reason for hiding this comment

shawnborton Dec 1, 2023

Choose a reason for hiding this comment

shawnborton Dec 1, 2023

Choose a reason for hiding this comment

WojtekBoman Dec 1, 2023

Choose a reason for hiding this comment

shawnborton Dec 1, 2023

Choose a reason for hiding this comment

jasperhuangg left a comment

Choose a reason for hiding this comment

jasperhuangg commented Dec 7, 2023

OSBotify commented Dec 7, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 11, 2023

WojtekBoman commented Nov 22, 2023 •

edited

Loading

akinwale commented Nov 28, 2023 •

edited

Loading