Fix/32230: Update recently used tag and category when editing request #32467

DylanDylann · 2023-12-05T05:50:12Z

Details

Update recently used tag and category when editing request

Fixed Issues

$ #32230
PROPOSAL: #32230 (comment)

Tests

Tap employee WS chat
Create a new manual request/distance request with any category in that employee WS chat
Edit the category of the above request to another category
Create a new manual request/distance request in WS chat (in step 1)
Click on the category to select the category for new request
Verify that the edited category in step 3 is displayed in recent section

Verify that no errors appear in the JS console

Offline tests

same above

QA Steps

Tap employee WS chat
Create a new manual request/distance request with any category in that employee WS chat
Edit the category of the above request to another category
Create a new manual request/distance request in WS chat (in step 1)
Click on the category to select the category for new request
Verify that the edited category in step 3 is displayed in recent section

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.06-12-2023.18.06.48.webm

Android: mWeb Chrome

Screencast.from.06-12-2023.18.14.46.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

Screen.Recording.2023-12-05.at.12.40.36.mov

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

de.mp4

melvin-bot · 2023-12-05T05:50:17Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-12-06T16:38:10Z

src/libs/actions/IOU.js

+                key: `${ONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_TAGS}${iouReport.policyID}`,
+                value: optimisticPolicyRecentlyUsedTags,
+            });
+        }


is there a way to DRY those LOC @DylanDylann?

@hoangzinh We can create new function called createOptimisticPolicyRecentlyUsedTagOrCategory
and update like this

if (_.has(transactionChanges, 'category')) { optimisticData.push(createOptimisticPolicyRecentlyUsedTagOrCategory()); } }

But I don't think It helps to dry code lots. What do you think ?

Hmm, let's leave it as it is. It's not a big problem for me. Let me complete the checklist and wait opinion from Internal engineer.

hoangzinh · 2023-12-08T12:14:41Z

src/libs/actions/IOU.js

+        const optimisticPolicyRecentlyUsedTags = Policy.buildOptimisticPolicyRecentlyUsedTags(iouReport.policyID, transactionChanges.tag);
+        if (!_.isEmpty(optimisticPolicyRecentlyUsedTags)) {
+            optimisticData.push({
+                onyxMethod: Onyx.METHOD.MERGE,


should we use the method "SET" here? For POLICY_RECENTLY_USED_CATEGORIES above, it's using method SET, but here it's using method MERGE. I found it's inconsistency.

@hoangzinh I agree with you at this point. But currently we use MERGE method for tag in other places

App/src/libs/actions/IOU.js

Line 187 in 18d4b9b

onyxMethod: Onyx.METHOD.MERGE,

App/src/libs/actions/IOU.js

Line 1875 in 18d4b9b

onyxMethod: Onyx.METHOD.MERGE,

It looks like MERGE or SET is same if it's an array https://github.com/Expensify/react-native-onyx#should-i-use-merge-or-set-or-both, nvm.

@hoangzinh Do you mean that we should update to use SET in all places ?

I think so, it's stated here

Use set() when you need to completely reset an object or array of data

@hoangzinh Updated

i had this exact question!

The only thing though is that I think these all either need to be SET or all need to MERGE per

For this reason, it is usually preferable to use one or the other, but not both.

And even more fun once you look at buildOptimisticPolicyRecentlyUsedCategories returns an array and buildOptimisticPolicyRecentlyUsedTags returns an object

So I think for calls to set the recently used categories we should use SET everywhere as noted

You should avoid arrays as much as possible. They do not work well with merge() because it can't update a single element in an array, it must always set the entire array each time.

And for recently used tags we should use MERGE everywhere since those are objects.

hoangzinh · 2023-12-09T09:15:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-09.at.21.47.52.-.android.mp4

Android: mWeb Chrome

Screen.Recording.2023-12-09.at.21.51.07.-.android.chrome.mov

iOS: Native

Screen.Recording.2023-12-09.at.21.53.29.-.ios.mp4

iOS: mWeb Safari

Screen.Recording.2023-12-09.at.21.56.05.-.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-09.at.21.40.23.-.web.mov

MacOS: Desktop

Screen.Recording.2023-12-09.at.21.42.33.-.desktop.mp4

bondydaa

I think we need to update OnyxMethods per #32467 (comment)

DylanDylann · 2023-12-13T06:34:17Z

@bondydaa Updated, please help to check again
cc @hoangzinh

DylanDylann · 2023-12-13T16:25:07Z

@hoangzinh Could you help to re-check and approve again? Then @bondydaa will merge this PR

hoangzinh

LGTM

DylanDylann · 2023-12-13T16:37:52Z

@bondydaa Please help to merge this PR when you have a chance. Thanks for all

OSBotify · 2023-12-13T17:33:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-14T16:05:40Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T16:45:28Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T02:01:46Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update recently used tag and categoy when editing request

504eed2

DylanDylann requested a review from a team as a code owner December 5, 2023 05:50

melvin-bot bot requested review from hoangzinh and removed request for a team December 5, 2023 05:50

fix lint

5910285

hoangzinh reviewed Dec 6, 2023

View reviewed changes

hoangzinh reviewed Dec 8, 2023

View reviewed changes

using SET method

60c7027

hoangzinh approved these changes Dec 9, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa December 9, 2023 15:02

bondydaa requested changes Dec 13, 2023

View reviewed changes

update using MERGE method for tag

53dc13a

bondydaa approved these changes Dec 13, 2023

View reviewed changes

hoangzinh approved these changes Dec 13, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa December 13, 2023 16:31

bondydaa merged commit 052c5cc into Expensify:main Dec 13, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 14, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

melvin-bot bot mentioned this pull request Dec 19, 2023

[HOLD for payment 2023-12-26] [$500] Expense-In "recents",category selected while creating expense is displayed instead of altered. #32230

Closed

6 tasks

hoangzinh mentioned this pull request Dec 29, 2023

Allow Viewing/Editing a category on a Money Request #27459

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/32230: Update recently used tag and category when editing request #32467

Fix/32230: Update recently used tag and category when editing request #32467

DylanDylann commented Dec 5, 2023 •

edited

Loading

melvin-bot bot commented Dec 5, 2023

hoangzinh Dec 6, 2023

DylanDylann Dec 7, 2023

hoangzinh Dec 7, 2023

hoangzinh Dec 8, 2023

DylanDylann Dec 8, 2023

hoangzinh Dec 8, 2023

DylanDylann Dec 9, 2023

hoangzinh Dec 9, 2023

DylanDylann Dec 9, 2023

bondydaa Dec 13, 2023

hoangzinh commented Dec 9, 2023 •

edited

Loading

bondydaa left a comment

DylanDylann commented Dec 13, 2023

DylanDylann commented Dec 13, 2023

hoangzinh left a comment

DylanDylann commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

Fix/32230: Update recently used tag and category when editing request #32467

Fix/32230: Update recently used tag and category when editing request #32467

Conversation

DylanDylann commented Dec 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Dec 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

bondydaa left a comment

Choose a reason for hiding this comment

DylanDylann commented Dec 13, 2023

DylanDylann commented Dec 13, 2023

hoangzinh left a comment

Choose a reason for hiding this comment

DylanDylann commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

DylanDylann commented Dec 5, 2023 •

edited

Loading

hoangzinh commented Dec 9, 2023 •

edited

Loading