-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add c3024's device to AdHoc builds provisioning profile #32505
Conversation
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A - Just profile changes Android: mWeb ChromeN/A - Just profile changes iOS: NativeN/A - Just profile changes iOS: mWeb SafariN/A - Just profile changes MacOS: Chrome / SafariN/A - Just profile changes MacOS: DesktopN/A - Just profile changes |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.9-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.9-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
cc @jasperhuangg @AndrewGable @c3024
Details
From https://expensify.slack.com/archives/C02NK2DQWUX/p1701305707703249, adds @c3024's device to the AdHoc builds provisioning profile.
Fixed Issues
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop