Fix: Search term is lost #32542

DylanDylann · 2023-12-06T07:26:21Z

Details

Search Term in WorkspaceMembersPage lost when clicking on Invite

Fixed Issues

$ #22534
PROPOSAL: #22534 (comment)

Tests

Go to settings
Click on workspaces
Click on Members
Search for a string till no results are found
Click on invite to invite this user
The TextInput now in InviteUser page should have the string searched in WorkspaceMembersPage

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to settings
Click on workspaces
Click on Members
Search for a string till no results are found
Click on invite to invite this user
The TextInput now in InviteUser page should have the string searched in WorkspaceMembersPage

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.06-12-2023.17.02.01.webm

Android: mWeb Chrome

Screencast.from.06-12-2023.14.18.04.webm

iOS: Native

iOS: mWeb Safari

Screencast.from.06-12-2023.14.18.04.webm

MacOS: Chrome / Safari

Screencast.from.06-12-2023.14.16.40.webm

MacOS: Desktop

Screencast.from.06-12-2023.16.22.03.webm

melvin-bot · 2023-12-06T10:33:18Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/WorkspaceInvitePage.js

src/pages/workspace/WorkspaceMembersPage.js

aimane-chnaif · 2023-12-06T14:38:32Z

Can we avoid this? This doesn't happen on Members page because it's cleared on cleanup function so inconsistent. Someone will report this as regression

Screen.Recording.2023-12-06.at.3.36.41.PM.mov

DylanDylann · 2023-12-06T14:42:15Z

@aimane-chnaif You mean if a user from any screen (not the workspace member page) goes to the workspace invite page, the input will be cleaned, right?

aimane-chnaif · 2023-12-06T14:42:50Z

@aimane-chnaif You mean if a user from any screen (not the workspace member page) goes to the workspace invite page, the input will be cleaned, right?

right

DylanDylann · 2023-12-06T16:48:30Z

@aimane-chnaif Updated to fix this one #32542 (comment). But after merging the latest main, cannot reproduce it in dev environment because I encounter another bug when pressing on message link https://dev.new.expensify.com:8082/workspace/0179F8F031806C08/invite

aimane-chnaif · 2023-12-06T16:49:56Z

@aimane-chnaif Updated to fix this one #32542 (comment). But after merging the latest main, cannot reproduce it in dev environment because I encounter another bug when pressing on message link https://dev.new.expensify.com:8082/workspace/0179F8F031806C08/invite

yes, it's known. I can test manually

aimane-chnaif · 2023-12-06T17:07:36Z

src/libs/Navigation/AppNavigator/AuthScreens.tsx

@@ -123,6 +124,8 @@ const modalScreenListeners = {
        Modal.setModalVisibility(true);
    },
    beforeRemove: () => {
+        // Clear search input (WorkspaceMembersPage) when modal is closed


WorkspaceInvitePage is more accurate. WorkspaceMemberPage already clears input on useEffect cleanup

aimane-chnaif · 2023-12-06T17:20:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

aimane-chnaif

LGTM 🎉

rlinoz · 2023-12-06T20:03:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aimane-chnaif · 2023-12-06T20:05:35Z

Ah @rlinoz you don't need to fill reviewer checklist as I did already

rlinoz · 2023-12-06T20:06:08Z

Oh I didn't know that, I thought both of us had to, but thanks!

rlinoz · 2023-12-06T20:06:40Z

This feels so much better than before, thanks!

OSBotify · 2023-12-06T20:10:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-06T22:19:13Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T23:13:24Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T01:10:31Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

blazejkustra · 2024-07-29T09:00:14Z

src/pages/workspace/SearchInputManager.js

Comment for reference

fix search term is lost

eb9c843

DylanDylann marked this pull request as ready for review December 6, 2023 10:33

DylanDylann requested a review from a team as a code owner December 6, 2023 10:33

melvin-bot bot requested review from aimane-chnaif and removed request for a team December 6, 2023 10:33

aimane-chnaif reviewed Dec 6, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceMembersPage.js Outdated Show resolved Hide resolved

fix update based on suggestions

f931e04

DylanDylann added 2 commits December 6, 2023 23:34

fix merge main

4a24eb1

fix clear input once rhn closed

7142a45

DylanDylann force-pushed the fix/22534-web-search-term-in-workspacememberpage-lost branch from ccdedbf to 7142a45 Compare December 6, 2023 16:41

aimane-chnaif reviewed Dec 6, 2023

View reviewed changes

aimane-chnaif approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from rlinoz December 6, 2023 17:22

fix update comment

d180ba9

rlinoz approved these changes Dec 6, 2023

View reviewed changes

rlinoz merged commit 395830a into Expensify:main Dec 6, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 6, 2023

Deploy Checklist: New Expensify 2023-12-06 #32589

Closed

74 tasks

aimane-chnaif mentioned this pull request Dec 7, 2023

[HOLD for payment 2023-12-18] [HOLD for payment 2023-12-15] [$125] WS - Email of the newly added user appears in the find member field+all other members disappear #32635

Closed

6 tasks

melvin-bot bot mentioned this pull request Dec 8, 2023

[HOLD for payment 2023-12-15] [$500] Web - Search Term in WorkspaceMembersPage lost when clicking on Invite #22534

Closed

6 tasks

blazejkustra reviewed Jul 29, 2024

View reviewed changes

src/pages/workspace/SearchInputManager.js

Copy link

Contributor

blazejkustra Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for reference

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Search term is lost #32542

Fix: Search term is lost #32542

DylanDylann commented Dec 6, 2023 •

edited

Loading

melvin-bot bot commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

DylanDylann commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

DylanDylann commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

aimane-chnaif Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

aimane-chnaif left a comment

rlinoz commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

rlinoz commented Dec 6, 2023

rlinoz commented Dec 6, 2023 •

edited

Loading

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

blazejkustra Jul 29, 2024

Fix: Search term is lost #32542

Fix: Search term is lost #32542

Conversation

DylanDylann commented Dec 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

DylanDylann commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

DylanDylann commented Dec 6, 2023

aimane-chnaif commented Dec 6, 2023

aimane-chnaif Dec 6, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Dec 6, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

rlinoz commented Dec 6, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif commented Dec 6, 2023

rlinoz commented Dec 6, 2023

rlinoz commented Dec 6, 2023 • edited Loading

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

blazejkustra Jul 29, 2024

Choose a reason for hiding this comment

DylanDylann commented Dec 6, 2023 •

edited

Loading

rlinoz commented Dec 6, 2023 •

edited

Loading