Use set method when creating policy for payment #32959

dukenv0307 · 2023-12-13T08:04:02Z

Details

Use set method when creating policy for payment

Fixed Issues

$ #31836
PROPOSAL: #31836 (comment)

Tests

Create a request money with a user in 1:1 DM
On report preview, click on dropdown button and select Payment with Exensify
Click on the button and choose to pay with business bank account
Verify that not found page will not display briefly

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a request money with a user in 1:1 DM
On report preview, click on dropdown button and select Payment with Exensify
Click on the button and choose to pay with business bank account
Verify that not found page will not display briefly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-13.at.14.48.11.mov

Android: mWeb Chrome

Screen.Recording.2023-12-13.at.14.42.49.mov

iOS: Native

Screen.Recording.2023-12-13.at.14.50.38.mov

iOS: mWeb Safari

Screen.Recording.2023-12-13.at.14.46.04.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-13.at.14.36.34.mov

MacOS: Desktop

Screen.Recording.2023-12-13.at.14.55.43.mov

melvin-bot · 2023-12-13T08:04:16Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-12-21T08:57:13Z

src/libs/actions/Policy.js

@@ -1712,37 +1712,37 @@ function createWorkspaceFromIOUPayment(iouReport) {

    const failureData = [
        {
-            onyxMethod: Onyx.METHOD.MERGE,
+            onyxMethod: Onyx.METHOD.SET,


@dukenv0307, can you please explain why failureData also needs SET?

Based on my understanding of this comment, only optimisticData needs SET. 🤔

@ntdiary This is the same way we do when we create a new workspace.

ntdiary · 2024-01-26T10:47:46Z

Hi, @dukenv0307, could you please resolve conflicts first. And then I can test soon. :)

dukenv0307 · 2024-01-26T10:59:01Z

@ntdiary I updated.

ntdiary · 2024-01-26T15:37:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

32959-android-native.mp4

Android: mWeb Chrome

32959-android-chrome.mp4

iOS: Native

32959-ios-native.mp4

iOS: mWeb Safari

32959-ios-safari.mp4

MacOS: Chrome / Safari

32959-web.mp4

MacOS: Desktop

32959-desktop.mp4

ntdiary

Note: so far, we can only fix the delay issue during navigation through SET method.

BTW, during testing, I encountered an issue where the iouReport object does not have the 'ownerEmail' field, which results in a failed workspace creation, leading to a persistent 'not found' page. However, this is unrelated to this PR. I'm not sure if I'm the only one facing this problem, so it would be great if you could try testing it again, @dukenv0307. :)

App/src/libs/actions/Policy.ts

Line 1625 in 675b2c3

const employeeEmail = iouReport.ownerEmail;

App/src/libs/actions/Policy.ts

Line 1645 in 675b2c3

if (!employeeAccountID || !employeeEmail) {

neil-marcellini

Looks good to me, thanks. Before I merge, @dukenv0307 would you please update the test/QA steps. You can't pay a request unless you owe money to the participant.

Also cc @mountiny if you want to review

mountiny

Thanks Neil! Code looks good to me.

mountiny · 2024-01-29T15:08:13Z

@ntdiary is this issue reproducible everytime? If yes can you please create bug report in expensify-bugs?

ntdiary · 2024-01-29T16:36:18Z

If yes can you please create bug report in expensify-bugs?

Sure, I can test and report it tomorrow. :)

OSBotify · 2024-01-29T16:45:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:23:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

ntdiary · 2024-01-30T12:19:09Z

If yes can you please create bug report in expensify-bugs?

Sure, I can test and report it tomorrow. :)

Just found out there is already a created issue #35366, so marked my message in Slack as a dupe. :)

OSBotify · 2024-01-31T02:30:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

use set method when creating policy for payment

f623dbb

dukenv0307 marked this pull request as ready for review December 13, 2023 08:04

dukenv0307 requested a review from a team as a code owner December 13, 2023 08:04

melvin-bot bot requested review from ntdiary and removed request for a team December 13, 2023 08:04

ntdiary reviewed Dec 21, 2023

View reviewed changes

dukenv0307 added 2 commits January 26, 2024 17:50

Merge branch 'main' into fix/31836

58646bf

use merge for failure data

d122676

ntdiary approved these changes Jan 26, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 26, 2024 15:56

neil-marcellini approved these changes Jan 26, 2024

View reviewed changes

mountiny approved these changes Jan 29, 2024

View reviewed changes

mountiny merged commit b9b0d4d into Expensify:main Jan 29, 2024
17 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

ntdiary mentioned this pull request Jan 30, 2024

[HOLD for payment 2024-02-07] [$500] Chat - "Hmm..page isn't here" briefly displayed after select business account #31836

Closed

6 tasks

kavimuru mentioned this pull request Jan 30, 2024

[$500] Connect BA modal is not displayed when trying to pay with Expensify in DM chat #35366

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use set method when creating policy for payment #32959

Use set method when creating policy for payment #32959

dukenv0307 commented Dec 13, 2023 •

edited

Loading

melvin-bot bot commented Dec 13, 2023

ntdiary Dec 21, 2023 •

edited

Loading

dukenv0307 Dec 21, 2023

ntdiary commented Jan 26, 2024

dukenv0307 commented Jan 26, 2024

ntdiary commented Jan 26, 2024 •

edited

Loading

ntdiary left a comment

neil-marcellini left a comment

mountiny left a comment

mountiny commented Jan 29, 2024

ntdiary commented Jan 29, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

ntdiary commented Jan 30, 2024

OSBotify commented Jan 31, 2024

Use set method when creating policy for payment #32959

Use set method when creating policy for payment #32959

Conversation

dukenv0307 commented Dec 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 13, 2023

ntdiary Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Dec 21, 2023

Choose a reason for hiding this comment

ntdiary commented Jan 26, 2024

dukenv0307 commented Jan 26, 2024

ntdiary commented Jan 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Jan 29, 2024

ntdiary commented Jan 29, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

ntdiary commented Jan 30, 2024

OSBotify commented Jan 31, 2024

dukenv0307 commented Dec 13, 2023 •

edited

Loading

ntdiary Dec 21, 2023 •

edited

Loading

ntdiary commented Jan 26, 2024 •

edited

Loading