-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][HelpDot] Reindex google search on push to main #33335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushatgabhane
changed the title
Reindex google search on push to main
[HelpDot] Reindex google search on push to main
Dec 20, 2023
I don't think this requires a C+ review. LMK if anything is needed from my side |
roryabraham
requested changes
Dec 20, 2023
roryabraham
approved these changes
Dec 22, 2023
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
42 tasks
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.17-0 🚀
|
rushatgabhane
changed the title
[HelpDot] Reindex google search on push to main
[No QA][HelpDot] Reindex google search on push to main
Dec 26, 2023
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @roryabraham
Details
Based on https://developers.google.com/search/docs/crawling-indexing/sitemaps/build-sitemap#addsitemap
Making a GET call to
https://www.google.com/ping?sitemap=https://help.expensify.com/sitemap.xml
should reindex helpdot.The same is done in deployHelpdot action to automate re-indexing on push to
main
Fixed Issues
$ #32825
PROPOSAL: https://expensify.slack.com/archives/C02QSAC6BJ8/p1703003750258269?thread_ts=1702928349.783329&cid=C02QSAC6BJ8
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.