Chat `onStartReached` loader fix #33343

perunt · 2023-12-20T12:02:41Z

The issue is that the loader doesn't have space to appear. When we pull the page, the loader is visible momentarily, but it's immediately hidden by the list. This happens because we removed the containerStyles of the list for mobile. This change was made to fix a bug that arose after upgrading React Native Web


BUG8(from the link below): money request view position is wrong when no messages 

https://github.com/Expensify/App/pull/24482#issuecomment-1688977186

Original PR where this style comes from PR.

Details

Fixed Issues

$
PROPOSAL:

Tests

Please check tests from both linked PRs

Test 1:

On a blank chat, send a message and make sure the message is docked at the bottom of the screen
Add more messages and make sure the bottom-docking is still happening
With a chat that has many, many messages, make sure the container scrolls normally

Test 2. Money request view position is wrong when there are no messages

follow this link: Upgrade to react-native-web v0.19.9 #24482 (comment). Open a video of the bug with the number 8 and follow this video's instructions
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

perunt · 2023-12-20T12:05:18Z

@getusha, by chance, do you remember why you added this style?
tldr: it already passed in the parent component. So it should be safe to remove it
https://github.com/getusha/App/blob/c97ff978ee258af698628b6a4632074dec451ddb/src/pages/home/report/ReportActionsList.js#L361

getusha · 2023-12-20T12:14:06Z

@perunt i am not sure if the style was added later but we experienced an issue on iOS and was resolved by adding it. 96151dc

BUG8: money request view position is wrong when no messages #24482 (comment)

perunt · 2023-12-20T12:50:47Z

hmm, thanks for the info!
it looks like the culprit is flexGrow: 1
I'll make appropriate changes

melvin-bot · 2023-12-20T13:04:43Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam · 2023-12-20T20:49:54Z

@aimane-chnaif Since you reviewed the original PR do you want to be the C+ on this issue?

aimane-chnaif · 2023-12-20T20:51:26Z

@thienlnam sure!

aimane-chnaif · 2023-12-24T17:07:36Z

Please add tests step in Tests / QA section, which is clearly reproducible on main but not on this PR.
There's no GH linked to this PR so QA team will be not sure what to test.

aimane-chnaif · 2023-12-24T17:46:23Z

ok, so the actual changes in the PR are:

remove flexGrow: 1 in web Flatlist's contentContainerStyle (seems redundant)
add paddingBottom: 16 in native FlatList's contentContainerStyle (fix padding ignored issue)

aimane-chnaif · 2023-12-24T17:58:22Z

skeleton appears on top of task view but I have ever noticed this before this PR so I believe the root cause already exists on main so out of scope

aimane-chnaif · 2023-12-24T18:07:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

perunt · 2023-12-28T11:37:17Z

@thienlnam can we merge it?

aimane-chnaif · 2023-12-28T15:26:28Z

@perunt please double confirm #33343 (comment) and do #33343 (comment).
Because of this, I haven't approved yet.

perunt · 2023-12-28T16:15:43Z

ok, so the actual changes in the PR are:
remove flexGrow: 1 in web Flatlist's contentContainerStyle (seems redundant)

right, it always stretches the container even if we have a few items inside.

add paddingBottom: 16 in native FlatList's contentContainerStyle (fix padding ignored issue)

I didn't add any paddings in my PR. What do you mean?

test steps from nested PRs

Test:

On a blank chat, send a message and make sure the message is docked at the bottom of the screen
Add more messages and make sure the bottom-docking is still happening
With a chat that has many, many messages, make sure the container scrolls normally

Money request view position is wrong when there are no messages
Bug with number 8, follow this link: Upgrade to react-native-web v0.19.9 #24482 (comment)

aimane-chnaif · 2023-12-28T16:19:42Z

add paddingBottom: 16 in native FlatList's contentContainerStyle (fix padding ignored issue)

I didn't add any paddings in my PR. What do you mean?

Before:
contentContainerStyle is hardcoded as styles.justifyContentEnd

After:
We're using same style as web (removing flexGrow1) so {justifyContent: 'flex-end', paddingBottom: 16}

So paddingBottom: 16 is the only difference

…idirectional-list-loader-mobile-fix

perunt · 2023-12-30T15:46:55Z

After:
We're using same style as web (removing flexGrow1) so {justifyContent: 'flex-end', paddingBottom: 16}
So paddingBottom: 16 is the only difference

Correct.
I've merged main as this component was migrated to TS

thienlnam · 2024-01-02T19:46:16Z

@perunt When you get a chance, please handle #33343 (comment)

perunt · 2024-01-03T14:00:10Z

@perunt When you get a chance, please handle #33343 (comment)

I added them here #33343 (comment)
will duplicate it in the header as well

thienlnam · 2024-01-03T22:19:16Z

You may have to merge main to fix the typescript checks, I'm not sure why it's erroring on your build but I asked here

…idirectional-list-loader-mobile-fix

perunt · 2024-01-04T08:28:17Z

Thanks for pointing it up
Done

OSBotify · 2024-01-04T19:14:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:36:36Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-10T06:03:51Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

aimane-chnaif · 2024-01-14T17:37:22Z

@thienlnam can you please create GH for payment? Thanks

aimane-chnaif · 2024-03-18T12:50:20Z

@thienlnam can you please create GH for payment? Thanks

bump ^

perunt added 2 commits December 20, 2023 13:00

clean contentContainerStyle from web component

eb11948

clean contentContainerStyle from mobile component

2571f83

perunt changed the title ~~Chat inStartReached loader fix~~ Chat onStartReached loader fix Dec 20, 2023

perunt marked this pull request as ready for review December 20, 2023 13:04

perunt requested a review from a team as a code owner December 20, 2023 13:04

melvin-bot bot requested review from thienlnam and removed request for a team December 20, 2023 13:04

remove flexGrow

d9e3111

thienlnam requested a review from aimane-chnaif December 20, 2023 21:03

perunt added 2 commits December 30, 2023 16:42

Merge branch 'main' of https://github.com/Expensify/App into perunt/b…

fc0c4b5

…idirectional-list-loader-mobile-fix

fix after merge

e0a591e

thienlnam previously approved these changes Jan 3, 2024

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into perunt/b…

6247ae8

…idirectional-list-loader-mobile-fix

perunt dismissed thienlnam’s stale review via 6247ae8 January 4, 2024 08:26

thienlnam approved these changes Jan 4, 2024

View reviewed changes

thienlnam merged commit 5b0ceb2 into Expensify:main Jan 4, 2024
16 checks passed

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

thienlnam mentioned this pull request Mar 20, 2024

[$500] Payment for PR #33343 #38695

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chat `onStartReached` loader fix #33343

Chat `onStartReached` loader fix #33343

perunt commented Dec 20, 2023 •

edited

Loading

perunt commented Dec 20, 2023

getusha commented Dec 20, 2023

perunt commented Dec 20, 2023

melvin-bot bot commented Dec 20, 2023

thienlnam commented Dec 20, 2023

aimane-chnaif commented Dec 20, 2023

aimane-chnaif commented Dec 24, 2023

aimane-chnaif commented Dec 24, 2023

aimane-chnaif commented Dec 24, 2023 •

edited

Loading

aimane-chnaif commented Dec 24, 2023

perunt commented Dec 28, 2023

aimane-chnaif commented Dec 28, 2023 •

edited

Loading

perunt commented Dec 28, 2023

aimane-chnaif commented Dec 28, 2023

perunt commented Dec 30, 2023

thienlnam commented Jan 2, 2024

perunt commented Jan 3, 2024

thienlnam commented Jan 3, 2024

perunt commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

aimane-chnaif commented Jan 14, 2024

aimane-chnaif commented Mar 18, 2024

Chat onStartReached loader fix #33343

Chat onStartReached loader fix #33343

Conversation

perunt commented Dec 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

perunt commented Dec 20, 2023

getusha commented Dec 20, 2023

perunt commented Dec 20, 2023

melvin-bot bot commented Dec 20, 2023

thienlnam commented Dec 20, 2023

aimane-chnaif commented Dec 20, 2023

aimane-chnaif commented Dec 24, 2023

aimane-chnaif commented Dec 24, 2023

aimane-chnaif commented Dec 24, 2023 • edited Loading

aimane-chnaif commented Dec 24, 2023

Reviewer Checklist

Screenshots/Videos

perunt commented Dec 28, 2023

aimane-chnaif commented Dec 28, 2023 • edited Loading

perunt commented Dec 28, 2023

aimane-chnaif commented Dec 28, 2023

perunt commented Dec 30, 2023

thienlnam commented Jan 2, 2024

perunt commented Jan 3, 2024

thienlnam commented Jan 3, 2024

perunt commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

aimane-chnaif commented Jan 14, 2024

aimane-chnaif commented Mar 18, 2024

Chat `onStartReached` loader fix #33343

Chat `onStartReached` loader fix #33343

perunt commented Dec 20, 2023 •

edited

Loading

aimane-chnaif commented Dec 24, 2023 •

edited

Loading

aimane-chnaif commented Dec 28, 2023 •

edited

Loading