[TS migration] Migrate 'StatePicker' component to TypeScript #33352

VickyStash · 2023-12-20T12:58:39Z

Details

[TS migration] Migrate 'StatePicker' component to TypeScript

Fixed Issues

$ #25112
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Steps for every State Picker to test:

Make sure State Picker looks as expected.
Open it and make sure the list of States looks as expected.
Select any State (tap on it) -> make sure value in State Picket was updated.
Open it again and make sure the previously selected State is marked as selected.
Search for any other State, make sure the search works as expected.
Select any other State and make sure the selected State is updated.

Places to test State Picker:

1. Personal Details -> Address:

Open Settings -> Profile -> Personal Details
Select Address
Select Country -> United States, after that State input will turn into a picker.
Test State Picker using the steps above.

2. Bank Account -> Debit Card:

Open Settings -> Wallet
Tap Add Bank Account -> Debit Card
Test State Picker using the steps above.

3. Workspace Bank Account -> manual:

Open Settings -> Workspaces
Open Workspace without Bank Account
Go to Bank Account -> tap on Connect manually
Enter routing number/account number (ex: 067014822/1234) and press Continue
Test State Picker using the steps above.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

melvin-bot · 2023-12-20T12:58:43Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

src/components/StatePicker/StateSelectorModal.tsx

kubabutkiewicz

just a nit, lgtm 😄

BartoszGrajdek

LGTM! 😄

# Conflicts: # src/components/MenuItem.tsx

melvin-bot · 2023-12-27T09:10:20Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2024-01-02T08:19:04Z

@jjcoffee kind bump 🙂

jjcoffee · 2024-01-02T13:09:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-01-02_16.23.08.mp4

Android: mWeb Chrome

android-chrome-2024-01-02_14.21.50.mp4

iOS: Native

ios-native-2024-01-02_17.23.02.mp4

iOS: mWeb Safari

ios-safari-2024-01-02_14.36.47.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-01-02_14.16.38.mp4

MacOS: Desktop

desktop-app-2024-01-02_16.34.14.mp4

jjcoffee

LGTM!

melvin-bot · 2024-01-02T16:25:46Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25112 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

jjcoffee · 2024-01-09T09:02:28Z

@grgia Just noticed you got assigned to the issue but not here for some reason. Could you give this a review?

# Conflicts: # src/components/StatePicker/index.tsx

VickyStash · 2024-01-12T10:43:15Z

@grgia kind bump 🙂

VickyStash · 2024-01-15T13:21:59Z

@grgia Could you please take a look at this PR

grgia · 2024-01-16T23:53:10Z

src/components/StatePicker/StateSelectorModal.tsx

@@ -88,13 +82,14 @@ function StateSelectorModal({currentState, isVisible, onClose, onStateSelected,
                testID={StateSelectorModal.displayName}
            >
                <HeaderWithBackButton
-                    title={label || translate('common.state')}
+                    title={label ?? translate('common.state')}


if label is an empty string '' then this will return '', could you confirm if that case will cause a problem here?

I agree it will be more safe to use logical OR in this case, so updated it

grgia

Before merging, let's confirm that we are defaulting the label prop correctly. Thoughts? cc @jjcoffee

jjcoffee · 2024-01-17T09:48:39Z

Ah good catch! Yeah I agree it's better with the logical OR as I can't think of a reason we'd want to have an empty string as the label 😄

VickyStash · 2024-01-22T09:27:28Z

@grgia kind bump 🙂

mountiny

Thanks!

OSBotify · 2024-01-25T11:30:42Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.32-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-29T19:06:16Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'StatePicker' component

0b55bfe

Use nullish coalescing operator

6c9c06f

kubabutkiewicz reviewed Dec 20, 2023

View reviewed changes

src/components/StatePicker/StateSelectorModal.tsx Outdated Show resolved Hide resolved

kubabutkiewicz approved these changes Dec 20, 2023

View reviewed changes

Minor code improvement

9f5666e

BartoszGrajdek approved these changes Dec 22, 2023

View reviewed changes

Merge branch 'main' into ts-migration/statePicker-component

8e256b8

# Conflicts: # src/components/MenuItem.tsx

VickyStash marked this pull request as ready for review December 27, 2023 09:10

VickyStash requested a review from a team as a code owner December 27, 2023 09:10

melvin-bot bot requested review from jjcoffee and removed request for a team December 27, 2023 09:10

Merge branch 'main' into ts-migration/statePicker-component

f5413c5

jjcoffee approved these changes Jan 2, 2024

View reviewed changes

VickyStash added 3 commits January 4, 2024 10:13

Merge branch 'main' into ts-migration/statePicker-component

64a8131

Fix lint errors

43a77af

Merge branch 'main' into ts-migration/statePicker-component

46af5a2

VickyStash added 2 commits January 9, 2024 12:37

Merge branch 'main' into ts-migration/statePicker-component

6082d43

# Conflicts: # src/components/StatePicker/index.tsx

Merge branch 'main' into ts-migration/statePicker-component

ebcaeb5

Merge branch 'main' into ts-migration/statePicker-component

40c4f0f

jjcoffee approved these changes Jan 15, 2024

View reviewed changes

melvin-bot bot requested a review from grgia January 15, 2024 13:23

grgia reviewed Jan 16, 2024

View reviewed changes

Use logical or since label can be an empty string

089c626

Merge branch 'main' into ts-migration/statePicker-component

d9c4f2d

VickyStash added 4 commits January 24, 2024 10:04

Merge branch 'main' into ts-migration/statePicker-component

39e9614

Replace nullish coalescing with logical or

2ff79c0

Merge branch 'main' into ts-migration/statePicker-component

8eb8965

Remove outdated TODO

7617114

mountiny assigned VickyStash Jan 25, 2024

mountiny approved these changes Jan 25, 2024

View reviewed changes

mountiny merged commit b4acfb6 into Expensify:main Jan 25, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 25, 2024

Deploy Checklist: New Expensify 2024-01-25 #35138

Closed

48 tasks

melvin-bot bot mentioned this pull request Jan 29, 2024

[HOLD for payment 2024-02-05] [$250] [TS migration] Migrate 'StatePicker' component to TypeScript #25112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'StatePicker' component to TypeScript #33352

[TS migration] Migrate 'StatePicker' component to TypeScript #33352

VickyStash commented Dec 20, 2023 •

edited

Loading

melvin-bot bot commented Dec 20, 2023

kubabutkiewicz left a comment

BartoszGrajdek left a comment

melvin-bot bot commented Dec 27, 2023

VickyStash commented Jan 2, 2024

jjcoffee commented Jan 2, 2024 •

edited

Loading

jjcoffee left a comment

melvin-bot bot commented Jan 2, 2024

jjcoffee commented Jan 9, 2024

VickyStash commented Jan 12, 2024

VickyStash commented Jan 15, 2024

grgia Jan 16, 2024

VickyStash Jan 17, 2024

grgia left a comment

jjcoffee commented Jan 17, 2024

VickyStash commented Jan 22, 2024

mountiny left a comment

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

[TS migration] Migrate 'StatePicker' component to TypeScript #33352

[TS migration] Migrate 'StatePicker' component to TypeScript #33352

Conversation

VickyStash commented Dec 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 20, 2023

kubabutkiewicz left a comment

Choose a reason for hiding this comment

BartoszGrajdek left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 27, 2023

VickyStash commented Jan 2, 2024

jjcoffee commented Jan 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 2, 2024

jjcoffee commented Jan 9, 2024

VickyStash commented Jan 12, 2024

VickyStash commented Jan 15, 2024

grgia Jan 16, 2024

Choose a reason for hiding this comment

VickyStash Jan 17, 2024

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

jjcoffee commented Jan 17, 2024

VickyStash commented Jan 22, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

VickyStash commented Dec 20, 2023 •

edited

Loading

jjcoffee commented Jan 2, 2024 •

edited

Loading