-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit box with parent message not focused. #33365
fix: edit box with parent message not focused. #33365
Conversation
Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This should be Expected Result @Krishna2323 I am not able to see it without scrolling ios.mov |
…a2323/issue/30805
@Krishna2323 any update? |
@aimane-chnaif, I'm sorry about this, I totally forgot and have been traveling since last week. I will finish this by tomorrow. |
@aimane-chnaif, I need sometime to solve the issue, because it only happens in IOS and its different from our issue. In android the solutions works fine. I think its related to Android: edit_input_focused_android.mp4 |
yes, it's different root cause. It's ideal to fix this in this PR but if you think that takes much efforts, I'd consider out of scope. |
I already spent many hours to find a solution but couldn't find any. I'm interested in investing more hours in this but I think the bounty should be increased then. |
@aldo-expensify bump for #33365 (comment) |
Thanks for the bump, I had forgotten to look into it. I think the original issue is not important enough to want to increase the bounty and spent more time on it. I'm saying it is not important because:
Lets just proceed with what we have. |
@Krishna2323 please fix author checklist failing |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
All checks pass |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.25-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀
|
Details
Fixed Issues
$ #30805
PROPOSAL: #30805 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4