[No QA] introducing useResponsiveLayout hook #33425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getusha
reviewed
Dec 29, 2023
Comment on lines
+16
to
+18
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const {params} = useRoute<RouteProp<RouteParams, 'params'>>(); | ||
| return {shouldUseNarrowLayout: isSmallScreenWidth || (params?.isInRHP ?? false)}; |
There was a problem hiding this comment.
This still feels like a bad practice, should we instead pass the params as a prop and use it?
What do you think @roryabraham
There was a problem hiding this comment.
This looks ok to me. It's a bit weird but better than the alternative of having to use useRoute and pass a prop every time useResponsiveLayout needs to be used. Plus if we gave isInRHP a default value, then it would be easy to forget to pass it when it might be different than the default.
So I think this implementation looks good
roryabraham
approved these changes
Dec 29, 2023
Comment on lines
+16
to
+18
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const {params} = useRoute<RouteProp<RouteParams, 'params'>>(); | ||
| return {shouldUseNarrowLayout: isSmallScreenWidth || (params?.isInRHP ?? false)}; |
There was a problem hiding this comment.
This looks ok to me. It's a bit weird but better than the alternative of having to use useRoute and pass a prop every time useResponsiveLayout needs to be used. Plus if we gave isInRHP a default value, then it would be easy to forget to pass it when it might be different than the default.
So I think this implementation looks good
rayane-djouah
changed the title
getusha
reviewed
Dec 29, 2023
Comment on lines
+20
to
+22
| return { | ||
| shouldUseNarrowLayout: isSmallScreenWidth, | ||
| }; |
There was a problem hiding this comment.
NAB
Suggested change
| return { | |
| shouldUseNarrowLayout: isSmallScreenWidth, | |
| }; | |
| return {shouldUseNarrowLayout: isSmallScreenWidth}; |
Comment on lines
+17
to
+18
| const {params} = useRoute<RouteProp<RouteParams, 'params'>>(); | ||
| return {shouldUseNarrowLayout: isSmallScreenWidth || (params?.isInRHP ?? false)}; |
There was a problem hiding this comment.
Suggested change
| const {params} = useRoute<RouteProp<RouteParams, 'params'>>(); | |
| return {shouldUseNarrowLayout: isSmallScreenWidth || (params?.isInRHP ?? false)}; | |
| // eslint-disable-next-line react-hooks/rules-of-hooks | |
| const {params} = useRoute<RouteProp<RouteParams, 'params'>>(); | |
| const isInRHP = params?.isInRHP ?? false; | |
| const shouldUseNarrowLayout = isSmallScreenWidth || isInRHP; | |
| return {shouldUseNarrowLayout}; |
roryabraham
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Not that I disagree with your comments @getusha, but given that they are pretty minor code style concerns, and there's nothing really to test here, I am going to proceed with merging this PR to keep the ball rolling – there's a lot more PRs still to come so let's be done with this one
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
58 tasks
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Breaking down #31476 into several PRs as explained here
Fixed Issues
$ #30528
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A
MacOS: Desktop
N/A