Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu auto close #3363

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Menu auto close #3363

merged 4 commits into from
Jun 8, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 4, 2021 •
edited
Loading

Details

  1. Added a delay of 800ms to auto-close the menu for Mark as Unread, Copy to Clipboard ContextMenu actions.
  2. Menu closes on Edit Comment action.
  3. Menu closes when we either confirm or cancel the Delete Comment action via Confirm Modal.

Fixed Issues

Fixes #3187

Tests

  1. Open any chat.
  2. Send a message.
  3. Wait for few minutes, then right-click over the Chat message.
  4. Click Copy to clipboard, Menu should close after some time automatically.
  5. Right-click over the message, then select mark unread. The menu should close after some time automatically.

QA Steps (Web/Desktop)

  1. Open E.cash on the web.
  2. Open any existing chat.
  3. Send a new message.
  4. Wait for few seconds.
  5. Now Right-click on the message. On the Context menu, select either Copy to Clipboard or Mark as Unread.
  6. Menu should close after a small delay.

QA Steps (M-Web/Android/IOS)

  1. Open E.cash on the web.
  2. Open any existing chat.
  3. Send a new message.
  4. Wait for few seconds.
  5. Hold Press on the message. On the Context menu, select either Copy to Clipboard or Mark as Unread.
  6. Menu should close after a small delay.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

menu-w.mp4

Desktop

picker-d.mp4

Mobile Web

1623093534388.mp4

iOS

picker-ios.mp4

Android

1622857105728.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner June 4, 2021 03:43
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team June 4, 2021 03:43
@parasharrajat parasharrajat changed the title [WIP] Menu auto close Menu auto close Jun 5, 2021
NikkiWines
NikkiWines requested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I know this issue only occurred on web/desktop app, but can you add videos for mWeb and iOS, as well as the remaining one for web or desktop (not sure which platform the current video is for since they're under the same heading)

@parasharrajat
Copy link
Member Author

@NikkiWines Updated. Thanks

NikkiWines
NikkiWines requested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, with only a couple of very minor comments.

@parasharrajat
Copy link
Member Author

@NikkiWines Updated. Thanks

NikkiWines
NikkiWines approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@parasharrajat
Copy link
Member Author

parasharrajat commented Jun 8, 2021 •
edited
Loading

:shipit: It's a blocker for one of the issues.

@NikkiWines NikkiWines merged commit c6041ae into Expensify:main Jun 8, 2021
@OSBotify OSBotify mentioned this pull request Jun 8, 2021
Closed
9 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to staging in version: 1.0.64-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to production in version: 1.0.65-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report action menu - Menu is not dismissed after performing an action
3 participants
@parasharrajat @OSBotify @NikkiWines