[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804

FitseTLT · 2023-12-30T19:39:53Z

Details

Lines 35 to 36 in bc80ac1

    
           const thumbnailSource = tryResolveUrlFromApiRoot((thumbnail as string) || ''); 
        
           const waypoints = useMemo(() => transaction?.comment?.waypoints ?? {}, [transaction?.comment?.waypoints]);

thumbnail that is returned from ReceiptUtils.getThumbnailAndImageURIs can be a string or ImageSourePropType but tryResolveUrlFromApiRoot only takes a string I have just employed as to bypass typescript error.

I have removed the fill prop here as textBrand doesn't exist in the theme it seems some obsolete code maybe 😕

App/src/components/DistanceEReceipt.js

Lines 113 to 114 in 7d1b0f8

fill={theme.textBrand}

src={Expensicons.ExpensifyWordmark}

Fixed Issues

$ #31964

Tests

open a distance details page
click on the receipt displayed on top to open Distance E-Receipt modal to open
Verify that it displays correctly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2023-12-30T19:39:58Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/DistanceEReceipt.tsx

VickyStash · 2024-01-02T10:56:07Z

Please update PR name to follow the issue name:
[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript

src/components/DistanceEReceipt.tsx

FitseTLT · 2024-01-25T12:26:57Z

@shubham1206agra bump

blazejkustra · 2024-01-25T15:32:08Z

Please sync this branch with the newest main. Context here, thanks!

FitseTLT · 2024-01-25T15:34:19Z

Thanks! Done 👍

shubham1206agra · 2024-02-01T18:53:33Z

@FitseTLT Please fix conflicts here.

FitseTLT · 2024-02-01T19:08:53Z

Conflict resolved!

blazejkustra · 2024-02-06T09:46:07Z

@FitseTLT @shubham1206agra Please let's move forward with this PR, it is over one month now 😅

shubham1206agra · 2024-02-06T10:17:01Z

I will do the review today.

shubham1206agra · 2024-02-07T11:03:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

FitseTLT · 2024-02-08T20:24:41Z

bump @grgia

grgia

code LGTM, quick question before I merge

grgia · 2024-02-09T00:28:13Z

src/components/DistanceEReceipt.tsx

        () =>
            // The waypoint keys are sometimes out of order
-            _.chain(waypoints)
-                .keys()
+            Object.keys(waypoints)


Does this work the same as _.chain()?

blazejkustra · 2024-02-12T13:09:25Z

@FitseTLT Let's merge the newest main, and we can proceed with a merge @grgia 😄

FitseTLT · 2024-02-12T18:33:24Z

Merged with latest main and tested. We can proceed!

FitseTLT · 2024-02-13T19:16:21Z

bump @grgia

grgia · 2024-02-15T16:09:35Z

Thank you @FitseTLT !

OSBotify · 2024-02-15T16:14:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:46:34Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:52:38Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

migrated DistanceEReceipt to typescript

bc80ac1

FitseTLT requested a review from a team as a code owner December 30, 2023 19:39

melvin-bot bot removed the request for review from a team December 30, 2023 19:39

melvin-bot bot requested a review from shubham1206agra December 30, 2023 19:39

Merge branch 'main' into DistanceEReceipt-ts-migration

60790aa

shubham1206agra reviewed Dec 31, 2023

View reviewed changes

src/components/DistanceEReceipt.tsx Outdated Show resolved Hide resolved

removed lodash functions

689c227

VickyStash reviewed Jan 2, 2024

View reviewed changes

src/components/DistanceEReceipt.tsx Outdated Show resolved Hide resolved

src/components/DistanceEReceipt.tsx Outdated Show resolved Hide resolved

blazejkustra suggested changes Jan 2, 2024

View reviewed changes

src/components/DistanceEReceipt.tsx Show resolved Hide resolved

src/components/DistanceEReceipt.tsx Outdated Show resolved Hide resolved

src/components/DistanceEReceipt.tsx Show resolved Hide resolved

FitseTLT changed the title ~~migrated DistanceEReceipt to typescript~~ [TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript Jan 2, 2024

FitseTLT added 2 commits January 3, 2024 22:30

fixed based on comments

a799adf

Merge branch 'main' into DistanceEReceipt-ts-migration

ce54973

FitseTLT requested review from blazejkustra and shubham1206agra January 20, 2024 21:00

FitseTLT added 2 commits January 21, 2024 00:04

fix type import

7cc41ce

Merge branch 'main' into DistanceEReceipt-ts-migration

04e9edb

blazejkustra approved these changes Jan 24, 2024

View reviewed changes

Merge branch 'main' into DistanceEReceipt-ts-migration

0d3921b

conflict resolved

cdd2680

Merge branch 'main' into DistanceEReceipt-ts-migration

1974321

shubham1206agra approved these changes Feb 7, 2024

View reviewed changes

melvin-bot bot requested a review from grgia February 7, 2024 11:03

resolved conflict

04544c2

grgia approved these changes Feb 9, 2024

View reviewed changes

Merge branch 'main' into DistanceEReceipt-ts-migration

94660d4

grgia merged commit 50e07e8 into Expensify:main Feb 15, 2024
14 checks passed

github-actions bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804

[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804

FitseTLT commented Dec 30, 2023 •

edited

Loading

melvin-bot bot commented Dec 30, 2023

VickyStash commented Jan 2, 2024

FitseTLT commented Jan 25, 2024

blazejkustra commented Jan 25, 2024

FitseTLT commented Jan 25, 2024

shubham1206agra commented Feb 1, 2024

FitseTLT commented Feb 1, 2024

blazejkustra commented Feb 6, 2024

shubham1206agra commented Feb 6, 2024

shubham1206agra commented Feb 7, 2024

FitseTLT commented Feb 8, 2024

grgia left a comment

grgia Feb 9, 2024

FitseTLT Feb 9, 2024

blazejkustra commented Feb 12, 2024

FitseTLT commented Feb 12, 2024

FitseTLT commented Feb 13, 2024

grgia commented Feb 15, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

	const thumbnailSource = tryResolveUrlFromApiRoot((thumbnail as string) \|\| '');
	const waypoints = useMemo(() => transaction?.comment?.waypoints ?? {}, [transaction?.comment?.waypoints]);

	fill={theme.textBrand}
	src={Expensicons.ExpensifyWordmark}

[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804

[TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804

Conversation

FitseTLT commented Dec 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 30, 2023

VickyStash commented Jan 2, 2024

FitseTLT commented Jan 25, 2024

blazejkustra commented Jan 25, 2024

FitseTLT commented Jan 25, 2024

shubham1206agra commented Feb 1, 2024

FitseTLT commented Feb 1, 2024

blazejkustra commented Feb 6, 2024

shubham1206agra commented Feb 6, 2024

shubham1206agra commented Feb 7, 2024

Reviewer Checklist

Screenshots/Videos

FitseTLT commented Feb 8, 2024

grgia left a comment

Choose a reason for hiding this comment

grgia Feb 9, 2024

Choose a reason for hiding this comment

FitseTLT Feb 9, 2024

Choose a reason for hiding this comment

blazejkustra commented Feb 12, 2024

FitseTLT commented Feb 12, 2024

FitseTLT commented Feb 13, 2024

grgia commented Feb 15, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

FitseTLT commented Dec 30, 2023 •

edited

Loading