[TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958

ishpaul777 · 2024-01-04T15:06:53Z

Details

TS migration for ReportActionItemFragment.js

Fixed Issues

$ #31977
PROPOSAL: #31977 (comment)

Tests

Verify that no errors appear in the JS console

Login to the app
Open any report
Verify that report actions are displayed correctly (as before)
Send different types of messages Attachements/ text messages/ mentions etc. Make sure everything works as expected (as before)

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

VIDEO-2023-12-20-18-23-58.mp4

Android: mWeb Chrome

VIDEO-2023-12-19-19-05-08.mp4

iOS: Native

Screen.Recording.2024-01-09.at.8.52.56.PM-1.mov

iOS: mWeb Safari

RPReplay_Final1702992220.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-09.at.8.23.29.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-11.at.12.05.01.AM-1.mov

src/pages/home/report/ReportActionItemFragment.tsx

ishpaul777 · 2024-01-04T15:18:16Z

src/pages/home/report/ReportActionItemSingle.tsx

@@ -256,7 +256,7 @@ function ReportActionItemSingle({
                                <ReportActionItemFragment
                                    // eslint-disable-next-line react/no-array-index-key
                                    key={`person-${action.reportActionID}-${index}`}
-                                    accountID={actorAccountID}
+                                    accountID={actorAccountID ?? 0}
                                    fragment={fragment}


this is inferred as Person type

I think it's safe to change Person type to:

type Person = { type: string; style?: string; text: string; };

Got a bunch of type error when type is chnaged, used this as workaround:

fragment={{...fragment, type: fragment.type ?? '', text: fragment.text ?? ''}}

src/pages/home/report/ReportActionItemSingle.tsx

ishpaul777 · 2024-01-04T15:44:34Z

@blazejkustra I Have some type checks failing, i would appreciate guidance! Thanks!

blazejkustra · 2024-01-04T15:45:38Z

I'll leave comments tomorrow morning as I'm finishing for today, sorry!

src/components/InvertedFlatList/CellRendererComponent.tsx

src/pages/home/report/ReportActionItemFragment.tsx

src/pages/home/report/comment/TextCommentFragment.tsx

src/pages/home/report/ReportActionItemMessage.tsx

blazejkustra · 2024-01-05T08:36:02Z

src/pages/home/report/ReportActionItemSingle.tsx

@@ -256,7 +256,7 @@ function ReportActionItemSingle({
                                <ReportActionItemFragment
                                    // eslint-disable-next-line react/no-array-index-key
                                    key={`person-${action.reportActionID}-${index}`}
-                                    accountID={actorAccountID}
+                                    accountID={actorAccountID ?? 0}
                                    fragment={fragment}


I think it's safe to change Person type to:

type Person = { type: string; style?: string; text: string; };

src/pages/home/report/ReportActionItemSingle.tsx

blazejkustra · 2024-01-05T10:55:49Z

Also a kind request, link issue in PR description and change PR title so it reflects issue title: [TS migration] Migrate 'X.js' component to TypeScript

ishpaul777 · 2024-01-05T17:11:44Z

Thank you, @blazejkustra, for the suggestions. I appreciate your input, and I'll address them as soon as possible. I was occupied with personal errands all day today, so I apologize for the delayed response.

src/pages/home/report/ReportActionItemMessage.tsx

blazejkustra · 2024-01-08T10:08:36Z

@ishpaul777 Typecheck is failing

blazejkustra · 2024-01-08T10:17:57Z

Also a kind request, link issue in PR description and change PR title so it reflects issue title: [TS migration] Migrate 'X.js' component to TypeScript

bump 😄

blazejkustra · 2024-01-10T16:58:13Z

FYI Lint is failing

ishpaul777 · 2024-01-10T18:13:37Z

Thanks for callout.. it should be fixed now!

blazejkustra · 2024-01-16T14:34:44Z

@ishpaul777 Let's push it forward, we need a C+ on this

ishpaul777 · 2024-01-16T14:36:15Z

@eVoloshchak is assigned c+ here but might be unavailable, i'll ping on slack channel

ishpaul777 · 2024-01-16T14:37:05Z

Okay i think automation failed no c+ assigned

aldo-expensify · 2024-01-16T21:38:29Z

Reassigned to @situchan as C+
Assigned @jasperhuangg as reviewer since he is the assigned engineer in the issue

aldo-expensify · 2024-01-16T21:39:11Z

@ishpaul777 you got some conflicts now

src/pages/home/report/comment/TextCommentFragment.tsx

jasperhuangg

Looks pretty good, let's fix those conflicts!

ishpaul777 · 2024-01-23T22:55:50Z

@situchan A gentle bump to complete checklist so we can push it forward..

situchan · 2024-01-25T02:40:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ishpaul777 please merge main since 1k+ commits are behind

blazejkustra · 2024-01-25T15:32:03Z

Please sync this branch with the newest main. Context here, thanks!

OSBotify · 2024-01-25T18:17:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

src/pages/home/report/ReportActionItemMessage.tsx

OSBotify · 2024-01-29T19:23:51Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T02:30:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ishpaul777 added 2 commits January 4, 2024 20:33

migration v1

19ea935

clean up

3e83b44

ishpaul777 commented Jan 4, 2024

View reviewed changes

src/pages/home/report/ReportActionItemFragment.tsx Outdated Show resolved Hide resolved

ishpaul777 mentioned this pull request Jan 4, 2024

[TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript #33552

Merged

52 tasks

ishpaul777 commented Jan 4, 2024

View reviewed changes

Merge branch 'main' into ts-migration/ReportActionItemFragment

41b8d91

ishpaul777 changed the title ~~Ts migration/report action item fragment~~ Ts migration/reportActionFtemFragment Jan 4, 2024

ishpaul777 added 3 commits January 4, 2024 21:00

lint fix

073187e

lint fix

3d74ec8

type fix

ad6fe37

ishpaul777 commented Jan 4, 2024

View reviewed changes

src/pages/home/report/ReportActionItemSingle.tsx Show resolved Hide resolved

fix lint

1f979ee

blazejkustra suggested changes Jan 5, 2024

View reviewed changes

ishpaul777 added 2 commits January 6, 2024 08:48

adding requested chnages

2fd6c4e

lint fix

4f6b75b

ishpaul777 changed the title ~~Ts migration/reportActionFtemFragment~~ [TS migration] Migrate 'ReportActionItemFragment.js' Jan 6, 2024

clean up

c41ebb3

ishpaul777 commented Jan 6, 2024

View reviewed changes

src/pages/home/report/ReportActionItemMessage.tsx Show resolved Hide resolved

ishpaul777 added 2 commits January 6, 2024 09:29

fix unrelated type errors

9aeaff0

fix lint

0bc89aa

ishpaul777 changed the title ~~[TS migration] Migrate 'ReportActionItemFragment.js'~~ [TS migration] Migrate 'ReportActionItemFragment.js' component to TypeScript Jan 8, 2024

ishpaul777 changed the title ~~[TS migration] Migrate 'ReportActionItemFragment.js' component to TypeScript~~ [TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript Jan 8, 2024

ishpaul777 added 2 commits January 8, 2024 15:53

fix type errors

e1a546f

fix broken test case

2e69271

prettier diffs

4edfd16

ishpaul777 mentioned this pull request Jan 16, 2024

[Paid] [$250] [TS migration] Migrate 'ReportActionItemFragment' component to TypeScript #31977

Closed

Merge branch 'main' into ts-migration/ReportActionItemFragment

c030913

aldo-expensify requested review from situchan and jasperhuangg January 16, 2024 21:37

jasperhuangg reviewed Jan 17, 2024

View reviewed changes

src/pages/home/report/comment/TextCommentFragment.tsx Outdated Show resolved Hide resolved

jasperhuangg reviewed Jan 17, 2024

View reviewed changes

ishpaul777 and others added 2 commits January 17, 2024 23:00

Merge branch 'main' into ts-migration/ReportActionItemFragment

aa164ca

added requested changes

a58be47

jasperhuangg approved these changes Jan 22, 2024

View reviewed changes

Merge branch 'Expensify:main' into ts-migration/ReportActionItemFragment

92d16b7

Merge branch 'Expensify:main' into ts-migration/ReportActionItemFragment

91f48f1

jasperhuangg merged commit f8e2136 into Expensify:main Jan 25, 2024
14 checks passed

situchan reviewed Jan 25, 2024

View reviewed changes

src/pages/home/report/ReportActionItemMessage.tsx Show resolved Hide resolved

ishpaul777 mentioned this pull request Jan 25, 2024

fixes typescript mistake with type assertion in ReportActionItemMessage #35204

Merged

50 tasks

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958

[TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958

ishpaul777 commented Jan 4, 2024 •

edited

Loading

ishpaul777 Jan 4, 2024

blazejkustra Jan 5, 2024

ishpaul777 Jan 6, 2024

ishpaul777 commented Jan 4, 2024 •

edited

Loading

blazejkustra commented Jan 4, 2024

blazejkustra Jan 5, 2024

blazejkustra commented Jan 5, 2024

ishpaul777 commented Jan 5, 2024

blazejkustra commented Jan 8, 2024

blazejkustra commented Jan 8, 2024

blazejkustra commented Jan 10, 2024

ishpaul777 commented Jan 10, 2024

blazejkustra commented Jan 16, 2024

ishpaul777 commented Jan 16, 2024

ishpaul777 commented Jan 16, 2024

aldo-expensify commented Jan 16, 2024

aldo-expensify commented Jan 16, 2024

jasperhuangg left a comment

ishpaul777 commented Jan 23, 2024 •

edited

Loading

situchan commented Jan 25, 2024 •

edited

Loading

blazejkustra commented Jan 25, 2024

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

[TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958

[TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958

Conversation

ishpaul777 commented Jan 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 Jan 4, 2024

Choose a reason for hiding this comment

blazejkustra Jan 5, 2024

Choose a reason for hiding this comment

ishpaul777 Jan 6, 2024

Choose a reason for hiding this comment

ishpaul777 commented Jan 4, 2024 • edited Loading

blazejkustra commented Jan 4, 2024

blazejkustra Jan 5, 2024

Choose a reason for hiding this comment

blazejkustra commented Jan 5, 2024

ishpaul777 commented Jan 5, 2024

blazejkustra commented Jan 8, 2024

blazejkustra commented Jan 8, 2024

blazejkustra commented Jan 10, 2024

ishpaul777 commented Jan 10, 2024

blazejkustra commented Jan 16, 2024

ishpaul777 commented Jan 16, 2024

ishpaul777 commented Jan 16, 2024

aldo-expensify commented Jan 16, 2024

aldo-expensify commented Jan 16, 2024

jasperhuangg left a comment

Choose a reason for hiding this comment

ishpaul777 commented Jan 23, 2024 • edited Loading

situchan commented Jan 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

blazejkustra commented Jan 25, 2024

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

ishpaul777 commented Jan 4, 2024 •

edited

Loading

ishpaul777 commented Jan 4, 2024 •

edited

Loading

ishpaul777 commented Jan 23, 2024 •

edited

Loading

situchan commented Jan 25, 2024 •

edited

Loading