-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the red dot in LHN when the request is settled #34123
Conversation
@c3024 Please review the PR when you have a chance. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeredDotAndroidChrome-compressed.mp4iOS: NativeredDotiOSNative.mp4iOS: mWeb SafariredDotiOSSafari.mp4MacOS: Chrome / SafariredDotChrome.mp4MacOS: DesktopredDotDesktop.mp4 |
The bug is about a member of workspace requesting money and the red dot not disappearing after admin pays it. The test steps look like admin themselves are requesting the money and paying it. Please change the step of requesting money to requesting money from a member of the workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The bug is the same with these test steps. So I write the test step like this to make it easy for testing, don't need to test in two devices. |
Yes but I think it is better to have the QA steps with member and admin separate because it is the more common use case and in line with the identified bug steps. |
Let me update the test steps. |
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.25-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀
|
Details
Hide the red dot in LHN when the request is settled
Fixed Issues
$ #33998
PROPOSAL: #33998 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-01-09.at.17.19.45.mov
Android: mWeb Chrome
Screen.Recording.2024-01-09.at.14.29.31.mov
iOS: Native
Screen.Recording.2024-01-09.at.14.35.34.mov
iOS: mWeb Safari
Screen.Recording.2024-01-09.at.14.22.17.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-09.at.14.16.00.mov
MacOS: Desktop
Screen.Recording.2024-01-09.at.14.41.09.mov