[TS migration] Migrate 'WorkspaceList' page to TypeScript #34225

DylanDylann · 2024-01-10T11:10:16Z

Details

Fixed Issues

$ #31994
PROPOSAL: NA

Tests

Test case 1:

Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on "New workspace"
Click on the back button to go back to Workspace list screen
Verify that the new workspace in step 3 is displayed and all the workspaces are sorted in alphabetical order

Test case 2:

Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on any workspace
Click on three dot => delete workspace
Verify that the deleted workspace in step 3 disappeared

Test case 3:

Sign in with account that does not have any workspace
Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Verify that the empty workspace list screen is displayed (that contains "Manage business expenses, issue cards, send invoices, and more." )

Test case 4:

Open offline mode
Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on "New workspace"
Click on the back button to go back to Workspace list screen
Verify that the new workspace in step 4 is displayed and all the workspaces are sorted in alphabetical order
Turn off offline mode
Verify that the new workspace in step 4 is displayed and all the workspaces are sorted in alphabetical order

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test case 1:

Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on "New workspace"
Click on the back button to go back to Workspace list screen
Verify that the new workspace in step 3 is displayed and all the workspaces are sorted in alphabetical order

Test case 2:

Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on any workspace
Click on three dot => delete workspace
Verify that the deleted workspace in step 3 disappeared

Test case 3:

Sign in with account that does not have any workspace
Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Verify that the empty workspace list screen is displayed (that contains "Manage business expenses, issue cards, send invoices, and more." )

Test case 4:

Open offline mode
Go to the settings screen
Click on "Workspaces" options to go to Workspace list screen
Click on "New workspace"
Click on the back button to go back to Workspace list screen
Verify that the new workspace in step 4 is displayed and all the workspaces are sorted in alphabetical order
Turn off offline mode
Verify that the new workspace in step 4 is displayed and all the workspaces are sorted in alphabetical order

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.20-01-2024.18.43.23.webm

Android: mWeb Chrome

Screencast.from.20-01-2024.17.59.30.webm

iOS: Native

iOS: mWeb Safari

Screencast.from.20-01-2024.18.02.33.webm

MacOS: Chrome / Safari

Screencast.from.17-01-2024.14.43.40.webm

MacOS: Desktop

Screencast.from.20-01-2024.18.10.23.webm

melvin-bot · 2024-01-11T08:50:22Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/WorkspacesListPage.tsx

src/pages/workspace/withPolicy.tsx

src/pages/workspace/withPolicyAndFullscreenLoading.tsx

src/pages/workspace/WorkspacesListPage.tsx

s77rt · 2024-01-12T21:01:45Z

Please change the PR title to something more explanatory

s77rt · 2024-01-17T02:39:48Z

Can you please fix the lint / typescripts errors and let me know when this is ready for another review

DylanDylann · 2024-01-17T02:41:13Z

I will ping you soon. All are done, just this one need to be confirmed

DylanDylann · 2024-01-17T07:22:49Z

@s77rt I`ve fixed all your comments. Please help review again

src/libs/PolicyUtils.ts

src/pages/workspace/WorkspacesListPage.tsx

blazejkustra · 2024-01-17T17:05:56Z

Please rename the PR to: [TS migration] Migrate 'WorkspaceList' page to TypeScript

DylanDylann · 2024-01-18T08:24:32Z

@blazejkustra I fixed all your comments

src/pages/workspace/WorkspacesListPage.tsx

blazejkustra

LGTM

src/pages/workspace/WorkspacesListPage.tsx

DylanDylann · 2024-01-18T16:52:18Z

@s77rt Thanks for your suggestions. All are updated

src/pages/workspace/WorkspacesListPage.tsx

s77rt · 2024-01-20T09:53:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-01-20T09:53:23Z

@DylanDylann Please add the missing screenshots and write a clear testing steps

DylanDylann · 2024-01-20T11:50:10Z

@s77rt Added the missing screenshots and test cases. Also, I have a problem with ios native so can not test on it. Please help me on it

melvin-bot · 2024-01-21T18:36:16Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31994 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

s77rt · 2024-01-22T00:07:54Z

@francoisl

OSBotify · 2024-01-22T09:10:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-23T04:42:12Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-24T07:33:45Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-24T07:43:35Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

DylanDylann added 10 commits January 10, 2024 18:08

fix refactor

90bb3c6

fix add default params

6e7007a

fix update type HOC

25aef52

fix lint

c8c5314

fix lint

6cdeda4

fix lint

292611a

fix lint

abf4f2a

fix lint

325ae4c

fix lint

3f21668

fix lint

ad0171e

DylanDylann marked this pull request as ready for review January 11, 2024 08:50

DylanDylann requested a review from a team as a code owner January 11, 2024 08:50

melvin-bot bot requested review from s77rt and removed request for a team January 11, 2024 08:50

DylanDylann commented Jan 11, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

s77rt suggested changes Jan 12, 2024

View reviewed changes

DylanDylann added 4 commits January 17, 2024 01:32

fix: declare new types

1fbe36b

fix merge main

e56832a

fix: lint and ts issue

d9f88c9

fix: lint

9a37651

DylanDylann changed the title ~~Fix/31944: Refactor~~ Fix/31944: Migrate 'WorkspaceList' page to TypeScript Jan 16, 2024

DylanDylann added 2 commits January 17, 2024 10:40

fix: import issue

c59ace7

fix: add optional UserWallet props

9da907e

blazejkustra suggested changes Jan 17, 2024

View reviewed changes

src/libs/PolicyUtils.ts Show resolved Hide resolved

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

fix: remove default values

99bf195

blazejkustra suggested changes Jan 18, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

blazejkustra reviewed Jan 18, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

DylanDylann added 2 commits January 18, 2024 18:25

fix remove lodash

5558259

fix remove userWallet

7f711bd

blazejkustra approved these changes Jan 18, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

s77rt suggested changes Jan 18, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspacesListPage.tsx Show resolved Hide resolved

DylanDylann added 2 commits January 18, 2024 23:44

fix just pick whatever we need

c76adb5

fix policies

f8b0a7e

s77rt reviewed Jan 19, 2024

View reviewed changes

src/pages/workspace/WorkspacesListPage.tsx Outdated Show resolved Hide resolved

DylanDylann added 2 commits January 20, 2024 17:20

fix remove null check

d15af94

fix merge main

ae2acc7

s77rt approved these changes Jan 21, 2024

View reviewed changes

Julesssss assigned DylanDylann Jan 22, 2024

Julesssss approved these changes Jan 22, 2024

View reviewed changes

Julesssss merged commit b542031 into Expensify:main Jan 22, 2024
1 check passed

github-actions bot mentioned this pull request Jan 23, 2024

Deploy Checklist: New Expensify 2024-01-23 #34942

Closed

35 tasks

melvin-bot bot mentioned this pull request Jan 24, 2024

[HOLD for payment 2024-01-31] [$250] [TS migration] Migrate 'WorkspaceList' page to TypeScript #31994

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'WorkspaceList' page to TypeScript #34225

[TS migration] Migrate 'WorkspaceList' page to TypeScript #34225

DylanDylann commented Jan 10, 2024 •

edited

Loading

melvin-bot bot commented Jan 11, 2024

s77rt commented Jan 12, 2024

s77rt commented Jan 17, 2024

DylanDylann commented Jan 17, 2024 •

edited

Loading

DylanDylann commented Jan 17, 2024

blazejkustra commented Jan 17, 2024

DylanDylann commented Jan 18, 2024

blazejkustra left a comment

DylanDylann commented Jan 18, 2024

s77rt commented Jan 20, 2024 •

edited

Loading

s77rt commented Jan 20, 2024

DylanDylann commented Jan 20, 2024

melvin-bot bot commented Jan 21, 2024

s77rt commented Jan 22, 2024

OSBotify commented Jan 22, 2024

OSBotify commented Jan 23, 2024

OSBotify commented Jan 24, 2024

OSBotify commented Jan 24, 2024

[TS migration] Migrate 'WorkspaceList' page to TypeScript #34225

[TS migration] Migrate 'WorkspaceList' page to TypeScript #34225

Conversation

DylanDylann commented Jan 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 11, 2024

s77rt commented Jan 12, 2024

s77rt commented Jan 17, 2024

DylanDylann commented Jan 17, 2024 • edited Loading

DylanDylann commented Jan 17, 2024

blazejkustra commented Jan 17, 2024

DylanDylann commented Jan 18, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

DylanDylann commented Jan 18, 2024

s77rt commented Jan 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Jan 20, 2024

DylanDylann commented Jan 20, 2024

melvin-bot bot commented Jan 21, 2024

s77rt commented Jan 22, 2024

OSBotify commented Jan 22, 2024

OSBotify commented Jan 23, 2024

OSBotify commented Jan 24, 2024

OSBotify commented Jan 24, 2024

DylanDylann commented Jan 10, 2024 •

edited

Loading

DylanDylann commented Jan 17, 2024 •

edited

Loading

s77rt commented Jan 20, 2024 •

edited

Loading