Fix versionCode regex to work on ubuntu #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
Jun 9, 2021
|
No reason not to merge this now. |
49 tasks
|
🚀 Deployed to staging in version: 1.0.65-5🚀
|
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Jag96
Details
Apparently GNU grep's basic regex type doesn't treat
\das a special character for[0-9]Fixed Issues
Fixes #2918
Tests
Run a production deploy and see if it works 🙃
I did some local testing to confirm this produces the correct output from the Expensidev/Expensify.cash directory both on macOS and in my ubuntu VM: