-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redirects.csv #34771
Update redirects.csv #34771
Conversation
Updating all the redirect links from Community to Help.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
A preview of your ExpensifyHelp changes have been deployed to https://e5aab3d5.helpdot.pages.dev ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@caitlinwhite1 you need to complete the checklist and sign CLA bot
I have read the CLA Document and I hereby sign the CLA |
done! Thanks @MonilBhavsar! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Thanks! |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.30-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀
|
Updating all the redirect links from Community to Help.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop