-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: fix failing e2ePerformanceTest android build step #34786
Conversation
Removing C+, getting some more internal reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, once we get a couple more reviews lets merge and observe the next
Please review @roryabraham @AndrewGable |
I ran into this locally yesterday too. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.30-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.30-1 🚀
|
Details
Currently the android builds in the e2e performance testing pipelines aren't working.
The reason seems to be that it's trying to use java 11 instead of 17. In our other pipelines we added a "Setup Java" step that installs java 17. The same is now happening for the e2e android builds.
I actually cleaned up the action a bit. We had a composite action for building the e2e apk, which we weren't using. I updated it to use it again to make the
e2ePerformanceTests.yml
action leaner.I also added code back we were temporarily disabling, but which should be good to use now.
Note: I can't test these changes in our env, so we have to merge it, test it, and then I might need to open follow up PRs if something doesn't work 🙇♂️
Fixed Issues
$ #34108
PROPOSAL:
Tests
This is a dev/CI only changes and requires no tests
Offline tests
QA Steps
This is a dev/CI only changes and requires no tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
This is a dev/CI only changes and requires no screenshots
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop