Fix: User navigates to many pages when quickly press them #34861

tienifr · 2024-01-21T17:29:23Z

Details

On Android, user navigates to many pages when quickly taping them.

Fixed Issues

$ #32753
PROPOSAL: #32753 (comment)

Tests

Settings > Profile > Personal details
Quickly press Address then Date of birth fields
Verify that only Adress edit page opens

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Settings > Profile > Personal details
Quickly press Address then Date of birth fields
Verify that only Adress edit page opens

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-22.at.02.04.17-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-01-22.at.02.06.47-compressed.mov

iOS: Native

Screen.Recording.2024-01-22.at.02.08.33-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-01-22.at.02.10.19-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-22.at.02.01.28-compressed.mov

MacOS: Desktop

Screen.Recording.2024-01-22.at.02.01.28-compressed.mov

melvin-bot · 2024-01-21T19:07:26Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-01-25T07:39:28Z

@c3024 Bump here.

c3024 · 2024-01-27T16:24:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

dobAndroid.mp4

Android: mWeb Chrome

dobAndroidChrome.mp4

iOS: Native

dobiOS.mp4

iOS: mWeb Safari

dobiOSSafari.mp4

MacOS: Chrome / Safari

dobChrome.mp4

MacOS: Desktop

dobDesktop.mp4

c3024

LGTM

tienifr · 2024-02-01T07:48:09Z

@puneetlath This needs your approval.

puneetlath

Can you remind me why the PersonalDetailsInitialPage is the only menu item group that this is relevant to?

puneetlath · 2024-02-02T20:29:36Z

src/components/MenuItemGroup.tsx

+    children: React.ReactNode;
+
+    /** Whether or not to use the single execution hook */
+    shouldUseSingleExecution?: boolean;


When does this ever get set to false?

This is just like what we did in MenuItemList here. I can remove it without any problem.

tienifr · 2024-02-06T14:28:23Z

Can you remind me why the PersonalDetailsInitialPage is the only menu item group that this is relevant to?

@puneetlath This is the one in OP. Do you want me to investigate and fix every other places as well? But I think that's quite risky and out of scope. Let's apply to this component first.

puneetlath

Ok, thanks for the explanations. Makes sense.

luacmartins · 2024-02-06T16:43:59Z

Hmm lint is failing on main coming from this PR:

/home/runner/work/App/App/src/components/MenuItem.tsx
Error:   387:45  error  Promise returned in function argument where a void return was expected  @typescript-eslint/no-misused-promises

Fix here

OSBotify · 2024-02-07T10:09:12Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-07T10:25:45Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-08T18:21:03Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 7 commits December 18, 2023 16:21

fix: add singleExecution for menu items

48d422a

disable when is executing

b81373f

Merge branch 'main' of https://github.com/tienifr/App into fix/32753

3a7ef96

context approach

d2f5a1d

remove redundant imports

ddffc25

fix lint

5b440b7

execute singleExecution

f96ae97

tienifr marked this pull request as ready for review January 21, 2024 19:07

tienifr requested a review from a team as a code owner January 21, 2024 19:07

melvin-bot bot requested review from c3024 and removed request for a team January 21, 2024 19:07

tienifr mentioned this pull request Jan 21, 2024

[HOLD for payment 2024-03-13] [$1000] Android - Personal Details - User can open both Address and Date of birth when quick tap on them #32753

Closed

6 tasks

c3024 approved these changes Jan 28, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath January 28, 2024 11:20

Merge branch 'main' into fix/32753

14a1e91

puneetlath reviewed Feb 2, 2024

View reviewed changes

puneetlath approved these changes Feb 6, 2024

View reviewed changes

puneetlath merged commit 13f832c into Expensify:main Feb 6, 2024
18 checks passed

luacmartins mentioned this pull request Feb 6, 2024

Fix lint on main #35920

Merged

50 tasks

github-actions bot mentioned this pull request Feb 7, 2024

Deploy Checklist: New Expensify 2024-02-07 #35983

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: User navigates to many pages when quickly press them #34861

Fix: User navigates to many pages when quickly press them #34861

tienifr commented Jan 21, 2024 •

edited

Loading

melvin-bot bot commented Jan 21, 2024

tienifr commented Jan 25, 2024

c3024 commented Jan 27, 2024 •

edited

Loading

c3024 left a comment

tienifr commented Feb 1, 2024

puneetlath left a comment

puneetlath Feb 2, 2024

tienifr Feb 6, 2024 •

edited

Loading

tienifr commented Feb 6, 2024 •

edited

Loading

puneetlath left a comment

luacmartins commented Feb 6, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

Fix: User navigates to many pages when quickly press them #34861

Fix: User navigates to many pages when quickly press them #34861

Conversation

tienifr commented Jan 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 21, 2024

tienifr commented Jan 25, 2024

c3024 commented Jan 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

tienifr commented Feb 1, 2024

puneetlath left a comment

Choose a reason for hiding this comment

puneetlath Feb 2, 2024

Choose a reason for hiding this comment

tienifr Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

tienifr commented Feb 6, 2024 • edited Loading

puneetlath left a comment

Choose a reason for hiding this comment

luacmartins commented Feb 6, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

tienifr commented Jan 21, 2024 •

edited

Loading

c3024 commented Jan 27, 2024 •

edited

Loading

tienifr Feb 6, 2024 •

edited

Loading

tienifr commented Feb 6, 2024 •

edited

Loading