feat: allow policy admins to edit the report fields of a non-settled report #34889

allroundexperts · 2024-01-22T14:27:53Z

Details

Allow policy admins to edit the report fields of a non-settled report

Fixed Issues

$ #34625
PROPOSAL: N/A

Tests

As a User A, create a workspace and add User B to it.
As User B, make several money requests from the workspace that User A created.
Execute the following in console for both users, replacing the policyID with the policyID of the created workspace.

Onyx.set('policyReportFields_47FB5109E0654E15', {
    text_title: {
        "defaultValue": "{report:type} #{report:reportID}",
        "fieldID": "text_title",
        "name": "Title",
        "orderWeight": 0,
        "type": "formula",

    },
    field_id_TEST: {
        "defaultValue": null,
        "fieldID": "field_id_TEST",
        "name": "Tax Code",
        "orderWeight": 1,
        "type": "text",
    },
    field_id_ANOTHER_ONE: {

        "defaultValue": "option A",
        "fieldID": "field_id_ANOTHER_ONE",
        "name": "Project",
        "orderWeight": 2,
        "type": "dropdown",
     	"values": ["option1", "option2", "option3"]
    },
    field_id_DATE_FIELD: {
        "defaultValue": "2023-11-19",
        "fieldID": "field_id_DATE_FIELD",
        "name": "Effective Date",
        "orderWeight": 3,
        "type": "date",
    }
})

Enable canUseReportFields beta in Permissions.ts file.
Verify that the User A can click the report fields, while the User B have them as disabled.
As User A, Pay the expense report and verify that the fields get disabled both for User A and User B.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

As a User A, create a workspace and add User B to it.
As User B, make several money requests from the workspace that User A created.
Execute the following in console for both users, replacing the policyID with the policyID of the created workspace.

Onyx.set('policyReportFields_47FB5109E0654E15', {
    text_title: {
        "defaultValue": "{report:type} #{report:reportID}",
        "fieldID": "text_title",
        "name": "Title",
        "orderWeight": 0,
        "type": "formula",

    },
    field_id_TEST: {
        "defaultValue": null,
        "fieldID": "field_id_TEST",
        "name": "Tax Code",
        "orderWeight": 1,
        "type": "text",
    },
    field_id_ANOTHER_ONE: {

        "defaultValue": "option A",
        "fieldID": "field_id_ANOTHER_ONE",
        "name": "Project",
        "orderWeight": 2,
        "type": "dropdown",
     	"values": ["option1", "option2", "option3"]
    },
    field_id_DATE_FIELD: {
        "defaultValue": "2023-11-19",
        "fieldID": "field_id_DATE_FIELD",
        "name": "Effective Date",
        "orderWeight": 3,
        "type": "date",
    }
})

Enable canUseReportFields beta in Permissions.ts file.
Verify that the User A can click the report fields, while the User B have them as disabled.
As User A, Pay the expense report and verify that the fields get disabled both for User A and User B.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Skipping because I'm having issues with android build.

Android: mWeb Chrome

Screen.Recording.2024-01-22.at.7.06.40.PM.mov

iOS: Native

Screen.Recording.2024-01-22.at.7.05.58.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-22.at.7.05.38.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-22.at.6.58.40.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-22.at.7.02.24.PM.mov

…report

melvin-bot · 2024-01-22T14:27:58Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam · 2024-01-23T01:59:35Z

This one is pretty straightforward so no C+ needed for this

thienlnam · 2024-01-23T01:59:47Z

@allroundexperts Can you please resolve conflicts for this from your other PR?

allroundexperts · 2024-01-23T18:51:12Z

@thienlnam Resolved.

allroundexperts · 2024-01-24T23:18:15Z

Hi @thienlnam!
Can we please merge this?

thienlnam · 2024-01-25T01:46:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-01-25T01:52:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-25T09:07:31Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.32-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

thienlnam · 2024-01-26T05:46:33Z

By the way, on staging/production we can't update Onyx like that - so for future PRs you'll have to set up different steps so QA can test these PRs. Additionally, they already have all betas enabled so you don't need to include that

These are the steps that QA can take to get a collect workspace in NewDot

Go to OldDot and open the settings for the Collect/Control policy

In the JS console with the policy open do:

p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();
This will make it so that any user you invite to that policy going forward will have a Workspace Chat created in NewDot for that policy. It will not retroactively create a workspace chat for the policy owner or any other user that was already a member of the policy before you enabled the beta.

allroundexperts · 2024-01-26T10:47:39Z

Noted thanks @thienlnam!

OSBotify · 2024-01-29T19:07:16Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

feat: allow policy admins to edit the report fields of a non-settled …

698dbd9

…report

allroundexperts requested a review from a team as a code owner January 22, 2024 14:27

melvin-bot bot requested review from cubuspl42 and removed request for a team January 22, 2024 14:27

allroundexperts mentioned this pull request Jan 22, 2024

[HOLD for payment 2024-02-05] Only allow policy owner / report submitter to update report field values #34625

Closed

thienlnam requested review from thienlnam and removed request for cubuspl42 January 23, 2024 01:59

allroundexperts added 2 commits January 23, 2024 23:46

feat: merge with main

5fb4f47

feat: merge with main

da41efb

thienlnam approved these changes Jan 25, 2024

View reviewed changes

thienlnam merged commit 726c281 into Expensify:main Jan 25, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 25, 2024

Deploy Checklist: New Expensify 2024-01-25 #35138

Closed

48 tasks

thienlnam mentioned this pull request Jan 31, 2024

feat: Integrate report fields with backend #34483

Merged

50 tasks

m-natarajan mentioned this pull request Apr 29, 2024

App crashes after pasting a bunch of text from a gdoc into the compose box and navigating to the bottom #41227

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow policy admins to edit the report fields of a non-settled report #34889

feat: allow policy admins to edit the report fields of a non-settled report #34889

allroundexperts commented Jan 22, 2024

melvin-bot bot commented Jan 22, 2024

thienlnam commented Jan 23, 2024

thienlnam commented Jan 23, 2024

allroundexperts commented Jan 23, 2024

allroundexperts commented Jan 24, 2024

thienlnam commented Jan 25, 2024 •

edited

Loading

OSBotify commented Jan 25, 2024

OSBotify commented Jan 25, 2024

thienlnam commented Jan 26, 2024

allroundexperts commented Jan 26, 2024

OSBotify commented Jan 29, 2024

feat: allow policy admins to edit the report fields of a non-settled report #34889

feat: allow policy admins to edit the report fields of a non-settled report #34889

Conversation

allroundexperts commented Jan 22, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 22, 2024

thienlnam commented Jan 23, 2024

thienlnam commented Jan 23, 2024

allroundexperts commented Jan 23, 2024

allroundexperts commented Jan 24, 2024

thienlnam commented Jan 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jan 25, 2024

OSBotify commented Jan 25, 2024

thienlnam commented Jan 26, 2024

allroundexperts commented Jan 26, 2024

OSBotify commented Jan 29, 2024

thienlnam commented Jan 25, 2024 •

edited

Loading