-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Settlement button total #34909
Fix Settlement button total #34909
Conversation
@@ -1801,28 +1801,6 @@ function hasNonReimbursableTransactions(iouReportID: string | undefined): boolea | |||
return transactions.filter((transaction) => transaction.reimbursable === false).length > 0; | |||
} | |||
|
|||
function getMoneyRequestReimbursableTotal(report: OnyxEntry<Report>, allReportsDict: OnyxCollection<Report> = null): number { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this method because getMoneyRequestSpendBreakdown
does all of this already and having 2 methods to do that same thing is confusing and leads to errors
Hi, @rushatgabhane, do you have time to review this PR? I noticed you are the c+ for issue #34626. Also, I don't have the expensify card and I've got a lot on my plate. 😂 |
@ntdiary yeah sure, thanks |
Assigning @rushatgabhane per the comment above. |
Bump for review |
Reviewer Checklist
Screenshots/Videos |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.33-0 🚀
|
@luacmartins @techievivek I'm not sure which account the QA team should use for this PR? Can you verify internally? |
@kbecciv do you have any account with the expensify card setup? |
@luacmartins The Applausecard account has an Expensify card. Recording.5960.mp4 |
@kbecciv could you try creating a manual request from the Workspace chat OR from global create? |
Thank you for guide me Recording.5962.mp4 |
Np, sorry I wasn't clearer in my initial steps. Anyways, it seems like the report with the ecard transactions had already been closed/approved so that's why you couldn't create transactions on it. |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
Details
Displays the actual report reimbursable total in the display.
Fixed Issues
$ #34618
$ #34626
Tests
Pre-requisite: admin account with a free workspace and expensify card set up
Offline tests
N/A
QA Steps
Same as test steps.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
![desktop](https://github.com/Expensify/App/assets/22219519/d3213493-86a6-43b1-9345-4768423c985d)