Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Single brackets not double brackets #3491

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

Details

Incorrect bash operator

Fixed Issues

Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2787308706?check_suite_focus=true

Tests

Merge-to-test 🙃

But I did do some local testing in my ubuntu VM:

vagrant@expensidev2004:/vagrant/Expensify.cash$ if [[ -z ]]; then echo "empty"; else echo "not empty"; fi;
bash: unexpected argument `]]' to conditional unary operator
bash: syntax error near `;'
vagrant@expensidev2004:/vagrant/Expensify.cash$ if [ -z ]; then echo "empty"; else echo "not empty"; fi;
empty
vagrant@expensidev2004:/vagrant/Expensify.cash$ if [ -z 1.0.61-1 ]; then echo "empty"; else echo "not empty"; fi;
not empty

QA Steps

None.

Tested On

To be tested on GitHub only.

@roryabraham roryabraham requested a review from AndrewGable June 9, 2021 20:52
@roryabraham roryabraham self-assigned this Jun 9, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 9, 2021 20:52
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 9, 2021 20:52
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging to test CPs to fix deploy blockers.

@AndrewGable AndrewGable merged commit bac6769 into main Jun 9, 2021
@AndrewGable AndrewGable deleted the Rory-FixCPConditional branch June 9, 2021 20:57
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Single brackets not double brackets [No QA] Single brackets not double brackets Jun 10, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants